From: Dave Hansen <dave.hansen@intel.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Binbin Wu <binbin.wu@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH] x86/kvm: Override default caching mode for SEV-SNP and TDX
Date: Tue, 15 Oct 2024 06:14:29 -0700 [thread overview]
Message-ID: <3ae51aac-085a-44f6-9f6f-565c7c5687ad@intel.com> (raw)
In-Reply-To: <294ce9a5-09b8-4248-85ad-18bdea479c73@suse.com>
On 10/15/24 03:12, Jürgen Groß wrote:
>>
>> + /* Set WB as the default cache mode for SEV-SNP and TDX */
>> + mtrr_overwrite_state(NULL, 0, MTRR_TYPE_WRBACK);
>
> Do you really want to do this for _all_ KVM guests?
>
> I'd expect this call to be conditional on TDX or SEV-SNP.
I was confused by this as well.
Shouldn't mtrr_overwrite_state() be named something more like:
guest_force_mtrr_state()
or something?
The mtrr_overwrite_state() comment is pretty good, but it looks quite
confusing from the caller.
next prev parent reply other threads:[~2024-10-15 13:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 9:58 Kirill A. Shutemov
2024-10-15 10:12 ` Jürgen Groß
2024-10-15 12:31 ` Kirill A. Shutemov
2024-10-15 12:37 ` Jürgen Groß
2024-10-15 13:14 ` Dave Hansen [this message]
2024-10-15 13:54 ` Kirill A. Shutemov
2024-10-15 14:00 ` Juergen Gross
2024-10-16 10:50 ` [PATCH] x86/mtrr: Rename mtrr_overwrite_state() to guest_force_mtrr_state() Kirill A. Shutemov
2024-10-19 5:11 ` Michael Kelley
2024-10-29 15:13 ` Kirill A. Shutemov
2024-10-29 17:37 ` Dave Hansen
2024-10-29 19:32 ` Kirill A. Shutemov
2024-10-20 11:07 ` [PATCH] x86/kvm: Override default caching mode for SEV-SNP and TDX Paolo Bonzini
2025-01-24 20:59 ` Sean Christopherson
2025-01-28 9:40 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae51aac-085a-44f6-9f6f-565c7c5687ad@intel.com \
--to=dave.hansen@intel.com \
--cc=binbin.wu@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®