From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22433EEB57B for ; Sun, 10 Sep 2023 03:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343633AbjIJD7m (ORCPT ); Sat, 9 Sep 2023 23:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235178AbjIJD7j (ORCPT ); Sat, 9 Sep 2023 23:59:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E30C1BF for ; Sat, 9 Sep 2023 20:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=93PPKKb8Appgi3LlaV1XqgV2yIzq3wC9saJjFfjfqgg=; b=tDXmZbJBkV6a1BFTA0WhyhY9ft 2ogrT7Tv0UZj0hnwCiVQuUVyfF+WiAg1Fp4YtxngDHKF+kz4xhmEP0euZzbdOMb2kDNZhPiBP6c28 w6/1VHySojg74GWk3rzts4YFvuMmyKvs6y7mMoGcr/+3sq2x5rmsRy4FsvMYqNsbD/oVWweL/HTdJ vQycnt6TqU00zV9esW9A5Ib4JJf4b/oS/ezfEZAJc4aDSqMvgQgbI6iyHelWXg2MWmDK+fulvHO4A gGqtu//Ed3/KZDIwbAG9/qOepvQrlotNRruUtL0N/bvQAAMXwlYnsS3ZEDi0mpXQxgRqeghligY80 iYZM51/A==; Received: from [2601:1c2:980:9ec0::9fed] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qfBbW-00G7D1-1R; Sun, 10 Sep 2023 03:59:22 +0000 Message-ID: <3ae5be2b-8075-5a4d-65c7-7282a44909f3@infradead.org> Date: Sat, 9 Sep 2023 20:59:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] drm: fix doc warnings related to drm connector Content-Language: en-US To: Bagas Sanjaya , Bragatheswaran Manickavel , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230909110343.8103-1-bragathemanick0908@gmail.com> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/23 20:54, Bagas Sanjaya wrote: > On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote: >> Addressing drm dp/hdmi connector related kernel documentation >> warning and add more information about these values. > > What are these? > There are already patches for these issues. Please check latest linux-next and make patches to it instead of using mainline. Thanks. >> >> Signed-off-by: Bragatheswaran Manickavel >> --- >> drivers/gpu/drm/drm_connector.c | 2 ++ >> include/drm/drm_connector.h | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c >> index bf8371dc2a61..084c95785dda 100644 >> --- a/drivers/gpu/drm/drm_connector.c >> +++ b/drivers/gpu/drm/drm_connector.c >> @@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector, >> /** >> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property >> * @connector: connector to create the Colorspace property on. >> + * @supported_colorspaces: to get hdmi supported colorspaces. >> * >> * Called by a driver the first time it's needed, must be attached to desired >> * HDMI connectors. >> @@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property); >> /** >> * drm_mode_create_dp_colorspace_property - create dp colorspace property >> * @connector: connector to create the Colorspace property on. >> + * @supported_colorspaces: to get dp supported colorspaces. >> * >> * Called by a driver the first time it's needed, must be attached to desired >> * DP connectors. >> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h >> index d300fde6c1a4..556d66dd122c 100644 >> --- a/include/drm/drm_connector.h >> +++ b/include/drm/drm_connector.h >> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status { >> * ITU-R BT.601 colorimetry format >> * The DP spec does not say whether this is the 525 or the 625 >> * line version. >> + * @DRM_MODE_COLORIMETRY_COUNT: >> + * Represents the count of colorspaces. >> */ >> enum drm_colorspace { >> /* For Default case, driver will set the colorspace */ > > Oh, you mean to add description for colorspace-related fields. > > Thanks. > > -- ~Randy