mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Tejun Heo" <htejun@gmail.com>
Cc: "Greg KH" <greg@kroah.com>, "Chris Rankin" <rankincj@yahoo.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	linux-usb-devel@lists.sourceforge.net,
	linux-kernel <linux-kernel@vger.kernel.org>,
	stable@kernel.org
Subject: Re: [PATCH] driver-core: don't free devt_attr till the device is released
Date: Thu, 10 May 2007 17:33:27 +0200	[thread overview]
Message-ID: <3ae72650705100833h35dbc5fer7553529d643c742c@mail.gmail.com> (raw)
In-Reply-To: <46432FFD.1040304@gmail.com>

On 5/10/07, Tejun Heo <htejun@gmail.com> wrote:
> Currently, devt_attr for the "dev" file is freed immediately on device
> removal, but if the "dev" sysfs file is open when a device is removed,
> sysfs will access its attribute structure for further access including
> close resulting in jumping to garbled address.  Fix it by postponing
> freeing devt_attr to device release time.
>
> Note that devt_attr for class_device is already freed on release.

Hi Tejun,
your rework removes the "owner" field from the attributes. I think we
kept the "dev" and "uevent" attribute as part of "struct device" only
to be able to assign it the actual owner of the module that has
created the device. The attribute can probably just live as one
instance statically in the driver core now?

Thanks,
Kay

  parent reply	other threads:[~2007-05-10 15:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <963898.10047.qm@web52906.mail.re2.yahoo.com>
2007-05-09  9:40 ` [linux-usb-devel] Bug creating USB endpoints in 2.6.20.x (kernel bug 8198) Tejun Heo
2007-05-09 12:24   ` Chris Rankin
2007-05-09 13:30     ` Tejun Heo
2007-05-09 13:56       ` Chris Rankin
2007-05-09 14:11         ` Tejun Heo
2007-05-09 14:35           ` Dmitry Torokhov
2007-05-09 14:58             ` Tejun Heo
2007-05-09 21:09               ` Chris Rankin
2007-05-09 14:57       ` Greg KH
2007-05-09 15:01         ` Tejun Heo
2007-05-09 15:40           ` Greg KH
2007-05-10 14:45             ` [PATCH] driver-core: don't free devt_attr till the device is released Tejun Heo
2007-05-10 15:05               ` Greg KH
2007-05-10 15:13                 ` Tejun Heo
2007-05-10 15:17                   ` Greg KH
2007-05-10 15:33               ` Kay Sievers [this message]
2007-05-10 15:41                 ` Tejun Heo
2007-05-10 15:52               ` Alan Stern
2007-05-10 16:18                 ` Tejun Heo
2007-05-10 14:25         ` [PATCH 2.6.21-mm2] driver-core: make devt_attr and uevent_attr static Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ae72650705100833h35dbc5fer7553529d643c742c@mail.gmail.com \
    --to=kay.sievers@vrfy.org \
    --cc=greg@kroah.com \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rankincj@yahoo.com \
    --cc=stable@kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®