From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Greg KH" <gregkh@suse.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"rae l" <crquan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.
Date: Mon, 3 Dec 2007 01:46:57 +0100 [thread overview]
Message-ID: <3ae72650712021646r8376bb9s73e326db5789839d@mail.gmail.com> (raw)
In-Reply-To: <20071202225320.GA23359@suse.de>
On Dec 2, 2007 11:53 PM, Greg KH <gregkh@suse.de> wrote:
>
> On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote:
> > Greg KH <gregkh@suse.de> writes:
> >
> > > On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote:
> > >> On Dec 2, 2007 12:48 PM, Greg KH <gregkh@suse.de> wrote:
> > >> ...
> > >> > > and where is a detailed explaination on kern_mount? could someone give
> > >> > > some comments or documentation pointers on this?
> > >> >
> > >> > See the patches that Eric Biederman just posted to lkml for why this
> > >> > structure is a static pointer this way right now, it's in preparation
> > >> > for future patches.
> > >> I have checked commit 7d0c7d676cc066413e1583b5af9fba8011972d41 by Eric
> > >> W. Biederman,
> > >>
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7d0c7d676cc066413e1583b5af9fba8011972d41
> > >>
> > >> which just make sysfs_mount from externally visible to static that
> > >> could be only used in one c file,
> > >>
> > >> but I mean that the static variable is still on kernel bss section,
> > >> this consumes a pointer (4 or 8 bytes) memory,
> > >>
> > >> through a grep from fs/sysfs/, it appears that the variable
> > >> sysfs_mount is only used in the sysfs_init function,
> > >>
> > >> $ grep -RsInw sysfs_mount fs/sysfs/
> > >> fs/sysfs/mount.c:25:static struct vfsmount *sysfs_mount;
> > >> fs/sysfs/mount.c:101: sysfs_mount = kern_mount(&sysfs_fs_type);
> > >> fs/sysfs/mount.c:102: if (IS_ERR(sysfs_mount)) {
> > >> fs/sysfs/mount.c:104: err = PTR_ERR(sysfs_mount);
> > >> fs/sysfs/mount.c:105: sysfs_mount = NULL;
> > >>
> > >> we could mark this variable an automatic one, which scope is just in
> > >> this function, thus created and destroyed with the stack,
> > >> this approach does not consume a pointer on kernel bss section,
> > >>
> > >> Why not do this?
> > >
> > > Again, see the patches he _just_ posted to lkml, the specific message
> > > you are looking for is:
> > > Message-ID: <m11wa693t0.fsf@ebiederm.dsl.xmission.com>
> > > Subject: [PATCH 01/10] sysfs: Make sysfs_mount static again.
> > >
> > > Also see the whole long thread for more details.
> >
> > As long as you aren't talking about the subthread that spun off
> > about GPL exports, and just the rest of my patches and showing
> > where I am going that sounds reasonable.
>
> Yes, that subthread really had nothing to do with your patch series :)
>
> > > If you have further questions about this, please ask Eric.
> >
> > Honestly I think there is a reasonable chance we could kill
> > sysfs_mount and the kern_mount entirely. We used to need the
> > internal kernel mount because of the coupling between sysfs_dirent
> > and the directory dentries but that is gone now.
>
> Hm, this does take into account the fact that we internally mount sysfs
> as part of the boot process to determine the boot disk major:minor,
> right? As long as we don't break that, I'm happy.
That cruft is going away with the block patch in your tree.
Kay
next prev parent reply other threads:[~2007-12-03 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-01 20:31 rae l
2007-12-02 4:48 ` Greg KH
2007-12-02 6:52 ` rae l
2007-12-02 7:54 ` Greg KH
2007-12-02 22:22 ` Eric W. Biederman
2007-12-02 22:53 ` Greg KH
2007-12-03 0:46 ` Kay Sievers [this message]
2007-12-03 1:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae72650712021646r8376bb9s73e326db5789839d@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=crquan@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®