Re: [PATCH 1/7] LinuxPPS core support.

["Kay Sievers" <kay.sievers@vrfy.org>]

On Thu, Mar 6, 2008 at 1:09 PM, Rodolfo Giometti <giometti@linux.it> wrote:
> This patch adds the kernel side of the PPS support currently named
>  "LinuxPPS".

>  diff --git a/include/linux/pps.h b/include/linux/pps.h
>  new file mode 100644
>  index 0000000..c455443
>  --- /dev/null
>  +++ b/include/linux/pps.h
>  @@ -0,0 +1,204 @@

>  +/* The main struct */
>  +struct pps_device {
>  +       struct pps_source_info info;            /* PSS source info */
>  +
>  +       struct pps_kparams params;              /* PPS's current params */
>  +
>  +       __u32 assert_sequence;                  /* PPS' assert event seq # */
>  +       __u32 clear_sequence;                   /* PPS' clear event seq # */
>  +       struct pps_ktime assert_tu;
>  +       struct pps_ktime clear_tu;
>  +       int current_mode;                       /* PPS mode at event time */
>  +
>  +       int go;                                 /* PPS event is arrived? */
>  +       wait_queue_head_t queue;                /* PPS event queue */
>  +
>  +       unsigned int id;                        /* PPS source unique ID */
>  +       struct cdev cdev;
>  +       struct device *dev;
>  +       int devno;
>  +       struct fasync_struct *async_queue;      /* fasync method */
>  +       spinlock_t lock;
>  +
>  +       atomic_t usage;                         /* usage count */
>  +       wait_queue_head_t usage_queue;
>  +
>  +       struct class class_dev;

Why is an entire class embedded into every device? :)

Kay