From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
open list <linux-kernel@vger.kernel.org>,
Gurchetan Singh <gurchetansingh@chromium.org>,
Gerd Hoffmann <kraxel@redhat.com>,
David Airlie <airlied@redhat.com>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/virtio: Fix GEM handle creation UAF
Date: Tue, 10 Jan 2023 02:28:45 +0300 [thread overview]
Message-ID: <3ae74f28-580b-3b53-3d7b-e8bde97dabe3@collabora.com> (raw)
In-Reply-To: <20221216233355.542197-2-robdclark@gmail.com>
On 12/17/22 02:33, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Userspace can guess the handle value and try to race GEM object creation
> with handle close, resulting in a use-after-free if we dereference the
> object after dropping the handle's reference. For that reason, dropping
> the handle's reference must be done *after* we are done dereferencing
> the object.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/virtio/virtgpu_ioctl.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
Added fixes/stable tags and applied this virtio-gpu patch to misc-fixes.
The Panfrost patch is untouched.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-01-09 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 23:33 [PATCH] drm/panfrost: " Rob Clark
2022-12-16 23:33 ` [PATCH] drm/virtio: " Rob Clark
2022-12-16 23:50 ` Chia-I Wu
2023-01-09 23:28 ` Dmitry Osipenko [this message]
2023-01-10 1:47 ` Rob Clark
2023-01-10 9:38 ` Dmitry Osipenko
2022-12-16 23:59 ` [PATCH] drm/panfrost: " Chia-I Wu
2022-12-17 0:20 ` Rob Clark
2022-12-17 0:53 ` Chia-I Wu
2022-12-19 14:01 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae74f28-580b-3b53-3d7b-e8bde97dabe3@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®