From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36F9C3CAE88 for ; Wed, 22 Apr 2026 12:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860987; cv=none; b=qT7GCEH7VwN0jkAtOMHtVrut5DxA0G6iNL5c9yAD0WcHR4CBOwPmdEM6cCXYTJtBbDye2nW4F/QFv4gydJzxKtrUgtlXO7NAiEa0RlIEhbSsPX349Q6bhrjZ3TlvmilQgO1JA6Y8wCG4pMp4jc2zlElWIckkd1y5Fsm4IziYRSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776860987; c=relaxed/simple; bh=HE/L6J58Kw/Um32nCqXMSP3+6Ed7LZDOAX0T3RjwuPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XM89lTMuE3uQUrndM1fZlx3/MDTS1iUDwB/Ja5ZvuJP0V2nxii5pt+qq0+vG5E+S7RlpTAuICze8dkyavkmkcZnzKjMoSf9spHNzYQSRFKnqJrwYhQKjCYSoBTCoTeLk23yEoHKoYnFSk82ESvScyEHpJwpm9fbpEGwxRTO6s5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gazFE/Ax; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VwfcEZtK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gazFE/Ax"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VwfcEZtK" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M998TZ2064805 for ; Wed, 22 Apr 2026 12:29:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=; b=gazFE/Ax7ZwhxYWN GwCnQh6tjbpgKQZ4CoGkv1RC16zfJBfoG5/cb9qrE7ih1XzGUUFJeWWkeReTgXlM nDKKIO5c78r9a2mVqUYv74SWtOXzUC0aY7wyqL8faOBH7+1BfBzvlNYNRT8TJj4d 7KmX9CfevABVKK9rIAu8opyOiWkRD9YklCnxazx7+MUZ3Q5z5fX8lRCrMaH1DTZH FYqODssQkoQIAaBuVQvq9RugcGv6MGfV++VFzTIKvq2/T8yYcWyjN8o/gMeMhQ6s bYHKs5YP5CejI4q2ARMezNFgOCPPQEKTzSirRM6pwZF9Bm3t0vvNW239YZyWKPrs 0Jvs2g== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenhkchr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 12:29:45 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7976ded5c5so5444804a12.0 for ; Wed, 22 Apr 2026 05:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776860984; x=1777465784; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=; b=VwfcEZtKIaOB6gUT39wyeFmknTR+5RwlxUV8uvvC5GdPs7rLIG9XwVfnkXHnBjFK2o Iw9/SdGce2oqok0BtIPjXkNaBySTAdH1NM8xPefZmyuILQ9BV96KLLtkcjbYrlTU3vEH QnXEzp5DE9PP6+lu041ybhdTEyQguiz5EK2xeCBA/SBKWpwiDNc1yJaZ8iBTKi36Z1Y2 jZVm/bnOGz4WI/O9I2sqPhZFI/6kDl/b6unEi/8IAYegK0QbPQZPeZ1bvK5TqgrVlYUI eqgTp41asXmkbVvZxfNxp6JsWJfbMXLB9MOq7s9jMTCX04qS1h/DkJeVHK46m6e6tc8s CH8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776860984; x=1777465784; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/EUnaQmzyJXclg74EbLwevF4NYo7MxnDkmFbb66H9ZQ=; b=lGvv3TFZd6IXxegGFWBI5Na/28zMITJt8qV2zALeKSWPp76dCGWi8ZLJq74zDs2Stk xEG9Vd1uzToE1Le5pJQJqDgkby/DM3fHlXB19hysim9+Or9+zZTdwsthNlYq/hXcr0PQ oaoz2mXm7wESK/xZ1PA2Kq1czrfseIBKHGUag6WGi7i3s2jJ9arpo2TaChuFOMhplGNm Lr4SdK0XC63ZTkldXSyKIgqRbSD/slWAyKW2+892pRBPZW9NBl775VF6A3Aiwr9vmzVv LG0hxv6sbQPiWrWmV3xy6ElZWXhPrEmMqBZIBMzg3Sl5Qsuh9w1xDhtOdUj3JBlB7aLg dySQ== X-Forwarded-Encrypted: i=1; AFNElJ9I073Ccaaev9a7PYg6ojMxuv98uYiyX191gXrB3zjnqojla4V9XQHz/J26Sgp7s8yzRda7U4U1prNiaQM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn/mUcFSrnrh63Uopji2llwo1UE2+EwVLf1Vp9N2HSl6HKM93v sCcTQSlVGK/l8RWcQQ/Ws/dQxzYx3XhiOb5w5kloaBmlh659fEmpBZrm8cyAcasVYrkXyloN0md +XgBV6RZMusvsbxmgHTpy0nHZKczkj9F2VPGfNbCrdDVo25IBFOY1jVQwPOCMJvBHYfsygPq9Ad w= X-Gm-Gg: AeBDievR7RIFiXKXHdJvkBoeC0WaoRF1lBDReexROiil/vBvPnuYixsswVkO6y4cedS 61UxlKVB99OuLdAU6XS8SX32RmorRzxdofWfKGt4tjvOGRfJdkrxz478WUTmUnYy1Iis9M2NFxW MRQJ39yeAkfSJu3iLDSKdHOafgdbHfCQ6clNx9EZfvF4ZInQzugjxz43CTLkctHjs4jYWCtmFya rmvyVPbu8M4Ij0irXz1oueSezA3B4WO4Zbv3LMV5LdjBNFAr86v58LUkoBueRxGNflyuPcbdHqq QGYXrtKhU0DXmse1srkITzc+AIG69/pBm0/LgPsgiYdWa2IMFuFKz3EcqilIRFqx+izcV5mnjHn ayDcXfnRvVDNM0GFcGosVaE4MqHpFWjVDhdjQSCzPAjeDpE6b2Nbg6QoZ2pl8xXGrW/g= X-Received: by 2002:a05:6a20:2591:b0:39f:3ca8:a331 with SMTP id adf61e73a8af0-3a08d7372b4mr25458998637.16.1776860984154; Wed, 22 Apr 2026 05:29:44 -0700 (PDT) X-Received: by 2002:a05:6a20:2591:b0:39f:3ca8:a331 with SMTP id adf61e73a8af0-3a08d7372b4mr25458964637.16.1776860983653; Wed, 22 Apr 2026 05:29:43 -0700 (PDT) Received: from [10.217.219.207] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7976f9cabfsm14406916a12.9.2026.04.22.05.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 05:29:43 -0700 (PDT) Message-ID: <3aecc765-7576-4f2c-9588-534569936438@oss.qualcomm.com> Date: Wed, 22 Apr 2026 17:59:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] i2c: change return type to bool for i2c_check_functionality To: Thorsten Blum , Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260421161607.61314-3-thorsten.blum@linux.dev> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260421161607.61314-3-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: L9f3anXh3EzqKsvS2fJFnPQnM5s_Ti7T X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDEyMCBTYWx0ZWRfXy7gt/nm8KS5u DeslS2eiEonPQFmolnqYvgcXEifhhrhIyySEdqfE8YJKhVNBYbVgjG3e5h+Czh68atV8UL2Zg77 TGTMDAJqIP62/kirbCApuZ+Oi6MCauyU+GvYNRtuJwx8531TuZT99/4XXiioutMgTypyZopq5RA 18bMDFonixD7HQbh2/46iIcQ+3YOPLD2DBmGkedts9MrfPnq+akphR+A+4foB/9z2/mdU7E3RSk /pV+8+vXA3zl92Xy57z4WlwnL9hXusnrf1VWsNikQyEeCdr4Xd7m8ydMOcVgenfl9c66RCK5Wle xE0AaWU6CVEDjnwHIvHw+mCWP4kaRAiduRyiolXTSvq/NQtevNITp5bPHWfPB7nMT1/NneySMl/ wf8gOUfulBEGbs0gIQ8irdKEbTJBnn4RT62BfqblzLX2UGXRYaQFbeO3cZs1cwqZ8o98XwTYW8x 4+OlGBqEU3wl6SuH5NA== X-Authority-Analysis: v=2.4 cv=WKJPmHsR c=1 sm=1 tr=0 ts=69e8bf39 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=UNYCHEIbOCCRWFwfwnMA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: L9f3anXh3EzqKsvS2fJFnPQnM5s_Ti7T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-22_01,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220120 On 4/21/2026 9:46 PM, Thorsten Blum wrote: > i2c_check_functionality() returns a bool - change the return type from > int to bool and update the comment accordingly. > > Signed-off-by: Thorsten Blum > --- > include/linux/i2c.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/i2c.h b/include/linux/i2c.h > index 20fd41b51d5c..6737bcbc5d7a 100644 > --- a/include/linux/i2c.h > +++ b/include/linux/i2c.h > @@ -919,8 +919,8 @@ static inline u32 i2c_get_functionality(struct i2c_adapter *adap) > return adap->algo->functionality(adap); > } > > -/* Return 1 if adapter supports everything we need, 0 if not. */ > -static inline int i2c_check_functionality(struct i2c_adapter *adap, u32 func) > +/* Return true if adapter supports everything we need, false if not. */ > +static inline bool i2c_check_functionality(struct i2c_adapter *adap, u32 func) > { > return (func & i2c_get_functionality(adap)) == func; > } > Acked-by: Mukesh Kumar Savaliya