From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF8B38E124 for ; Mon, 16 Mar 2026 10:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656703; cv=none; b=RR09lp++qGU8iXDSmp3YzPA4vkvX8uE4XCc47x7pK8n3lhpribF5bJv0xV9nOmpU4rdxR/YVoegXczeH0vqhL/3h1nfAJ6p8Hvo4njVdSrnOsvHopz0aeKM2Rg+WcFuvXOTNRN4/74q/BHse14gqmvGbOtuuFSPETxpaunIOaBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656703; c=relaxed/simple; bh=g7i0+Pp9mjDM23vWtwKGrmc2BsZHLrC1Qpwe0Pg4HnA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JdC7G4pVePZK4pbEtWBthIwK2J+/fjDBjBA5cMgolJkegh6b8Wnuj5oVZxJxgc3PryS55Zi7TrMwzBVEimaDBLR7AjRRJf5YKJPAYyzY7/DMdi8N2tkPbj69Wkei3qEU4Rf+Ug1Zh0iBBifF8lKVa/m2HQ2zrlQe3MqwEPxhg74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JwuFiIoJ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JwuFiIoJ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso38727265e9.3 for ; Mon, 16 Mar 2026 03:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773656700; x=1774261500; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=76TTQfOSNM1rz7a9CKO2GjO22jbs8CcvWq2eCabFfvY=; b=JwuFiIoJJxGpULgpCQclsszbgrE+zMiEpg6IP3hqEL2AkRSWqDuttvEEtcerWb5fW0 ayJRehUybKL3TjT6tXKwoT1MJZp+uVN6FQw90Vj1zXbPmBOsywnP7cBmSOUgzFhFvvrj YSPVs7h4tU4m+Tyy7jw4QsiV14+9xgSzSuoURpkMyin/2a0VW+zLUbaS9XMsY8NEN4T3 77aDIHJCdpeTaiZDXHzMF9revugRYAfF4SSaWXhYv0Thx7urS4/keQ7rVX6H1O7mtG4M XSzd2jzrGeVRGmc/khhGRaDASXVvtX9PBnW/Di7IDAsofy4Ea8lnQd4TD+JfEzUV8fhp HhdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773656700; x=1774261500; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=76TTQfOSNM1rz7a9CKO2GjO22jbs8CcvWq2eCabFfvY=; b=q37GlWHucL+auzF5ddsRAlg+/FFAhwnHThXaAMW/ayrhKd/kU9RUKC0gWbFw/u/2HI 2SUJDN9NPWTd8m0vadzgpOvelS21aFmkv6/L8WKVxoSttcwcD9K/FC12t4rrQvKbu1I9 mU7QkZ2lKURcqzyjyMXKSll+kVNSjV/3k5P7lFcsEQrg8CCYS/cCGn5rs/sz7IMNtXvq iYI7lylepAgENDCS/tc5UZWYHPDzGfuGKKS+lCYgXmxE4/cXNn1jb42lZsH2ee8lc7v/ z8an5unjgTbqv47zrZwo69X5XqefWapZu8+XQGZuFP1YI8mEc2LdKtYbttLoB0keS0Ys kr8w== X-Forwarded-Encrypted: i=1; AJvYcCW43aWzjiQv350rAjBgaEzCdX/XoVXQiNcyN7sK//QMI0UzMInekQDZxg8F7eZ9vCmSwZAgE91hI4gAjcE=@vger.kernel.org X-Gm-Message-State: AOJu0YwIp0IJTCxvgWxoxW9FeDP+9NlapTcDiIKbmD1xyB14GalFvCWi FnbagXdpA61kY7yFJgXflmqldZ4BGY8efjkqasYEPjPWKIMchF3DEnN3nClqBwifqws= X-Gm-Gg: ATEYQzzuvzf467JfHOzAhK4n/HsEOa40GxWGjBMZOulK21eMRUXr7vNuLBOIqmDwaye DSg/xyidqG3XXWaMSV3hS9TmalkmzGmQqDjWmxi+d2ELdPF/RjG+XTH/lIiVd5eR9e60C01FZZq TzQyPVFC61rtLELtV18kGFN6kroX8dw9TwHYmsX+0nsEyhsRFFZkToHwv4MkPPodjJScwsjMgHf qq6pgOH/CxG/vsNIuVRsA0ze1kG2gwC5MFNiSNRGjOgcVFZWpnk3h6ycpzG+Qjkq+sT+1VCOTkr oMiAFgRWw0NHIKWvDqJ27oPphzxvbGar+rs4ZFWYYf03ZCxuGXWAl8MCE6gkx8if2bHMGFjRkFd ood3tYRrwM2kttc61kVzCZ3CTR+XR1mNf8qOoVIb3EbZqKJzKvVhFwWByia/WOSmtL7a9zpO4y4 YqeI3jDoy1juJXA6I3IVKeHRwds6xDp0A= X-Received: by 2002:a05:600c:4e4a:b0:485:4135:5c92 with SMTP id 5b1f17b1804b1-4855649360amr208565725e9.0.1773656699914; Mon, 16 Mar 2026 03:24:59 -0700 (PDT) Received: from [192.168.0.34] ([82.76.24.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557777105sm149727875e9.4.2026.03.16.03.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:24:59 -0700 (PDT) Message-ID: <3af521bd-e03b-4e8c-a972-6b0b1c54e2d9@linaro.org> Date: Mon, 16 Mar 2026 12:24:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 20/25] printk: Register information into meminspect To: John Ogness , Mukesh Ojha , Jonathan Corbet , Shuah Khan , Arnd Bergmann , Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Anna-Maria Behnsen , Frederic Weisbecker , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Brendan Jackman , Johannes Weiner , Zi Yan , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Petr Mladek , Sergey Senozhatsky , Bjorn Andersson , Mathieu Poirier , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org References: <20260311-minidump-v2-v2-0-f91cedc6f99e@oss.qualcomm.com> <20260311-minidump-v2-v2-20-f91cedc6f99e@oss.qualcomm.com> <87pl54f70l.fsf@jogness.linutronix.de> From: Eugen Hristev Content-Language: en-US In-Reply-To: <87pl54f70l.fsf@jogness.linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/16/26 11:39, John Ogness wrote: > On 2026-03-11, Mukesh Ojha wrote: >> Annotate vital static, dynamic information into meminspect for debugging >> >> Static: >> - prb_descs >> - prb_infos >> - prb >> - prb_data >> - printk_rb_static >> - printk_rb_dynamic > > FYI: vmcore also exports the symbol "clear_seq". It is not required if > you are interested in reading _everything_ in the buffer. But it may be > interesting if you want to mirror vmcore tool features. Thank you for your review and suggestion. One of the key points of meminspect is to be easy to use by the kernel developer. E.g. to be easy to add another symbol, like `clear_seq` for a particular use case. So, someone wanting to make use of it, can easily add it. The purpose of the initial submission would be to have a basic use case working, and show it as an example for everyone. If you would like to detail about the features you mention, it could be interesting to try them and see if it would work with a meminspect dump. Eugen > >> Dynamic: >> - new_descs >> - new_infos >> - new_log_buf >> >> meminspect uses a different API to annotate variables for inspection, >> and information about these variables is stored in the inspection table. >> >> Reviewed-by: Petr Mladek >> Co-developed-by: Eugen Hristev >> Signed-off-by: Eugen Hristev >> Signed-off-by: Mukesh Ojha > > Reviewed-by: John Ogness