mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: 张烨 <ye.zhang@rock-chips.com>
Cc: "tao.huang" <tao.huang@rock-chips.com>, heiko <heiko@sntech.de>,
	"rui.zhang" <rui.zhang@intel.com>,
	"finley.xiao" <finley.xiao@rock-chips.com>,
	linux-rockchip <linux-rockchip@lists.infradead.org>,
	linux-pm <linux-pm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"daniel.lezcano" <daniel.lezcano@linaro.org>,
	rafael <rafael@kernel.org>
Subject: Re: [PATCH v1] thermal: devfreq_cooling: Fix perf state when calculate dfc res_util
Date: Thu, 21 Mar 2024 08:44:46 +0000	[thread overview]
Message-ID: <3afdba54-2a85-46a6-a0f1-a61b4d0d8930@arm.com> (raw)
In-Reply-To: <ANIAEAAdHuSn9iPJ6HkLiaq2.3.1711010230402.Hmail.ye.zhang@rock-chips.com>



On 3/21/24 08:37, 张烨 wrote:
> 
> Hi Lukasz,
> 
> Regarding your question about how I triggered the issue andifI have a 
> driver that provides the get_real_power() callback:
> 
> I encountered thisissue whilecalculating the GPU power consumption onthe 
> Rockchip RK3399 platform. The GPU model isMali T860, which isan ARM 
> Midgard GPU. The driver version isr18p0-01rel0, andit provides the 
> get_real_power() callback.Best regards, Ye Zhang

Yes that would trigger the issue. Thank you Ye for
sharing that.

BTW, I also use RK3399 for my mainline kernel development.
I use the Rock Pi 4SE with the mainline GPU driver
'panfrost'. That GPU driver doesn't support the get_real_power()
callback, but maybe it would be worth to add it...

Please send the v2 and I will add my reviewed-by tag for it.

Regards,
Lukasz


      parent reply	other threads:[~2024-03-21  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240320075704.1924897-1-ye.zhang@rock-chips.com>
2024-03-20 14:15 ` Lukasz Luba
     [not found]   ` <ANIAEAAdHuSn9iPJ6HkLiaq2.3.1711010230402.Hmail.ye.zhang@rock-chips.com>
2024-03-21  8:44     ` Lukasz Luba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3afdba54-2a85-46a6-a0f1-a61b4d0d8930@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=tao.huang@rock-chips.com \
    --cc=ye.zhang@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®