From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751877AbdIXHHP (ORCPT <rfc822;w@1wt.eu>);
        Sun, 24 Sep 2017 03:07:15 -0400
Received: from mout.web.de ([212.227.15.3]:50685 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750947AbdIXHHN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 24 Sep 2017 03:07:13 -0400
Subject: Re: ALSA: bebob: Use common error handling code in
 snd_bebob_stream_start_duplex()
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        alsa-devel@alsa-project.org
Cc: Clemens Ladisch <clemens@ladisch.de>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <85f95150-9cec-7a53-7692-837ba543e1ec@users.sourceforge.net>
 <541f0f9f-fc87-f65b-bbd8-fec5d45d5d2e@users.sourceforge.net>
 <a1dee732-f5c4-5b35-9f82-553fc8ce430d@sakamocchi.jp>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <3afecbef-b7ac-a4e8-f439-a351916f05e5@users.sourceforge.net>
Date: Sun, 24 Sep 2017 09:06:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <a1dee732-f5c4-5b35-9f82-553fc8ce430d@sakamocchi.jp>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:ifrwlXNovNut2VjpO/biAJWKxkQeiyTqvuzXywTrxYN649XWoLo
 JXzhsAxk6ofJ3oVcPbniJoNxtbmNk99ubXW1OsGkjQoar0e1DyeeGSeZuXGbvhuIUAJk3kt
 fn0YRyfoZyPrazA9TvA00AFDRZo8zdizNKCkLUy9m2MkorTMpJQg0qFWS5VtsdevGU2YICu
 7xMkH8xhACqIPgM+fhGCg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:2QBNccUQ2h8=:i4YLo8Y+yKaeInUo4pXfPL
 U4Rh9kSGzvUrwehbm6bIOqHs4BLR/vQbORR9F2dkjHF4aWFbjZKYAOOEMT8JV0j/jXwoVw/i6
 mYlLtKt/+gl8XJik/js5oVp72Jc8GcuMSuWMwfBGMQPDMbAhC3nY7dKkzzZvoj2cg6mYrqWBO
 X7PMWZcrm7WFv+cFoo+WlQ9oQMXiCnA1JAGPrSf1Qgd6xqrQ869e4v7EchrZR9mfONNwW//Mr
 F9MNU1tT7d7eraFYlbyA8KM4yr9iuBF6Orz8CmWRHG9CVGCATD65s23nS7/9NW35LeZvu3W6/
 i128TBIw1DRJ4E7pp62gbl1o54aC6XXWK9r1dIN6sYrE4SrvACbrVOjgJxooAHuGKX5nPjMaC
 GgklRL65Y7MkfnaU+W6utdOdvrlaBgq6DBXYJhXFVMJCQ5KTfENeQkL8gZ0QRRcycmRplw2OY
 M3xWRHKQLVPEg+XR1LWuXQUqhO4LzzIj0nnpQjJo1veHAfuS8mToL1dvBB6+4mktIn0Z3Ud4Q
 Rh5yCvqTBVNBH/U7TiouJpOLjrcJP3giHVrftxVY5bWE94tYG3OLGa704bVvYp0jsmu38sCYW
 0Sam9Fx2DCaVvoopdO76fy9z1qxXCSyAmygLoikpWFoOzrlS3nc+bjS58LJvW1gmaVRjAB8FJ
 6FCsfhcGQcSmRPmB1GdJemraaagzVgZJSY+tbJsRsWIksYDl0SxzB6+nETobg47d+FAVHORTp
 KusH8RR029RIrvjJNRJ4QiZdTU1YykoJI16wfetj8LxoyAOrvP/nxip3hlVtWCYztfRoxCw6L
 MpAhugZh6w8YQucY/qHDycCcdeMyeNL8rc65XByn+GbW1B8TmQ=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 668     if (!amdtp_stream_wait_callback(&bebob->tx_stream,
> 669                                     CALLBACK_TIMEOUT)) {
> 670         amdtp_stream_stop(&bebob->tx_stream);
> 671         amdtp_stream_stop(&bebob->rx_stream);
> 672         break_both_connections(bebob);
> 673         err = -ETIMEDOUT;
> 674     }
> 675 }
> 
> I think it better to apply your solution too in the above to keep code consistency.

How do you think about to adjust this function implementation after the other two
update steps from the patch series would be integrated?


> For the other patches, I can find no merit to apply except for reduction
> of the number of characters included in the file.

Would you like to refer to any specific update suggestions for further clarification?

Regards,
Markus