From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A29182F659F for ; Thu, 19 Mar 2026 02:37:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773887850; cv=none; b=oUHBkfd5vXfsl+JGXNK5g84i5ussHzPGVW21GQknWznarqS9TmX4/sHJEnaliNZJolCGXpgR+HdvlO4axQEASCYS7wCFJ6spYe5tttFayGHl/dIHLHWIhxHs8loY8YNg8RryFOxF28lFsuSH9IXjcR5IQbod9GNVPMszqhyhwC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773887850; c=relaxed/simple; bh=W0GJsY+q/H7akp/9jA2KKaL0OvpGyts+Wwbhbsz9dMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ghj2Eq9cVhMTNHCUYZb/MlM6sr7E+fbsOG5VSDh+bqEXSNpmJdioELVsMp66mEk0xdzy9v5c4znsxu9udylcNUjizglMMtRVPX3fP67mc3U2leO18tsHyfskt46cHKagMfHVjIBa6nQPIrlA04dptV0FkRA+j7+UbWWNlfhUi80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ql5dv7sz; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ql5dv7sz" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8297310ce0aso86838b3a.2 for ; Wed, 18 Mar 2026 19:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773887849; x=1774492649; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=41gqP9Xz29ZxguAd8x+A60goY3aYjFU2+iS4d14MjxY=; b=Ql5dv7szjecVa2vSAgLTVazIVLkqvjtr0iK/y34fZzEZtAXMweRcYdvfEYayL8AJIt pB81wA0Nh8rgiRrBriGHfi9ty4b8aWnKyFbrGUWthpSoCEF+aYAXZIIJs4iXeiSkd2p5 6ksjoBZEUMhodxX1274oq6oe7ppU7MfQeaLSgNiLt3cxwHLx3J8jUo27uqZhNbRPeewP 6MMjLkdR8HjxWpX5w+EJr4+JBdfpUFitvhNOslT7rjqvkrq2Jcs4j3/9+y46/8jcmkJG 5YN+RY7W9bZ2x34XFmzZZ55In1PArqi4ALCp/wfS0cCpGR07BJ+Vqn3ad4SK55ys9ARs guyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773887849; x=1774492649; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=41gqP9Xz29ZxguAd8x+A60goY3aYjFU2+iS4d14MjxY=; b=JpmMZkR6BNkCVtarEQ04A2cK6uVkw8zJ4ePG3EB/0PujTXSg1n8DW93H7ssAhSzHR+ 96b0n0SBLhUyZqbNtQte6o3wpSvfPJsbREwVKwN3qW9BviB8h4yM0GyTTBJYepYxlygw 113F62im/C4lOo+1aScRAmozDuY1GriSRk7FOx+Y6k0JGLDhpGzyuC/vOtFs3xzPy8wV +XuKNg2wjaRtL3qD4cTOVMnAh0b/A8cDKtpZFX8KY1PpPl6rIiMhwPoVLRg/3B3B9qf9 QsJwwYHS+li02fLDPftp2KvRqmf6V6CVfvp1J8yhol84xi3WYdTBv8tlnr6+XQaLKy8q 0M1g== X-Forwarded-Encrypted: i=1; AJvYcCW6UfDw+TUkAxZmHuqbYC1k28fZT9cfuIgJl9eVoi+7p7VO/Vh4MgumQMLa2MOzLx5UOjYeey+h5is/2Qo=@vger.kernel.org X-Gm-Message-State: AOJu0YzCD4bv+/oq2kzKqIH74pdLTglNVDO9/Md1cSH95ceFzp9H0rfK TDOgvHX0DM93Q9/puPA80zY4pySau89Fm5g0yQd/jzEpBKtHxtWAFenB X-Gm-Gg: ATEYQzxru6u8QLT1hKy6bCF4kAcqjhzDsiS6nAWzoJza9P3OTLtmP0R4pInusniWPUE 8AjXLF31ia4lJbVWbd/4XgJV0O448pSbreBUeldvrfsPwalhQYiBHKeu6ZveMxELrm5WCZHaXbu IIHxIyq+ed9OpSihpuXYYdLPW/AQP8taLS1xowMIUljN4lnOeKx0P9+Q2B3M+POiQLeHDAdGtIO EFboJBMjld1RYMwH4ieXlRoLd0SKKd9H07fAVoilJVV4bPAFuV+PX+AiZeAWLeufmtbsIY+pCbc S/bkuh0dSIonH8ozkx1FWX2c7EPdEmc3nTiXg9mkK3kXHXj1idwd+kra6OivUn43SNVsdhKYlXh 6XghviDYboIahkq+GDpyzuc1yAlohKhwdOJAYOd+urokFUlFVvPNt0OctM00OghLbfVXOwfm4O4 vzGJI5W1QtjAtLt8t99k+HZ1PuWGTTlKpQqaAQ6Dcfkn85ty3kCanl9tq432cTLSIVL3Q6dZLIF b/bivZSvIeDwIZOrzgMEKjC8sYr8hkOjADhL6e6hB10aDRghXd1/JcXc4Yg3f6zWBo5OQrq9Wfl iw== X-Received: by 2002:a05:6a00:6c94:b0:829:809e:8977 with SMTP id d2e1a72fcca58-82a6af3c066mr4829584b3a.49.1773887848851; Wed, 18 Mar 2026 19:37:28 -0700 (PDT) Received: from ?IPV6:2601:1c0:5780:9200:9662:a5ea:aac3:575e? ([2601:1c0:5780:9200:9662:a5ea:aac3:575e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6b541cc7sm4196785b3a.6.2026.03.18.19.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 19:37:28 -0700 (PDT) Message-ID: <3b018af1-15d7-4bf4-b567-2692656302e0@gmail.com> Date: Wed, 18 Mar 2026 19:37:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers To: Doug Anderson Cc: sumit.semwal@linaro.org, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260305044921.10942-1-chintanlike@gmail.com> Content-Language: en-US From: Chintan Patel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/13/26 08:46, Doug Anderson wrote: > Hi, > > On Wed, Mar 4, 2026 at 8:49 PM Chintan Patel wrote: >> >> Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and >> mipi_dsi_msleep(). >> >> Switch DCS command sequences to the multi context API and >> accumulate errors via struct mipi_dsi_multi_context. Replace >> open-coded error handling with the multi helpers and convert >> nt36672a_send_cmds() and power sequencing accordingly. >> >> This patch is intended to functionally be a no-op, though there is one >> slight change. Previously a failure in regulator_bulk_disable() would >> have caused nt36672a_panel_unprepare() to return an error. Now it >> won't. No other errors in nt36672a_panel_unprepare() were propagated, >> so this makes things consistent. >> >> Signed-off-by: Chintan Patel >> --- >> Changes in v3: >> - Keep local ret variable in nt36672a_panel_power_off() to preserve error code in logging. >> - Change mipi_dsi_msleep() back to regular msleep(60) in power-down sequence to preserve behavior. >> - Reset dsi_ctx.accum_err before set_display_off_multi() and before power-down to preserve original error-tolerant shutdown behavior. >> >> Changes in v2: >> - Address alignment feedback from Doug. >> - Restore original power-down ordering. >> - Drop return value from nt36672a_panel_power_off(). >> - Consolidate error handling around dsi_ctx.accum_err. >> >> .../gpu/drm/panel/panel-novatek-nt36672a.c | 94 ++++++------------- >> 1 file changed, 30 insertions(+), 64 deletions(-) > > Pushed to drm-misc-next: > > [1/1] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers > commit: bc4cb68a02f1a445aa65d8054bd69ba4ba3f5767 Thank you Doug!