From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761377AbdEVTYV (ORCPT ); Mon, 22 May 2017 15:24:21 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42176 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757576AbdEVTYR (ORCPT ); Mon, 22 May 2017 15:24:17 -0400 Subject: Re: [PATCH 1/3] RDS: IB: Delete an error message for a failed memory allocation in rds_ib_add_one() To: SF Markus Elfring , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, "David S. Miller" , Sowmini Varadhan Cc: LKML , kernel-janitors@vger.kernel.org References: <44b46c51-3665-5f14-dd3b-6e6f230258a7@users.sourceforge.net> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <3b02a3d1-17c9-3d8b-7edb-db640c0ea017@oracle.com> Date: Mon, 22 May 2017 12:24:38 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/22/2017 7:11 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 15:34:28 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > net/rds/ib.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/net/rds/ib.c b/net/rds/ib.c > index 7a64c8db81ab..c5514d058171 100644 > --- a/net/rds/ib.c > +++ b/net/rds/ib.c > @@ -166,8 +166,5 @@ static void rds_ib_add_one(struct ib_device *device) > - if (!rds_ibdev->vector_load) { > - pr_err("RDS/IB: %s failed to allocate vector memory\n", > - __func__); > + if (!rds_ibdev->vector_load) > goto put_dev; > - } > Well the ENOMEM is not carried here so the message was usefu but its not critical so its fine to clean that up. Acked-by: Santosh Shilimkar