From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701AbdHCN5z (ORCPT ); Thu, 3 Aug 2017 09:57:55 -0400 Received: from m15-37.126.com ([220.181.15.37]:57895 "EHLO m15-37.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbdHCN5y (ORCPT ); Thu, 3 Aug 2017 09:57:54 -0400 X-Originating-IP: [153.3.28.15] Date: Thu, 3 Aug 2017 21:57:38 +0800 (CST) From: sohu0106 To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Cc: linux-s390@vger.kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: drivers/s390/char/keyboard.c NULL pointer reference X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 126com Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <3b10f99f.aa01.15da8632dec.Coremail.sohu0106@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: JcqowEAJ60DSK4NZx4FmAQ--.13669W X-CM-SenderInfo: pvrk3iqrqwqiyswou0bp/1tbi3AApHlag3kDj1AABs1 X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v73Dw1DO018517 Local users able to send the NULL arg argument to kbd_ioctl(), which could cause kernel crash diff --git a/keyboard.c  b/keyboard.c index ba0e4f9..3ec16b1 100644 --- a/keyboard.c +++ b/keyboard.c @@ -456,6 +456,8 @@ int kbd_ioctl(struct kbd_data *kbd, unsigned int cmd, unsigned long arg)         int perm;           argp = (void __user *)arg; +       if( !argp ) +               return -EFAULT;           /*          * To have permissions to do most of the vt ioctls, we either have https://bugzilla.kernel.org/show_bug.cgi?id=196575