From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: outreachy@lists.linux.dev
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Deepak R Varma <drv@mailo.com>
Subject: [PATCH 4/5] staging: rtl8192e: avoid camel-case <dot11RSNAStatsCCMPReplays>
Date: Sat, 1 Apr 2023 23:58:43 +0500 [thread overview]
Message-ID: <3b179b52e00b398a22cd491e8fc61d4e0edd2a3d.1680375200.git.kamrankhadijadj@gmail.com> (raw)
In-Reply-To: <cover.1680375200.git.kamrankhadijadj@gmail.com>
Linux kernel coding-style suggests to not use mixed-case names. Fix
checkpatch issue by changing the variable name from camel-case to
lower-case.
Suggested-by: Deepak R Varma <drv@mailo.com>
Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index e8a3bc94efdc..1783a2eaae66 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -36,7 +36,7 @@ struct rtllib_ccmp_data {
/* .11 RSNA stats for CCMP */
u32 ccmp_format_errors;
- u32 dot11RSNAStatsCCMPReplays;
+ u32 ccmp_replays;
u32 dot11RSNAStatsCCMPDecryptErrors;
int key_idx;
@@ -264,7 +264,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
pn[5] = pos[0];
pos += 8;
if (memcmp(pn, key->rx_pn, CCMP_PN_LEN) <= 0) {
- key->dot11RSNAStatsCCMPReplays++;
+ key->ccmp_replays++;
return -4;
}
if (!tcb_desc->bHwSec) {
@@ -376,7 +376,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv)
ccmp->key_idx, ccmp->key_set,
ccmp->tx_pn, ccmp->rx_pn,
ccmp->ccmp_format_errors,
- ccmp->dot11RSNAStatsCCMPReplays,
+ ccmp->ccmp_replays,
ccmp->dot11RSNAStatsCCMPDecryptErrors);
}
--
2.34.1
next prev parent reply other threads:[~2023-04-01 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-01 18:58 [PATCH 0/5] staging: rtl8192e: fix checkpatch issues in rtllib_crypt_ccmp.c Khadija Kamran
2023-04-01 18:58 ` [PATCH 1/5] staging: rtl8192e: remove extra blank lines " Khadija Kamran
2023-04-01 18:58 ` [PATCH 2/5] staging: rtl8192e: fix alignment to match open parenthesis Khadija Kamran
2023-04-01 18:58 ` [PATCH 3/5] staging: rtl8192e: avoid camel-case <dot11RSNAStatsCCMPFormatErrors> Khadija Kamran
2023-04-01 21:20 ` Philipp Hortmann
2023-04-01 18:58 ` Khadija Kamran [this message]
2023-04-01 18:58 ` [PATCH 5/5] staging: rtl8192e: avoid camel-case <dot11RSNAStatsCCMPDecryptErrors> Khadija Kamran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b179b52e00b398a22cd491e8fc61d4e0edd2a3d.1680375200.git.kamrankhadijadj@gmail.com \
--to=kamrankhadijadj@gmail.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®