From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B25BC10F25 for ; Mon, 9 Mar 2020 20:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44D462253D for ; Mon, 9 Mar 2020 20:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="NBn4ng5r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgCIURr (ORCPT ); Mon, 9 Mar 2020 16:17:47 -0400 Received: from ssl.serverraum.org ([176.9.125.105]:43297 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbgCIURq (ORCPT ); Mon, 9 Mar 2020 16:17:46 -0400 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2C33223EB9; Mon, 9 Mar 2020 21:17:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1583785062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z4lMfHVJtv1/7tVOgY+2NWcDkuP/vkxxc0vG3i3iujk=; b=NBn4ng5rW9oF8jRIKbzD31HivmfpG9BA77wMSo0PPFk6bAfzl3PR72WqOaR7fjDpHdA3sE 77UMpTWS/9sN2Naf6SKSh6yNpPZjkpJOcwGJxbP1PO5bDjUajSZyDnmbRtpReyBIMfb2VP 1JOHIrABm2aB7IU06lyO+tfP9+TnPVo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 Mar 2020 21:17:42 +0100 From: Michael Walle To: Vladimir Oltean Cc: Mark Brown , linux-spi@vger.kernel.org, lkml , Shawn Guo , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Esben Haabendal , angelo@sysam.it, andrew.smirnov@gmail.com, "Gustavo A. R. Silva" , Wei Chen , Mohamed Hosny , peng.ma@nxp.com Subject: Re: [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers In-Reply-To: References: <20200309145624.10026-1-olteanv@gmail.com> <20200309145624.10026-6-olteanv@gmail.com> <83af52172a3cabd662de1ed9574e4247@walle.cc> Message-ID: <3b25c8b5fc9c433715e1fa99bc515822@walle.cc> X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: + X-Rspamd-Server: web X-Rspamd-Queue-Id: 2C33223EB9 X-Spamd-Result: default: False [1.40 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[dt]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; NEURAL_HAM(-0.00)[-0.385]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[kernel.org,vger.kernel.org,arm.com,deif.com,sysam.it,gmail.com,embeddedor.com,nvidia.com,nxp.com]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-03-09 20:59, schrieb Vladimir Oltean: > On Mon, 9 Mar 2020 at 21:06, Michael Walle wrote: >> >> Am 2020-03-09 15:56, schrieb Vladimir Oltean: >> > From: Vladimir Oltean >> > >> > LS1028A has a functional connection to the eDMA module. Even if the >> > spi-fsl-dspi.c driver is not using DMA for LS1028A now, define the >> > slots >> > in the DMAMUX for connecting the eDMA channels to the 3 DSPI >> > controllers. >> > >> > Signed-off-by: Vladimir Oltean >> > --- >> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> > index 515e0a1b934f..18155273a46e 100644 >> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi >> > @@ -298,6 +298,8 @@ >> > interrupts = ; >> > clock-names = "dspi"; >> > clocks = <&clockgen 4 1>; >> > + dmas = <&edma0 0 62>, <&edma0 0 60>; >> > + dma-names = "tx", "rx"; >> >> minor nit. Other nodes specified the dma channels as >> >> dma-names = "tx", "rx"; >> dmas = <&edma0 0 62>, >> <&edma0 0 60>; >> >> -michael >> > > Does it matter? No, therefore "minor nit". Its just formatted other then everything else in the file. -michael