From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EE171B7F4 for ; Thu, 7 Aug 2025 08:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754554994; cv=none; b=RDbioREQfIyJzNRB9jRJkRvCKxrF77ePURT9iHlxF1Clnu2rotxbm+Vlfdx71iSgwq4Y3fweJX1/mHWhSs542TAkJOcWbRSc42LaYGELCBeouEv5Zwt0UGYWaDtv0hiRxR7Ge+RI+9FDcP6ZXOgZv0YrGqN9LWQT0NyJCP1NpCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754554994; c=relaxed/simple; bh=QEqg73s6sFYnqMqGBE1SH2IlzCEUFgrHzIxne7HMXSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Aa1zbiPieU+mnFRi0PUA+oW2m6Lz6frgC+YYiSTeIzFIKyei12g4TTlnNMWu2RFh0/yfJjE1OsqyT5QM1NHRRfyaIeJVCeK412o3P4bCO93GRtJZ+fh2U4/NGDb6ZT0Q4ufyuLMU8cJcyP/li+Sk4PgkaKshQOo1x6SnN3r+32s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=SNy/cDep; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ChiITLvC; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=SNy/cDep; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ChiITLvC; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SNy/cDep"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ChiITLvC"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SNy/cDep"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ChiITLvC" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B46EB1F7F4; Thu, 7 Aug 2025 08:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1754554989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGEAN017bliOyl2SdA5tKF8ug9wKFUQ4OjKLerQ0lic=; b=SNy/cDepnjs8OmfRS4x9JUz+KxkAyY81771ANu+iQC/tK8fx/jaJkpneLBgUvqyxxyl/wL gWMlUGAqvYFv8RuyoUUFnpq3vZfA3BNTna8PZ0yXZjDf9UICBSLXWN859cKuvQilrlWsEW 6dKaUe/LAKoJyui2+p544rqciT/WuHA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1754554989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGEAN017bliOyl2SdA5tKF8ug9wKFUQ4OjKLerQ0lic=; b=ChiITLvCoN9YdHUeqa6ZiodBVXelh6pGawj/WmENOPW4R/UMevizIcnwVLOx1QYy9p76uy PQf6d/fi/WeYjDBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1754554989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGEAN017bliOyl2SdA5tKF8ug9wKFUQ4OjKLerQ0lic=; b=SNy/cDepnjs8OmfRS4x9JUz+KxkAyY81771ANu+iQC/tK8fx/jaJkpneLBgUvqyxxyl/wL gWMlUGAqvYFv8RuyoUUFnpq3vZfA3BNTna8PZ0yXZjDf9UICBSLXWN859cKuvQilrlWsEW 6dKaUe/LAKoJyui2+p544rqciT/WuHA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1754554989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGEAN017bliOyl2SdA5tKF8ug9wKFUQ4OjKLerQ0lic=; b=ChiITLvCoN9YdHUeqa6ZiodBVXelh6pGawj/WmENOPW4R/UMevizIcnwVLOx1QYy9p76uy PQf6d/fi/WeYjDBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4B586136DC; Thu, 7 Aug 2025 08:23:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GXPBEG1ilGgBKAAAD6G6ig (envelope-from ); Thu, 07 Aug 2025 08:23:09 +0000 Message-ID: <3b2765ff-4a7d-4bf7-b390-b392b695c675@suse.de> Date: Thu, 7 Aug 2025 10:23:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmet: exit debugfs after discovery subsystem exits To: Mohamed Khalfella , Yi Zhang , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch Cc: Shinichiro Kawasaki , Hannes Reinecke , Daniel Wagner , Maurizio Lombardi , Jens Axboe , Randy Jennings , linux-nvme@lists.infradead.org, linux-block , linux-kernel@vger.kernel.org References: <20250807053507.2794335-1-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250807053507.2794335-1-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo,purestorage.com:email] X-Spam-Flag: NO X-Spam-Score: -4.30 On 8/7/25 07:35, Mohamed Khalfella wrote: > Commit 528589947c180 ("nvmet: initialize discovery subsys after debugfs > is initialized") changed nvmet_init() to initialize nvme discovery after > "nvmet" debugfs directory is initialized. The change broke nvmet_exit() > because discovery subsystem now depends on debugfs. Debugfs should be > destroyed after discovery subsystem. Fix nvmet_exit() to do that. > > Reported-by: Yi Zhang > Closes: https://lore.kernel.org/all/CAHj4cs96AfFQpyDKF_MdfJsnOEo=2V7dQgqjFv+k3t7H-=yGhA@mail.gmail.com/ > Fixes: 528589947c180 ("nvmet: initialize discovery subsys after debugfs is initialized") > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/target/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c > index 83f3d2f8ef2d0..0dd7bd99afa32 100644 > --- a/drivers/nvme/target/core.c > +++ b/drivers/nvme/target/core.c > @@ -1992,8 +1992,8 @@ static int __init nvmet_init(void) > static void __exit nvmet_exit(void) > { > nvmet_exit_configfs(); > - nvmet_exit_debugfs(); > nvmet_exit_discovery(); > + nvmet_exit_debugfs(); > ida_destroy(&cntlid_ida); > destroy_workqueue(nvmet_wq); > destroy_workqueue(buffered_io_wq); Hehe. I knew this would've been the case once I've seen the latest blktest failure. Thanks for fixing it. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich