From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752140AbdEVHFN (ORCPT ); Mon, 22 May 2017 03:05:13 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:33812 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbdEVHFK (ORCPT ); Mon, 22 May 2017 03:05:10 -0400 Subject: Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image To: Bharat Bhushan , AKASHI Takahiro , Dave Young , "bhe@redhat.com" , "vgoyal@redhat.com" , "corbet@lwn.net" , "kexec@lists.infradead.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <1495085600-2645-1-git-send-email-Bharat.Bhushan@nxp.com> <20170518055914.GC4059@dhcp-128-65.nay.redhat.com> <20170519034514.GA4283@fireball> <2ed84f9f-76c8-62eb-36b5-e97568ba3a2e@redhat.com> From: Pratyush Anand Message-ID: <3b29d230-7295-4e04-5d07-b14817ccb954@redhat.com> Date: Mon, 22 May 2017 12:35:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 22 May 2017 12:19 PM, Bharat Bhushan wrote: >> On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote: >>>>> +to load dump-capture kernel. >>>>> + >>>>> + kexec -p \ >>>>> + --initrd= \ >>>>> + --append="root= " >>>> For uncompressed Image, dtb is not necessary? >>> Just for clarification, dtb is optional for both vmlinux and Image on >>> arm64. (This means you can specify it if you want.) But this is also >>> true for initrd and append(command line) to some extent. >> >> Yes, I agree. > > Should I mention "-dtb" also for "Image"? No,I think it is fine. This documentation is representing a typical use case and so above changes is OK for me. I think,your v2 is fine. ~Pratyush > > Also do we need to mention that it is optional somewhere in this document? I do not see "optional" is mentioned for other parameters and architecture. > > Does this looks ok: > > " -dtb= \" > > Thanks > -Bharat > >>> >>> More precisely, whether these parameters are optional or not will >>> depend on architectures, not formats, I believe. >> >> May be not architecture, rather a distro environment. >> >> For example, we should be able to work without --initrd for any arch if kernel >> has been compiled by configuring CONFG_INITRAMFS_SOURCE. >> >> ~Pratyush >