From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52A8C43603 for ; Wed, 18 Dec 2019 11:57:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8746D2072B for ; Wed, 18 Dec 2019 11:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576670223; bh=KxYzOjEs4MphiLa5CYSnhviMCbWOKIK+kYfoqF64IOE=; h=To:Subject:Date:From:Cc:In-Reply-To:References:List-ID:From; b=eTgKroqYEilv00hPicK1/5JkOiWGqHK2KV84F3UFnYu9HRrVSvXUwfD0T9uaxzw+B Xnp2jkMInIkdyycXzab+KmyTkpdSSQeDNEElwWXaRKT54UddgFspAQyFA3lDkjgYoa Q5PiJbAiUBNITrudswHXKhfEtwZIyiPyH7NBi1m8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbfLRL5C (ORCPT ); Wed, 18 Dec 2019 06:57:02 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:47285 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfLRL5C (ORCPT ); Wed, 18 Dec 2019 06:57:02 -0500 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1ihXwp-0007VE-C7; Wed, 18 Dec 2019 12:56:59 +0100 To: Suzuki Kuruppassery Poulose Subject: Re: [PATCH v2 7/7] arm64: nofpsmid: Handle =?UTF-8?Q?TIF=5FFOREIG?= =?UTF-8?Q?N=5FFPSTATE=20flag=20cleanly?= X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 18 Dec 2019 11:56:58 +0000 From: Marc Zyngier Cc: , , , , , , , , Marc Zyngier In-Reply-To: <9e491901-b589-b486-1cad-1bd92a35da95@arm.com> References: <20191217183402.2259904-1-suzuki.poulose@arm.com> <20191217183402.2259904-8-suzuki.poulose@arm.com> <94c0bdd9f26c3262ff8a885d13a64d22@www.loen.fr> <9e491901-b589-b486-1cad-1bd92a35da95@arm.com> Message-ID: <3b30d44c34bc265ce4122396077a1670@www.loen.fr> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, mark.rutland@arm.com, dave.martin@arm.com, catalin.marinas@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, marc.zyngier@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-18 11:42, Suzuki Kuruppassery Poulose wrote: > Hi Marc, > > On 17/12/2019 19:05, Marc Zyngier wrote: >> Hi Suzuki, >> On 2019-12-17 18:34, Suzuki K Poulose wrote: >>> We detect the absence of FP/SIMD after an incapable CPU is brought >>> up, >>> and by then we have kernel threads running already with >>> TIF_FOREIGN_FPSTATE set >>> which could be set for early userspace applications (e.g, modprobe >>> triggered >>> from initramfs) and init. This could cause the applications to loop >>> forever in >>> do_nofity_resume() as we never clear the TIF flag, once we now know >>> that >>> we don't support FP. >>> >>> Fix this by making sure that we clear the TIF_FOREIGN_FPSTATE flag >>> for tasks which may have them set, as we would have done in the >>> normal >>> case, but avoiding touching the hardware state (since we don't >>> support any). >>> >>> Also to make sure we handle the cases seemlessly we categorise the >>> helper functions to two : >>>  1) Helpers for common core code, which calls into take appropriate >>>     actions without knowing the current FPSIMD state of the >>> CPU/task. >>> >>>     e.g fpsimd_restore_current_state(), fpsimd_flush_task_state(), >>>         fpsimd_save_and_flush_cpu_state(). >>> >>>     We bail out early for these functions, taking any appropriate >>> actions >>>     (e.g, clearing the TIF flag) where necessary to hide the >>> handling >>>     from core code. >>> >>>  2) Helpers used when the presence of FP/SIMD is apparent. >>>     i.e, save/restore the FP/SIMD register state, modify the >>> CPU/task >>>     FP/SIMD state. >>>     e.g, >>> >>>     fpsimd_save(), task_fpsimd_load() - save/restore task FP/SIMD >>> registers >>> >>>     fpsimd_bind_task_to_cpu()  \ >>>                                 - Update the "state" metadata for >>> CPU/task. >>>     fpsimd_bind_state_to_cpu() / >>> >>>     fpsimd_update_current_state() - Update the fp/simd state for >>> the current >>>                                     task from memory. >>> >>>     These must not be called in the absence of FP/SIMD. Put in a >>> WARNING >>>     to make sure they are not invoked in the absence of FP/SIMD. >>> >>> KVM also uses the TIF_FOREIGN_FPSTATE flag to manage the FP/SIMD >>> state >>> on the CPU. However, without FP/SIMD support we trap all accesses >>> and >>> inject undefined instruction. Thus we should never "load" guest >>> state. >>> Add a sanity check to make sure this is valid. >> Yes, but no, see below. >> >>> >>> Fixes: 82e0191a1aa11abf ("arm64: Support systems without FP/ASIMD") >>> Cc: Will Deacon >>> Cc: Mark Rutland >>> Cc: Catalin Marinas >>> Cc: Marc Zyngier >> No idea who that guy is. It's a fake! ;-) > > Sorry about that, will fix it. > >> >>> Signed-off-by: Suzuki K Poulose >>> --- >>>  arch/arm64/kernel/fpsimd.c  | 31 +++++++++++++++++++++++++++---- >>>  arch/arm64/kvm/hyp/switch.c |  9 +++++++++ >>>  2 files changed, 36 insertions(+), 4 deletions(-) >>> >> [...] >> >>> diff --git a/arch/arm64/kvm/hyp/switch.c >>> b/arch/arm64/kvm/hyp/switch.c >>> index 72fbbd86eb5e..9696ebb5c13a 100644 >>> --- a/arch/arm64/kvm/hyp/switch.c >>> +++ b/arch/arm64/kvm/hyp/switch.c >>> @@ -28,10 +28,19 @@ >>>  /* Check whether the FP regs were dirtied while in the host-side >>> run >>> loop: */ >>>  static bool __hyp_text update_fp_enabled(struct kvm_vcpu *vcpu) >>>  { >>> +    /* >>> +     * When the system doesn't support FP/SIMD, we cannot rely on >>> +     * the state of _TIF_FOREIGN_FPSTATE. However, we will never >>> +     * set the KVM_ARM64_FP_ENABLED, as the FP/SIMD accesses >>> always >>> +     * inject an abort into the guest. Thus we always trap the >>> +     * accesses. >>> +     */ >>>      if (vcpu->arch.host_thread_info->flags & _TIF_FOREIGN_FPSTATE) >>>          vcpu->arch.flags &= ~(KVM_ARM64_FP_ENABLED | >>>                        KVM_ARM64_FP_HOST); >>> >>> +    WARN_ON(!system_supports_fpsimd() && >>> +        (vcpu->arch.flags & KVM_ARM64_FP_ENABLED)); >> Careful, this will panic the host if it happens on a !VHE host >> (calling non-inline stuff from a __hyp_text function is usually >> not a good idea). > > Ouch! Sorry about that WARN_ON()! I could drop the warning and > make this : > > if (!system_supports_fpsimd() || > (vcpu->arch.host_thread_info->flags & _TIF_FOREIGN_FPSTATE)) > vcpu->arch.flags &= ~(KVM_ARM64_FP_ENABLED | > KVM_ARM64_FP_HOST); > > to make sure we never say fp is enabled. > > What do you think ? Sure, that would work. I can't really see how KVM_ARM64_FP_ENABLED would get set though. But it probably doesn't matter (WTF is going to run KVM with such broken HW?), and better safe than sorry. Thanks, M. -- Jazz is not dead. It just smells funny...