From: Maciej Strozek <mstrozek@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
yung-chuan.liao@linux.intel.com, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: intel: sof_sdw: Prepare for configuration without a jack
Date: Fri, 03 Apr 2026 08:24:10 +0000 [thread overview]
Message-ID: <3b3191b9cdcaf65d91a093bdbdc9a649146d352d.camel@opensource.cirrus.com> (raw)
In-Reply-To: <d90c2911-1cb9-45c5-9c11-51d9259d8d1c@sirena.org.uk>
W dniu czw, 02.04.2026 o godzinie 16∶25 +0100, użytkownik Mark Brown
napisał:
> On Thu, Apr 02, 2026 at 11:59:43AM +0100, Maciej Strozek wrote:
>
> > @@ -134,6 +135,11 @@ int asoc_sdw_cs42l43_spk_rtd_init(struct
> > snd_soc_pcm_runtime *rtd, struct snd_so
> > if (ret)
> > dev_err(card->dev, "cs42l43 speaker map addition failed: %d\n",
> > ret);
> >
> > + ret = snd_soc_component_set_sysclk(component, CS42L43_SYSCLK,
> > CS42L43_SYSCLK_SDW,
> > + 0, SND_SOC_CLOCK_IN);
> > + if (ret)
> > + dev_err(card->dev, "Failed to set sysclk: %d\n", ret);
> > +
> > return ret;
>
> This means that instead of returning the error from the speaker map
> addition to the caller we now overwite it with whatever the attempt
> to
> set the sysclk does.
Thank you, fixed in v2.
--
Regards,
Maciej
prev parent reply other threads:[~2026-04-03 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 10:59 Maciej Strozek
2026-04-02 15:25 ` Mark Brown
2026-04-03 8:24 ` Maciej Strozek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3191b9cdcaf65d91a093bdbdc9a649146d352d.camel@opensource.cirrus.com \
--to=mstrozek@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®