From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 243B833D506 for ; Fri, 8 May 2026 18:29:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778264989; cv=none; b=tpzMmQltumweWBga205jRRpTDxFne/NA0TDUMhKVVu+cIJcbUyIxsKpqB5cGLl+BNtSD4xfp19tv29NZx93s3U4VazfYNVxW4HXOx3Ud6aItSHZxxyaaMcZEixC2tBSDCXuC+D275VeoP0bHDep6zaLK2kwv77S4iWv6UVdjEUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778264989; c=relaxed/simple; bh=a1XXboAXqoi9aljOVfrfJ+EoInoNmrNZq1ZRtf1fMmA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hFM5cTm5uADSrT+nErxqM3IRO64IWCrUHLe8vil7ZGqTRysVP0T+O6MTDwCdS7NH/Ic2Xc0RhuNTIJDUmeF4Q3jYRfalqyEKkx1FxI5dvGdLId0bNWbp15N7Vjy92NPXrj/9KqdHAIWrSxzItpC1tO1mZH2TMQCZhhGtlapr/SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lc5S7hSK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=o13qE7ci; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lc5S7hSK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="o13qE7ci" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778264987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ts89bXnsydMC3S8XTyf/KWj9UES6R504LBZEUkz/MQM=; b=Lc5S7hSK6w9Y7GjyRHgjdhJXw0WDtUKC85NZ7QQG+ao4fkzyOK4U6wVKN0MXmviq39+Q/F WksRmiA3yvilSQT/3NEVY4hIoGBcQDsCOCAHz573gOphzUYWN3bT62qYYd2B37xsi5fCUh 7M4E6uA/rNU3rdlyFHgN/i5NmZSPByc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-dgNLPUP9PNKKVOu9sd1AYQ-1; Fri, 08 May 2026 14:29:45 -0400 X-MC-Unique: dgNLPUP9PNKKVOu9sd1AYQ-1 X-Mimecast-MFC-AGG-ID: dgNLPUP9PNKKVOu9sd1AYQ_1778264985 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8f461b583acso235585085a.0 for ; Fri, 08 May 2026 11:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778264985; x=1778869785; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ts89bXnsydMC3S8XTyf/KWj9UES6R504LBZEUkz/MQM=; b=o13qE7cizze9O2kG4Uxh2IFdKtKy/zKojysHB6IAflWG/45eC+Se9oLGK8MFQog2rt qqTC7rvkhGBqnlNBTdIoPooOrdCz55x8+UoodVEYwe9X2f0GXc5GdeBHmUCZsQGmjXXB dhl9VhjwAbZJrcmbjui4effsK8pPFAP6ME/7EmI/5X9YKCFhW+M9jqczy0GIiQsccLQO dq19xak8zG9H3IQ8YCLLkCkW1efKioJi25+U2SD1Wh+7XnVGiVaZ2e8nRUKxcM4c0U5j HN+DlNcJXXN8/SXAmUSHD99dBUXZTki/zm/dshsCuoQroFDfW0iKEGM2CvmQiIac5K7a gt1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778264985; x=1778869785; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ts89bXnsydMC3S8XTyf/KWj9UES6R504LBZEUkz/MQM=; b=oIMLOhSw8XlWOCuCraPGJLu5tvlH8VjA6qYPHZMyJL41a90rCyH/QVt5LnHoTm/0CD r8TKfUbupgDEwtLCnW6YFoaxlJ+CEgGg06czK1XZkFLBnOnaAdVCoMugFaACXcP9fhlT xybRfQzT8L4PiVjXeXomnIJV+W0GI7f0aGoP/3/cf0DVwnU90ztqq9gsxjkWbTEet7VW nBwHmpepmzywpwJepQ5/4cklfqBy1pesTqpA93X0fpkh35J1ESs4fhxjlRYiglf1U507 b3wdzTwN3P5/xjA35oqQVq72QvmdcW9r4w032D4E9h9Yq8cWLTydHcV/zpShWEof3O9m qbuQ== X-Forwarded-Encrypted: i=1; AFNElJ+Ry6NfkIpKgtgvnkMm/hb3ZzLCPTeywvCPWzyTxiByCeCLOQL0oMA81c3dxsVydnz7iwqtOxGdm5pvhiI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv8172XzvgHucUToC2C8Fg9HsCjcEF9OJpbeZghXn4HkQv40ex GAM3mwRU8ypCuqX7FyIOVgqHXu+2Xhaf3eSKsgGkCt+nYlTYcYEIE3mRi7TX4C6jTR5huib6r8y 9F2MNqgGXnstnue7qOQIIY5lf+BZKAkil8nsA9liqmMTn2x2c48zSAydssQs2Q9ok4A== X-Gm-Gg: AeBDievquXhvxFMPrWmxiTWT03lGWcP6mtpxnf+VNmulRWCiv8qpBb7eQwgCC5q30Uy UkG/R5HkS89uOLuj0XwCXU8hek62lgLh8WnXClKS9iHNE3ex0UP7926RIWQAK7Ww/aQi0lG9KdF Hzl7NHFMHzc+YPLjjLT2I+cUEfq6H99sR3PgKDHvOis+y27p+o9+0jqN6FVU5tHPOn4I3wS/3tu TPFcY2pF8bp8BV4CkMDNw1W878+JDkBX6WCB303mb3rpE/rLtUzRmkl+GqnIpeqFIK6dxVg2r1J 7QeCR9Cc3iXC9Qu7N7ewPoPfNxKxy1NWxHTbviPTrmVdyorVTozsynjKxdjYqnHWmqbU7g18FiL 4Uua5YogYBfa/1nkzKA== X-Received: by 2002:a05:620a:2586:b0:8ec:7323:9361 with SMTP id af79cd13be357-904d72b9151mr1971900785a.55.1778264984982; Fri, 08 May 2026 11:29:44 -0700 (PDT) X-Received: by 2002:a05:620a:2586:b0:8ec:7323:9361 with SMTP id af79cd13be357-904d72b9151mr1971895885a.55.1778264984558; Fri, 08 May 2026 11:29:44 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-907b8e98521sm278551985a.17.2026.05.08.11.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:29:43 -0700 (PDT) Message-ID: <3b324ccebe4ce6f49f6ff7c9558408b9484589a4.camel@redhat.com> Subject: Re: [PATCH] nouveau/vmm: use kzalloc_flex From: lyude@redhat.com To: Rosen Penev , dri-devel@lists.freedesktop.org Cc: Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , open list Date: Fri, 08 May 2026 14:29:42 -0400 In-Reply-To: <20260312195529.13002-1-rosenp@gmail.com> References: <20260312195529.13002-1-rosenp@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sorry I didn't notice this patch until now! Reviewed-by: Lyude Paul Will push it to drm-misc-next in just a moment On Thu, 2026-03-12 at 12:55 -0700, Rosen Penev wrote: > Use the proper macro do to these sizeof calculations. >=20 > Signed-off-by: Rosen Penev > --- > =C2=A0drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > index 958fd78080bd..b9648290dffb 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c > @@ -53,7 +53,7 @@ nvkm_vmm_pt_new(const struct nvkm_vmm_desc *desc, > bool sparse, > =C2=A0 } > =C2=A0 } > =C2=A0 > - if (!(pgt =3D kzalloc(sizeof(*pgt) + (sizeof(pgt->pte[0]) * > lpte), GFP_KERNEL))) > + if (!(pgt =3D kzalloc_flex(*pgt, pte, lpte))) > =C2=A0 return NULL; > =C2=A0 pgt->page =3D page ? page->shift : 0; > =C2=A0 pgt->sparse =3D sparse;