From: Mark Brown <broonie@kernel.org>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: detach regmap from dev on regmap_exit
Date: Mon, 25 Nov 2024 12:22:17 +0000 [thread overview]
Message-ID: <3b35bd30-c4ca-459d-985e-d221a5cda2c8@sirena.org.uk> (raw)
In-Reply-To: <20241122151631.220609-1-demonsingur@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Fri, Nov 22, 2024 at 05:16:30PM +0200, Cosmin Tanislav wrote:
> +int regmap_detach_dev(struct device *dev, struct regmap *map)
> +{
> + if (!dev)
> + return 0;
> +
> + return devres_release(dev, dev_get_regmap_release,
> + dev_get_regmap_match, (void *)map->name);
> +}
> +EXPORT_SYMBOL_GPL(regmap_detach_dev);
Why is this exported?
> @@ -1445,6 +1457,7 @@ void regmap_exit(struct regmap *map)
> {
> struct regmap_async *async;
>
> + regmap_detach_dev(map->dev, map);
> regcache_exit(map);
>
> regmap_debugfs_exit(map);
The one caller is in the same file so it can be static.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-11-25 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 15:16 Cosmin Tanislav
2024-11-25 12:22 ` Mark Brown [this message]
2024-11-25 20:44 ` Cosmin Tanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b35bd30-c4ca-459d-985e-d221a5cda2c8@sirena.org.uk \
--to=broonie@kernel.org \
--cc=demonsingur@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®