From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frank.Li@oss.nxp.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Frank Li <Frank.Li@nxp.com>,
John Ogness <john.ogness@linutronix.de>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Zhaoyang Yu <2426767509@qq.com>,
Haoxiang Li <haoxiang_li2024@163.com>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-kernel@vger.kernel.org>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-serial@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device()
Date: Thu, 5 Nov 2026 00:04:25 +0100 [thread overview]
Message-ID: <3b390b39-c27b-4b62-aa49-5b1bb56c3cfb@oss.qualcomm.com> (raw)
In-Reply-To: <auuaYxoZm2T25cU5@ashevche-desk.local>
On 04/11/2026 21:49, Andy Shevchenko wrote:
> On Wed, Nov 04, 2026 at 09:52:06AM -0500, Frank.Li@oss.nxp.com wrote:
>>
>> Use the dmaengine_get_provider_device() API instead of directly
>> accessing chan->device->dev to get the DMA provider device.
>>
>> No functional change. Prepare make to struct dma_device private to the DMA
>> engine.
>
> Krzysztof, this patch was a split from the bundle by a reviewer request (not me
> FWIW), and author obeyed. So, you can do the same in cases when you got something
> you want to review independently on other content which most likely is a noise
> (to you).
Do you propose that I read all patches and complain that partial reviews
should be split? How does this proposal solve my complain that:
1. Incomplete/partial reviews will be marked as full review of the commit.
2. People get same credit even if they intentionally did not read 95% of
the patch as the people who read 100% of the patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-04 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 14:52 Frank.Li
2026-11-04 14:52 ` [PATCH v2 2/2] tty: serial: 8250: " Frank.Li
2026-11-04 20:52 ` Andy Shevchenko
2026-11-04 20:49 ` [PATCH v2 1/2] tty: serial: pch_uart: " Andy Shevchenko
2026-11-04 23:04 ` Krzysztof Kozlowski [this message]
2026-11-04 20:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b390b39-c27b-4b62-aa49-5b1bb56c3cfb@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=2426767509@qq.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=haoxiang_li2024@163.com \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®