From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Arnd Bergmann <arnd@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Maulik Shah <maulik.shah@oss.qualcomm.com>,
Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/qcom-pdc: fix linking against QCOM_SCM firmware
Date: Wed, 16 Sep 2026 07:49:59 +0200 [thread overview]
Message-ID: <3b3a9bf0-6fa7-401e-bc19-390bf22ff30f@oss.qualcomm.com> (raw)
In-Reply-To: <20260915195948.3521662-1-arnd@kernel.org>
On 15/09/2026 21:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Build testing with SCM disabled or in a loadable module fails
> with a link error:
>
> s390-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
> qcom-pdc.c:(.text+0x18b8): undefined reference to `qcom_scm_is_available'
> qcom-pdc.c:(.text+0x18ce): undefined reference to `qcom_scm_io_writel'
>
> As QCOM_SCM can already be enabled for compile testing on non-qualcomm
> machines, but is always enabled on Qualcomm Arm kernels, use that
> as the Kconfig dependency and remove the ||COMPILE_TEST check.
>
> Fixes: 1b852de05f74 ("irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM")
> Fixes: ad01c2b2f291 ("irqchip/qcom-pdc: Configure PDC to pass through mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-16 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 19:59 Arnd Bergmann
2026-09-16 5:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3a9bf0-6fa7-401e-bc19-390bf22ff30f@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maulik.shah@oss.qualcomm.com \
--cc=sneh.mankad@oss.qualcomm.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®