From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48993F9260 for ; Mon, 18 May 2026 15:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119585; cv=none; b=TyVHTqaeVUVXe8lj5rayupyMYSTKriKVcifNLNaqnF3lDzxa63UgK+Vjh56Y8E6SwoAw7N4Q+muScxg+HXVb/3ZPefnedQ3CeRRBjm6Fk5y2aGZJfz+WiF8fKeZAMK6dNXmp5LUfDdUG40u0xkcs2XssQ82GTqVF0ioLGJUfv1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779119585; c=relaxed/simple; bh=kV7wA03t3xolDsZur1Y4hsiu+lY9W9WaJm5yxNmK5Mo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R8rein3Oa6gYIinSzvny06jXA2BAd4oBX6Pcf3waLXJ9V3f3YJq87S9Hk9KddSJ2WvhgEgvdeXjW71ffVVf6poNc40j0WDmJ0PTnoOi7Z88eEWkFEbTABXgW4/BTXn6GXpGtD69vNQbP1ctSwZ4CaeFLOvQ6iXgh7IdDfloNezI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KDO9gHtX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CmRwxocr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KDO9gHtX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CmRwxocr" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64IAonDH2083007 for ; Mon, 18 May 2026 15:52:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= csR+wJpOLyPA3FCSrAWppws3sLkeJRysSK8h3qz+NAM=; b=KDO9gHtXEixHeMmG bumNm3ZDsHLjuZnYBvOTQTXPPSuc/28CGNelObvbJBJr+Nr7lU9YrXE2aeorvxjF oFQOu6D2NMTW5YPQ4AI62/WPQt9Cnhd8vgV7haghtzE7WLop9aGqNOwYucNBQ692 R/f1zHpdLLedMNYgPZbdTtyuv+IVH+KMXwNNs3EMLvuyeyZbrEs2Kt5tagpOhZnt 6WQtikJjsnrqeV6mRnt0epm6Ti49DpvVdTmFCR9pqQrMzBI32uLnwz06kXdajOV8 inem7w10KbtVHwzOyew6jMMqJ58/jOq9MRBlVbCXU6Ojt3XApm0tJR7adKIztl0F ve5AtQ== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e81ch95vy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 15:52:55 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-135916eefa0so8588159c88.1 for ; Mon, 18 May 2026 08:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779119574; x=1779724374; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=csR+wJpOLyPA3FCSrAWppws3sLkeJRysSK8h3qz+NAM=; b=CmRwxocryRWW3ckPbibELGcXqga3V4D3FBg4rTTdjnbC15FS7G+gLzJPBCfiy/skrI rlciFvyqI8m7gnKFNkbcPJ0yVudleQRecmYKixDusXVLvj8Wczi54G6OW1PX03+LFxBC eDc4Z24zF3QmxejfXHCBswe99TnrPSCKNmLdRehkaYspt3SIkm8FrGmg3y88bSWuEH+r Mdoo98dm1Py6myRRQ6sYdYVLCjc9EHdCUT92yXyxgIMcSBcF4sI/LJtJ4rBILsXEp9XN +UJkOH9YyCwB+dAdyDdrpBgAu/LNGNiHohIhrnO814GhSsgwuilbT3QbHR5vCOPJIpb8 bY5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779119574; x=1779724374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=csR+wJpOLyPA3FCSrAWppws3sLkeJRysSK8h3qz+NAM=; b=g6TBFn0/9qE4Dt6Wy5E+WdfTaWMEeKDSN9G6ESK4vm+ZLsH7ugpOfE3I0fiS32U4Rw WqKIcirK3Q/QOQaNfQJpBK88cTkkDHnPFMxh7hXsbyXatq0Wy9e0da+Z3FzH3FTPtr8c 3rht+ExXYeYq7MHKxrl/MvRspaCeMMOaFZNA3m9UDAYR0gnUbRj4dBi1W/n+0DUIjzzg kTm1S188yx6w7p1HJPjcqg3+rZEKtFuRhyUGPrzzT/NFzl2DzPpqeqx4BYsUvkWxnBDX gVPFlwVz9DDJDr4+uQTe7aaRQs05UYbz65AzebOj9mmsvqqV3hjo0fCoI3Ew0l4aeeuB TCkQ== X-Forwarded-Encrypted: i=1; AFNElJ8FCdudeQSWd/PMqyxnMKDIyVr4Buur8Fmczz21WfzXDndtvm5qfinmYjIbc87bk8qsHH3csTj7M9tu8UY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+o7OiLQZZ+8KGnTKNc7O9LuNEBwnZMpDplapsYK8bhmE+N8cO U7sXHPi7fsT4cwQ7Wc3zABq63H8RKAsbmGqRyhdrM+Zwo7qJzl97WK4dfYOKHzb8LyvmJ7xWywq WKWaZUi8RloFjIdq/DygpdjjUO0F/INZNUKrFCaYqwWKw3WL2wuM5XBAsCYFw97Ax/VU= X-Gm-Gg: Acq92OFN1Rb8KhsM9pvgQ6I/szSuRVf0awNz7be7MeDOW0GbtJNBEPqHEG3l7bu9q+n pUHcR7f0yaaX8xdVaEELtrUGdbr66ITgIzFg6/jpj70HqzPPoKsm4e8rxkQe/zXOsfs12D3NLG7 RVUE88i58HZ/wDfLvvvaGpOgvHxpbGbu1JrqjZzaeKwtlklgzArPyVs8A1Vv2mi66OH7ZHZZofL KLV39LJL1/t0UuTQDD5X5tSimiTNjVDVaSxUUS62wgYTSyanwSrsJg46IMnWaXIfejjQ611gmUc 4VKYsdGiv9ZpkWkEolJEYUa/Hy4q78T4zw7ou8jHrQdZDliAuH6qjSbbXgh+ll99Kfow3JG01KR Yu7qNrGISJdQpiN/trnEw64Q8zLXC7yyi9oeiOcGgOpiGZJ4qoWK+dg== X-Received: by 2002:a05:7022:ff42:b0:134:cbed:2b35 with SMTP id a92af1059eb24-13504517534mr7018460c88.18.1779119574043; Mon, 18 May 2026 08:52:54 -0700 (PDT) X-Received: by 2002:a05:7022:ff42:b0:134:cbed:2b35 with SMTP id a92af1059eb24-13504517534mr7018436c88.18.1779119573402; Mon, 18 May 2026 08:52:53 -0700 (PDT) Received: from [192.168.0.6] ([49.204.110.194]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cc2352f2sm20239854c88.10.2026.05.18.08.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 08:52:53 -0700 (PDT) Message-ID: <3b415d4c-7d09-4ddf-847b-b5a3d94aa5e3@oss.qualcomm.com> Date: Mon, 18 May 2026 21:22:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI To: Mark Brown Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260512-add-tracepoints-for-qcom-geni-spi-v2-0-3b184068ecf9@oss.qualcomm.com> <20260512-add-tracepoints-for-qcom-geni-spi-v2-1-3b184068ecf9@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=a4MAM0SF c=1 sm=1 tr=0 ts=6a0b35d7 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ZQCjlrEJpO1bLG4YfcUt8w==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=rWy7ofVw4T7H4fDcE_kA:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDE1NiBTYWx0ZWRfX29s5OKx1zcKO 4kFeTb4P4+uiTdvOt2c0TQnJ61usF89Fs9y6I451ES2DIC8uhoAwLB8rxIeQq3tBgEOAeArZYW6 HZN4vYdqg3+owtazF6w57ErxbelOqOV3lEINlJZujtDv+6SGuXIajqdl/K3YEygHXB3upGdBMMf dOqOcZ8qCMZaR0Yi8rFM0ZTk5lk9xf2Ein7alM/P0Byrk3nGjY5UNQ3bTaQQ40g1Md6iHf1bedT ObMEnaWKLnOt3r758EZfM7GxmFUMJvDtaNBxUvVZsjyXzOi/S/HaoQaluUWLG7Ur3A0QNPlU96/ zmivpOM/z21irNWlpC08EREq4NGgaY5WtK6eiqbLRSjMXqOjWFuWqN8DbOF3azsm36YuRB7gHuH 0ELmI6eBl1HtJ4PQwZMR1pLvtbdF7ESdgTR9l1pGogr5wPS1emMjSK5Yx++pmpduLLzW+oPmh9a 8jx1NXj3Swbp0yWW5uA== X-Proofpoint-ORIG-GUID: BAAELL-uHHWTJss4wE2MCeSfyh5tepR- X-Proofpoint-GUID: BAAELL-uHHWTJss4wE2MCeSfyh5tepR- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180156 Hi Mark, On 18-05-2026 19:37, Mark Brown wrote: > On Tue, May 12, 2026 at 11:42:52AM +0530, Praveen Talari wrote: > >> +TRACE_EVENT(geni_spi_fifo_params, >> + TP_PROTO(struct device *dev, u8 cs, u32 mode, >> + u32 mode_changed, bool cs_changed), >> + TP_ARGS(dev, cs, mode, mode_changed, cs_changed), >> + >> + TP_STRUCT__entry(__string(name, dev_name(dev)) >> + __field(u8, cs) >> + __field(u32, mode) >> + __field(u32, mode_changed) >> + __field(bool, cs_changed) > These don't really seem like FIFO parameters? I see that's the name of > the function where we log this but they're more just generic bus status > things. I agree with you. Can i use below name or any suggestions? +TRACE_EVENT(geni_spi_setup_params Thanks, Praveen Talari