From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753771AbdJSPfC convert rfc822-to-8bit (ORCPT ); Thu, 19 Oct 2017 11:35:02 -0400 Received: from smtp.citrix.com.au ([103.14.252.240]:51973 "EHLO SMTP.CITRIX.COM.AU" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbdJSPfB (ORCPT ); Thu, 19 Oct 2017 11:35:01 -0400 X-Greylist: delayed 582 seconds by postgrey-1.27 at vger.kernel.org; Thu, 19 Oct 2017 11:35:00 EDT X-IronPort-AV: E=Sophos;i="5.43,402,1503360000"; d="scan'208";a="106403708" From: Paul Durrant To: Paul Durrant , "x86@kernel.org" , "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] x86/xen: support priv-mapping in an HVM tools domain Thread-Topic: [PATCH] x86/xen: support priv-mapping in an HVM tools domain Thread-Index: AQHTSO5e8WNA4q7rqUG+jWR3ED8h4aLrSu9w Date: Thu, 19 Oct 2017 15:25:14 +0000 Message-ID: <3b4517fdcca741028af6ab2fcfd0c634@AMSPEX02CL03.citrite.net> References: <20171019152420.38389-1-paul.durrant@citrix.com> In-Reply-To: <20171019152420.38389-1-paul.durrant@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Apologies... I misformatted this. I will re-send. Paul > -----Original Message----- > From: Paul Durrant [mailto:paul.durrant@citrix.com] > Sent: 19 October 2017 16:24 > To: x86@kernel.org; xen-devel@lists.xenproject.org; linux- > kernel@vger.kernel.org > Cc: Paul Durrant > Subject: [PATCH] x86/xen: support priv-mapping in an HVM tools domain > > If the domain has XENFEAT_auto_translated_physmap then use of the PV- > specific HYPERVISOR_mmu_update hypercall is clearly incorrect. > > This patch adds checks in xen_remap_domain_gfn_array() and > xen_unmap_domain_gfn_array() which call through to the approprate > xlate_mmu function if the feature is present. A check is also added > to xen_remap_domain_gfn_range() to fail with -EOPNOTSUPP since this > should not be used in an HVM tools domain. > > Signed-off-by: Paul Durrant > --- > Boris Ostrovsky > Juergen Gross > Thomas Gleixner > Ingo Molnar > "H. Peter Anvin" > --- > arch/x86/xen/mmu.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c > index 3e15345abfe7..d33e7dbe3129 100644 > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -172,6 +172,9 @@ int xen_remap_domain_gfn_range(struct > vm_area_struct *vma, > pgprot_t prot, unsigned domid, > struct page **pages) > { > + if (xen_feature(XENFEAT_auto_translated_physmap)) > + return -EOPNOTSUPP; > + > return do_remap_gfn(vma, addr, &gfn, nr, NULL, prot, domid, > pages); > } > EXPORT_SYMBOL_GPL(xen_remap_domain_gfn_range); > @@ -182,6 +185,10 @@ int xen_remap_domain_gfn_array(struct > vm_area_struct *vma, > int *err_ptr, pgprot_t prot, > unsigned domid, struct page **pages) > { > + if (xen_feature(XENFEAT_auto_translated_physmap)) > + return xen_xlate_remap_gfn_array(vma, addr, gfn, nr, > err_ptr, > + prot, domid, pages); > + > /* We BUG_ON because it's a programmer error to pass a NULL > err_ptr, > * and the consequences later is quite hard to detect what the actual > * cause of "wrong memory was mapped in". > @@ -193,9 +200,12 @@ > EXPORT_SYMBOL_GPL(xen_remap_domain_gfn_array); > > /* Returns: 0 success */ > int xen_unmap_domain_gfn_range(struct vm_area_struct *vma, > - int numpgs, struct page **pages) > + int nr, struct page **pages) > { > - if (!pages || !xen_feature(XENFEAT_auto_translated_physmap)) > + if (xen_feature(XENFEAT_auto_translated_physmap)) > + return xen_xlate_unmap_gfn_range(vma, nr, pages); > + > + if (!pages) > return 0; > > return -EINVAL; > -- > 2.11.0