From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BECEE161916 for ; Tue, 18 Jun 2024 19:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718739224; cv=none; b=OmazOGcn+QxhoaqxYwcbtfmxD4BQvpmIyszsF6fOm36vlOHuqAn91wjTEHC8PKw5DHMF2k+azblcJB6qV62q54U8lALwLMmHPfzNy6MWjAAqvCAsEVsBg99RJabfJp5kxp9SG1ULEOesiP7OFA4TXX1bTqLrMBYugPtLl8Ggooo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718739224; c=relaxed/simple; bh=V/g8fsucdCq4Hz9P6VhWDZgBXpOVmBqfgtl4irdAbCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ElhKzmUzeLwcvjnT9C0P7edS6+VpwUKWq1K5SE6F7P8iQIciZgZweRasUTkzJqnaq6l4UwCp7kxLzsK0OaqS25X++Ei9tLj792TcBE8NNxDIIIkR8Zd+JsotleE4YM+KS0FW91UbvVpq6cAgl/BkyXLfMPLPCIEnuSYJ4nfqPWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mjre0nu0; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mjre0nu0" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-70df2135439so988553a12.1 for ; Tue, 18 Jun 2024 12:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718739222; x=1719344022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=7jD+WYmoS9mru0Ho0UfpsiKLQECAt+plwpcQLhmVgIY=; b=Mjre0nu05bBTqLOrSKbg/fWU/SW9cZTEkRiXPOMqjNQsUb33Z36DT6CQ3/95jfFo3G c1VlnEGNLunHcU4JAlc+ho3A6Cvd94TLpAuljuyjC7hxwiAFTRDEsOvn8Rn+qbdzIS44 Is2Ivwghs9JV/nNtXNRLLPQV4gKhCdCbmag8XtkZ7yXqjN0sfijbdlGKTwQizr19Gv8u DrmM75FhcUmRSHilfF0kLX9thGh+Al57dkDGq7lbyU7hOTtEzwtxVcDj8mU06jiCnMSl bZw9CWB+tBrUXvjIQrA3IfLijn8eieeJ10cQ6WpIdY2T5ZQW/fIZ67en5/Zw5SHczuSF mJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718739222; x=1719344022; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7jD+WYmoS9mru0Ho0UfpsiKLQECAt+plwpcQLhmVgIY=; b=UA94DjoM+vLkT174pYEZ5JhPDlQRqK0MZ4Idb1ls0gU+2xG/+ni39GnQcHv0KqC/Ip qdgrm8qZLgBYLcB2cXilQcHp9jwDDAj39LlFhJ5Fd2wSBEdm0uTEimiOkyHGQcA4D4dE 2m825z00F8hHFZY7nd8h4ovVFJpuWeWHkZHEusTAV3V6i1OAh53jqaR3VS+++EhAKHjH Rnx6dx4PqRT8BSIw8iu413CxSefhuBYqOgaFCOoxsY+TJLYV46IkeyyDAEF+zgR9+vo1 O16D5nSOx6CZVI92bIPIHjrEk37e6g74WY77TVucbd+IepfohEySaVZxOMecTM2FhmTJ lrxA== X-Forwarded-Encrypted: i=1; AJvYcCV8H0OTpFMO0Om1te1RWu4vYe9MN3hGGx+URleXpWCFS007QxtuG8wbcxWwKaXjX7k2ZIT8dk3x/06eO1mvOeob5h+aIDBr6Ed+Jcps X-Gm-Message-State: AOJu0Yz02Wda10e1+uz4Wqz7c8IEaDE/bCVX+hOvfbvyneXroscE/ncu fgVyxSFlhbQW205QOutqBFAf64h03QF5IfTHlZ3/CGDQp/Fr3qqY X-Google-Smtp-Source: AGHT+IHOGkOvZh+lvXwm/0bbnq+AdNSBIoHPUPpW4ZAgGGWfOaNnQq4biImcXpZt+UNYhrsXYwX6Yg== X-Received: by 2002:a17:90a:7087:b0:2c2:da02:a2c7 with SMTP id 98e67ed59e1d1-2c7b5dca970mr599578a91.44.1718739221982; Tue, 18 Jun 2024 12:33:41 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c79963a2b9sm1317626a91.54.2024.06.18.12.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 12:33:41 -0700 (PDT) Sender: Guenter Roeck Message-ID: <3b47b5e3-4eb2-43f9-8f4f-c021d203305e@roeck-us.net> Date: Tue, 18 Jun 2024 12:33:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Page select register restrictions in regmap core To: Mark Brown Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Armin Wolf References: <4b22e04f-3142-4a5a-a8d1-366c4b8bbb73@sirena.org.uk> <78c93d6b-af0e-4d96-b213-e1e402524361@roeck-us.net> <19893519-20a6-47cf-bb3b-c61dada627bc@sirena.org.uk> <1a62fc39-355c-4885-b5f6-b66f01a1328a@sirena.org.uk> <0287c32d-0b63-4873-9f71-0094a912f8bb@roeck-us.net> <44d4fce5-2ec9-4f62-b7ac-a317c7d843db@sirena.org.uk> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <44d4fce5-2ec9-4f62-b7ac-a317c7d843db@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/18/24 10:45, Mark Brown wrote: > On Tue, Jun 18, 2024 at 09:14:56AM -0700, Guenter Roeck wrote: > >> Anyway, this may be all irrelevant in respect to regmap support. >> It turns out that at least some i801 controllers don't work with the >> access mechanism used by regmap, or maybe the spd5118 chips don't support >> I2C_FUNC_SMBUS_I2C_BLOCK. I already found that those chips don't support >> auto-incrementing the register address and actually reset the address on byte >> reads (i.e., subsequent calls to i2c_smbus_read_byte() always return the data >> from the first register). Since regmap doesn't have a means for me to say >> "don't use I2C_FUNC_SMBUS_I2C_BLOCK even if the controller supports it", >> I may have to drop regmap support entirely anyway. That would be annoying, >> but right now I have no idea how to work around that problem. > > You can set the use_single_read and use_single_write flags in the config > to ensure registers are accessed one at a time, that restriction is > moderately common. That doesn't help, unfortunately. Thinking about it, that is not really surprising. The failing write is to the page register, and that was a single write anyway. Thanks, Guenter