mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-integrity@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	open list <linux-kernel@vger.kernel.org>,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH for-linus-v5.5-rc6 0/3] TPM changes for v5.5-rc6
Date: Mon, 06 Jan 2020 19:44:43 +0200	[thread overview]
Message-ID: <3b4b8c39ae0e5bd8635980cdd8db83c576e3fe09.camel@linux.intel.com> (raw)
In-Reply-To: <20200104043259.krg7uo6q7owg4fka@cantor>

On Fri, 2020-01-03 at 21:32 -0700, Jerry Snitselaar wrote:
> On Sat Jan 04 20, Jarkko Sakkinen wrote:
> > There has been a bunch of reports (one from kernel bugzilla linked)
> > reporting that when this commit is applied it causes on some machines
> > boot freezes.
> > 
> > Unfortunately hardware where this commit causes a failure is not widely
> > available (only one I'm aware is Lenovo T490), which means we cannot
> > predict yet how long it will take to properly fix tpm_tis interrupt
> > probing.
> > 
> > Thus, the least worst short term action is to revert the code to the
> > state before this commit. In long term we need fix the tpm_tis probing
> > code to work on machines that Stefan's code was supposed to fix.
> > 
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=205935
> > Cc: Jerry Snitselaar <jsnitsel@redhat.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > 
> > Jarkko Sakkinen (1):
> >  tpm: Revert "tpm_tis: reserve chip for duration of tpm_tis_core_init"
> > 
> > Stefan Berger (2):
> >  tpm: Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for
> >    interrupts"
> >  tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
> > 
> > drivers/char/tpm/tpm_tis_core.c | 34 +++++++++++++++------------------
> > 1 file changed, 15 insertions(+), 19 deletions(-)
> > 
> > -- 
> > 2.20.1
> > 
> 
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>

I'm sorry but forgot to append this before sending pull request :-/

/Jarkko


      reply	other threads:[~2020-01-06 17:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 23:29 Jarkko Sakkinen
2020-01-03 23:29 ` [PATCH for-linus-v5.5-rc6 1/3] tpm: Revert "tpm_tis: reserve chip for duration of tpm_tis_core_init" Jarkko Sakkinen
2020-01-03 23:29 ` [PATCH for-linus-v5.5-rc6 2/3] tpm: Revert "tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts" Jarkko Sakkinen
2020-01-03 23:29 ` [PATCH for-linus-v5.5-rc6 3/3] tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's" Jarkko Sakkinen
2020-01-04  4:32 ` [PATCH for-linus-v5.5-rc6 0/3] TPM changes for v5.5-rc6 Jerry Snitselaar
2020-01-06 17:44   ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b4b8c39ae0e5bd8635980cdd8db83c576e3fe09.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=jsnitsel@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®