From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8700377560 for ; Tue, 24 Feb 2026 10:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928185; cv=none; b=dg/KnclLiFIzS7xJgzm7pTWeIjdlPa/BoWdkYfStNznbixCYjXt2JVjGMcL9gh3PI6tO2a5Nehyf0pkqbW1c+43Elu3ed7WrkwqsxfefQHM5rCF1cFUkiBcJDIU0cTdZlPb1NcKwSgUmdEgcDI1NWNa4L4O74xjJgWRebsvu0WE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771928185; c=relaxed/simple; bh=tXSUvXCwunQ23EDzKHiUTSeV6Lu2PRx2BSlcE39rkkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZqfDcErvgXbugE4TO5kNnxKiAs0mwvZOkJgyGayTgPt8szxtjrRIR7wF6Mq3QygXsiJnIkqDS1aCPDbXMC/vtg6+r3km7qxX3Xi+fnMzm0dgseSOvtHRM7DJT8eCi7yyAXpF6e4Fg8x/ZTgM58q/FnOIjrhB5Ko19ko5LSIcaWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k55crp6B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bekabLQZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k55crp6B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bekabLQZ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61OAFUxf2006494 for ; Tue, 24 Feb 2026 10:16:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=k55crp6BYValQdOv gDW7zOqVuoB3RfmpldUW0H79OrK9FIkE2bEfqfgaTqE6EaBNM8fdNTymQ3Xa0Qzw EOyFTsJAulgmDqF4Cn4d21JEB8imiLRUdnYqW7BXtIoc+MJu3NqFJKSNeRR2vo/o 59HZWKnoS7oM0InEhV7YWiQpnjgWdQIHWILurUY12wX3W1FxHKnB8iiqmjSyqUmB 5Z/qsQTvftbkcDjinK7n3gsQ39tuhUWnz70pitScnPA6/LrXk/nq63+k+g3y74ag lhJ+++Pb8pB+OjXobtgUGQ/IiqPZkSFSIYEw/ws7oFctB6pK4313rbt5WREXgtAv x/TSSA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ch45693kf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 10:16:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb38346fdbso540289885a.0 for ; Tue, 24 Feb 2026 02:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771928183; x=1772532983; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=bekabLQZWtPPLLnOTJVI/6/G8HKVtuaCQZiWgLL/WGBTa7dcFwtJepPhzy20cIuB80 dodEroEuK/n1eMiHm7u+9e9zZk/y4tdGwsdWlqWHFfk6xCTaLBh9sOya0ZcDbPYIG2Bx svgo0TxRSysJLch2gMsCQz0neGcwzrLNH1x56xPbSy+fvz6unXYWM12oEkSXQN5gpXmU Te/2WC6+XGW9PVtWsSdCqa6E9OayA4qhKFPSVY0ia/Veb/tJTZPM0HP8GQDMxkOIagYp JpHV20gD0+eiVzymQnrcLNmddy5raA6MFP+emUFH2vfGCmmhgNtFWu8LdPWMRXlnq6tI wp7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771928183; x=1772532983; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SSFe2tWFC3c+9T/6vQ7AhbqX1hOj5PYF7zeMFWf212E=; b=cIzF3gr0aLrBiD4PFNBKbCbV29R509eoKuDGEydB17GDBzSTrCcmkNb5Sh91+mCX1m +buIUf3sRBTDG/XBmD1iZ0T/LpKiSh3jvJHqF+oyzye0thLX6q08NZgQlsFc9lOiSEPJ 6lORvizJeALzun4sCGdo6shExZzrhb2Fo/nKkXcskxbc9Q61UxgImEDkMXq/h9pyfHWX Go70aQTWCwXz/VHWdKSvygUsY2KZUG3KVChQbZsTiWQ+/GpRmiYERsjNt4rM6O4O1YAL WggvacOmMYWsJQvrIFN0jk/08/ibXnsMfURRvD0qppka4meHSgk9UBOnwBjENVWSQ1LJ TiXw== X-Forwarded-Encrypted: i=1; AJvYcCW9jm7ljPgsQJvCgc23prcZ+hEI4NAQs4QfwGACTjz6QMehgMJZKpALXskvAGJfQbDR/kzChyLL+y0fkZI=@vger.kernel.org X-Gm-Message-State: AOJu0YzeCbRsR+e5MRQtgiwzS0Xoq8Gz6tADWOfrn03iv8/AP4knZUL/ 4Uhhbk7TuQKXTquRCnol01vWPa+nK+dPVLtdhVLG4uGPcgy/57l1VJgsQ1FF3sFGPFG5PO+Y5WH M0SOIqyVkMMHOorekLEDyqdbNHR6LrqN1bZcseGYoSmeQYMWBuJ6gsoegBN+Neklncbg= X-Gm-Gg: AZuq6aKariLCqOpb9Fhgq9BmH5y0J+8uw5vGBfifjqFcTA/mJANg4Rgb31QNG9NYaXz zpO7PLlBgaerPB6a2IHj3/cHNPWcevg7bdXa9+n+gDdwMI7AFH0o0UcoSp4ZiKLJXu3uLSDBBxr 9s48n66GDWZelRtnyQydM1slZ1hQXrYG1vRPJtSCf+CMBNKyAEMgEPxyM0eWaOCEGSMPsmXQw8v NYjgW1U4DFQy1DNNBDmtJ07MZBHVDqna2sMw2mUZiEzcylV9sGGiG5k3JoecCh1t7Lud5shbjIq u0vNPbGUVv5oey+DcedFNOwHNaYoKgsnwJDNq+fhGiqABzjLAYLX56t/UKq0OHTw7dGjLWtbbEz cxVo/pmXPL0cvNEPJgXGtJKkOPu42pxaxoAb9p1nAekTKio8DlpQ9F66Qqu6b64i/iYiLCzp8RW 038qA= X-Received: by 2002:a05:620a:400e:b0:8b2:e346:de7b with SMTP id af79cd13be357-8cb8ca198ecmr1054712085a.1.1771928182927; Tue, 24 Feb 2026 02:16:22 -0800 (PST) X-Received: by 2002:a05:620a:400e:b0:8b2:e346:de7b with SMTP id af79cd13be357-8cb8ca198ecmr1054710785a.1.1771928182446; Tue, 24 Feb 2026 02:16:22 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084c84c37sm405006366b.23.2026.02.24.02.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 02:16:21 -0800 (PST) Message-ID: <3b4dfe95-9043-4682-8fee-7588fa1fde37@oss.qualcomm.com> Date: Tue, 24 Feb 2026 11:16:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/14] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP To: Srinivas Kandagatla , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-15-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260223180740.444311-15-srinivas.kandagatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: AuV6cmtPvYXNHNB3av8nbWEMUyjchAJ6 X-Proofpoint-ORIG-GUID: AuV6cmtPvYXNHNB3av8nbWEMUyjchAJ6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA4NCBTYWx0ZWRfXyXV9ceY8vFg1 XnPMBFDDyZW8YUQEhZea2Hx1ne5rtJdI6Qw5Kj3ytvY5jefWWKZgRSKAAD115aCsCmsAg8MDGRd v2SEwtSV8EHuOWhBm6zhcy5kD4Bn60qPUyNfVy7OPNy90lxtD1UzBpEjDfkiEB2cwgPGb+ywR6Q 3ss0koqIVPcZoZQF97hNolFHn4Yn9A4SDQ0kHkJugj+74PJcqJ4IomC/o382OWxv25CtLqQlV9j joxe7WCF2cxmr95Pra2hCLC2sHtbNJ8JlPGKjddv+JvLfsBoHK3rndPon7ow7J2m6EZA9WNZ89K SWTJQpcP6CxIh9fIZV7LuAHPyIBpMGC0HEZdUX7ADro1Zuxkb1jVxyBFGXzjIKM8S+rsmDiv+8U jX48K6Rlg2ERysyBOQtz9WMyK7aWH18ePKzuxdkBapckohxV5Y8RuJcdfX7uhfLnLYrQppiTmoH a6be17nk+qGzB4O0hVg== X-Authority-Analysis: v=2.4 cv=J8enLQnS c=1 sm=1 tr=0 ts=699d7a77 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=TT9Tk4Jx3cP5QYn9PwMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240084 On 2/23/26 7:07 PM, Srinivas Kandagatla wrote: > Buffers are allocated on pcm_new and mapped in the dsp on every prepare call, > which is inefficient and unnecessary. > > Add new functions q6apm_[un]map_memory_fixed_region to map it on > to dsp only once after allocation. > > Signed-off-by: Srinivas Kandagatla > --- [...] > -int q6apm_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, phys_addr_t phys, > - size_t period_sz, unsigned int periods) > +int q6apm_set_memory_map_handle(struct q6apm_graph *graph, unsigned int dir) > +{ > + if (dir == SNDRV_PCM_STREAM_PLAYBACK) > + graph->rx_data.mem_map_handle = graph->info->mem_map_handle; > + else > + graph->tx_data.mem_map_handle = graph->info->mem_map_handle; > + > + return 0; > +} This doesn't return a useful value today, will it ever? [...] > + case APM_CMD_SHARED_MEM_UNMAP_REGIONS: > + apm->result.opcode = hdr->opcode; > + apm->result.status = 0; > + rsp = data->payload; > + > + info = idr_find(&apm->graph_info_idr, hdr->token); > + if (info) > + info->mem_map_handle = 0; > + else > + dev_err(dev, "Error (%d) Processing 0x%08x cmd\n", result->status, > + result->opcode); > + > + dev_err(dev, "Memory Map region %x\n", rsp->mem_map_handle); Looks like a debug leftover (also in the below 'case') Konrad