From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 729DB4A07 for ; Thu, 4 Jun 2026 00:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780533987; cv=none; b=Kp7K+6p48HRqZJjldDKzhTpzN4DSjb+j6yVSkO/Uv4QC4eMohcZ7bV3n87zsNyqKdMMYmtvBBMk1NBdJFTx/njSV8NTFRhcyilZvRjr/A9wwse/QJ2PiyolbsqJiQNy7eVeils00Ghf7WBumLKCxICo5VJbPgQYVY9Gx7zVHthk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780533987; c=relaxed/simple; bh=2eXLg7+UTj+6M1socVzRC9ljt9/JbCjjIXt/BSPxboo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=P3Jg3h8lzsPr5wRtVPpPn9dBoL+W1+9DkwYoXPLHsjXK64POPq9bx6hN12PGWGlDyu3f1hiKWWmYMQgBz0fkXivT2L0w/E2n+K+JZihbqkqhIVH1WyaTfXlX4U5tgHQfgOCQ+Wfirf5XWmltc87iBw0vYtcgNIfWmB+pMOmdAoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=CVv5ds54; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="CVv5ds54" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1780533984; bh=2eXLg7+UTj+6M1socVzRC9ljt9/JbCjjIXt/BSPxboo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=CVv5ds54j2tEMkFa79CFllq32/Z8FIgSA/RsoPnNTkAtg8wb+SE4WQjpXhqatfnsD K+d0MF5P96nBL4zxDgyvBPcpV395qpnRustt1HWYRUi8yy2XyeYPZh8AvhfmqV9jV5 SMCNOlWH1czQADzOIhgn6SWURqgHjoNkvd4Oo3etTPPn1bX7ylIN/Uvin56yWPN3R5 fdBKGur4lRUfUXdk99+h2GdZ10ogAAwWyOSppCgVEe17s2kYmGRbHPE8AjOYXBaAiO /aU8AZ0tVpdHzQ0js0iwf0JdM3W+hb+GBAMzbixN+YCU6i3LA+6ihBoTgkEPh2kw30 dictAnWtyQq8w== Received: from [192.168.68.117] (unknown [180.150.112.11]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id B9D7860087; Thu, 4 Jun 2026 08:46:23 +0800 (AWST) Message-ID: <3b4fec04093d4f890a67df8b3d2e255b220d776f.camel@codeconstruct.com.au> Subject: Re: [PATCH v1 2/2] soc: aspeed: add host-side PCIe BMC device driver From: Andrew Jeffery To: =?ISO-8859-1?Q?Gr=E9goire?= Layet , Andrew Lunn Cc: joel@jms.id.au, jacky_chou@aspeedtech.com, yh_chung@aspeedtech.com, ninad@linux.ibm.com, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2026 10:16:23 +0930 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-06-03 at 15:43 +0200, Gr=C3=A9goire Layet wrote: >=20 > For the rest of the driver (shared memory, doorbell and mailbox), you are= right, > it makes more sense to implement rpmsg or virtio than just raw shared > memory binding. > These are software-defined communication channels and not hardware-emulat= ed, > so they would fit better as rpmsg or virtio drivers. > I took the SDK driver as a starting point without questioning its structu= re. > I have verified the VUART was working correctly with the shared > memory, doorbell and mailbox setup removed. > I can split this into VUART only and defer the rest for a separate > rpmsg/virtio work. >=20 > So I propose for v2: > - Remove the shared memory device, the sysfs doorbell and the mailbox > from this series. > - Retain only the required configuration and initialisation on the BMC > side driver. > =C2=A0 This should mainly be SCU and PCIe device configuration but other > initialisation will be reviewed to determine what is required. > - The shared memory, doorbell and mailbox features could then be > addressed in a separate future series, likely as virtio based driver. >=20 > Would that be acceptable? That sounds good to me. >From a brief inspection the driver also had support for both the 2600 and 2700. Something to consider is just supporting one of those for now, and adding support for the other in later patches. Andrew