From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbdFLGUb (ORCPT ); Mon, 12 Jun 2017 02:20:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58192 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbdFLGUa (ORCPT ); Mon, 12 Jun 2017 02:20:30 -0400 Subject: Re: [PATCH v10 09/10] powerpc/perf: Thread IMC PMU functions To: kbuild test robot Cc: kbuild-all@01.org, mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stewart@linux.vnet.ibm.com, eranian@google.com, benh@kernel.crashing.org, paulus@samba.org, sukadev@linux.vnet.ibm.com, ego@linux.vnet.ibm.com, mikey@neuling.org, dja@axtens.net, anton@samba.org, Anju T Sudhakar , Hemant Kumar References: <201706110405.SsDksZd2%fengguang.wu@intel.com> From: Madhavan Srinivasan Date: Mon, 12 Jun 2017 11:50:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <201706110405.SsDksZd2%fengguang.wu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-MML: disable x-cbid: 17061206-0008-0000-0000-0000013F7C53 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17061206-0009-0000-0000-0000096E9698 Message-Id: <3b50b153-147f-bd0b-4d00-cdc538d4ca10@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-12_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706120112 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 11 June 2017 01:43 AM, kbuild test robot wrote: > Hi Anju, > > [auto build test ERROR on powerpc/next] > [also build test ERROR on v4.12-rc4 next-20170609] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Madhavan-Srinivasan/IMC-Instrumentation-Support/20170609-183528 > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next > config: powerpc-defconfig (attached as .config) > compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=powerpc > > Note: the linux-review/Madhavan-Srinivasan/IMC-Instrumentation-Support/20170609-183528 HEAD 32ada0705ff79986e8ceca5e83dba14c0b620751 builds fine. > It only hurts bisectibility. > > All errors (new ones prefixed by >>): > > In file included from include/linux/compiler.h:62:0, > from include/uapi/linux/stddef.h:1, > from include/linux/stddef.h:4, > from include/uapi/linux/posix_types.h:4, > from include/uapi/linux/types.h:13, > from include/linux/types.h:5, > from include/uapi/linux/perf_event.h:17, > from include/linux/perf_event.h:17, > from arch/powerpc/perf/imc-pmu.c:13: > arch/powerpc/perf/imc-pmu.c: In function 'cleanup_all_thread_imc_memory': >>> arch/powerpc/perf/imc-pmu.c:863:31: error: 'cpu' undeclared (first use in this function) Have fixed this issue in the next patch. Damn my bad. Will wait for comments and if needed can respin just with this. Maddy > if (per_cpu(thread_imc_mem, cpu)) > ^ > include/linux/compiler-gcc.h:53:26: note: in definition of macro 'RELOC_HIDE' > (typeof(ptr)) (__ptr + (off)); \ > ^~~ > include/linux/percpu-defs.h:223:2: note: in expansion of macro 'SHIFT_PERCPU_PTR' > SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \ > ^~~~~~~~~~~~~~~~ > include/linux/percpu-defs.h:223:26: note: in expansion of macro 'per_cpu_offset' > SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \ > ^~~~~~~~~~~~~~ > include/linux/percpu-defs.h:256:29: note: in expansion of macro 'per_cpu_ptr' > #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu)) > ^~~~~~~~~~~ > arch/powerpc/perf/imc-pmu.c:863:7: note: in expansion of macro 'per_cpu' > if (per_cpu(thread_imc_mem, cpu)) > ^~~~~~~ > arch/powerpc/perf/imc-pmu.c:863:31: note: each undeclared identifier is reported only once for each function it appears in > if (per_cpu(thread_imc_mem, cpu)) > ^ > include/linux/compiler-gcc.h:53:26: note: in definition of macro 'RELOC_HIDE' > (typeof(ptr)) (__ptr + (off)); \ > ^~~ > include/linux/percpu-defs.h:223:2: note: in expansion of macro 'SHIFT_PERCPU_PTR' > SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \ > ^~~~~~~~~~~~~~~~ > include/linux/percpu-defs.h:223:26: note: in expansion of macro 'per_cpu_offset' > SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \ > ^~~~~~~~~~~~~~ > include/linux/percpu-defs.h:256:29: note: in expansion of macro 'per_cpu_ptr' > #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu)) > ^~~~~~~~~~~ > arch/powerpc/perf/imc-pmu.c:863:7: note: in expansion of macro 'per_cpu' > if (per_cpu(thread_imc_mem, cpu)) > ^~~~~~~ > > vim +/cpu +863 arch/powerpc/perf/imc-pmu.c > > 857 > 858 static void cleanup_all_thread_imc_memory(void) > 859 { > 860 int i; > 861 > 862 for_each_online_cpu(i) { > > 863 if (per_cpu(thread_imc_mem, cpu)) > 864 free_pages(per_cpu(thread_imc_mem, cpu), 0); > 865 } > 866 } > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation