From: Tariq Toukan <tariqt@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>, netdev-bot+sashiko@kernel.org
Cc: tariqt@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
gal@nvidia.com, leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, mbloch@nvidia.com,
ohartoov@nvidia.com, saeedm@nvidia.com, shayd@nvidia.com
Subject: Re: [PATCH net] net/mlx5: Lag, only cache max_tx_speed that FW has not accepted
Date: Thu, 8 Oct 2026 20:41:16 +0300 [thread overview]
Message-ID: <3b650188-f8f1-4d73-bde7-5ca877a9dfe9@nvidia.com> (raw)
In-Reply-To: <20261008094847.46b9b72f@kernel.org>
On 08/10/2026 19:48, Jakub Kicinski wrote:
> On Mon, 05 Oct 2026 07:42:28 +0000 netdev-bot+sashiko@kernel.org wrote:
>> - [Medium] This patch breaks the query-failure fallback added by commit
>> ad0ae7aefa7a ("net/mlx5: E-Switch, preserve max tx speed on vport…
>> - [Medium] The commit message does not match the code change.
>
> Can y'all comment please? It's been 3 days
Hi Jakub,
We received 3 different emails from Sashiko bots for this single patch.
Or replied to a similar issue in another Sashiko mail, but now I see it
wasn't the netdev one.
Anyway, sorry for the delay.
The fallback readers in mlx5_modify_vport_admin_state() and
mlx5_esw_adj_vport_modify() were removed by 86b785b18f8f ("Revert
\"net/mlx5: E-Switch, preserve max tx speed on vport state
modification\""), which is now in net, so clearing the cache no longer
affects them.
The second point is fair. The issue is theoretical (found by the AI
review of an earlier series, not observed), and the commit message does
not describe the actual change, which is to stop replaying values FW
already accepted.
pw-bot: cr
next prev parent reply other threads:[~2026-10-08 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 7:02 Tariq Toukan
2026-10-04 7:08 ` netdev-bot+sinfo
2026-10-05 7:42 ` netdev-bot+sashiko
2026-10-08 16:48 ` Jakub Kicinski
2026-10-08 17:41 ` Tariq Toukan [this message]
2026-10-08 19:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b650188-f8f1-4d73-bde7-5ca877a9dfe9@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®