mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Angel J <iamanaws@httpd.dev>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-rpi-kernel@lists.infradead.org"
	<linux-rpi-kernel@lists.infradead.org>,
	"helgaas@kernel.org" <helgaas@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"andrea.porta@suse.com" <andrea.porta@suse.com>,
	"florian.fainelli@broadcom.com" <florian.fainelli@broadcom.com>
Subject: Re: [REGRESSION] PCI: Dynamic OF node creation hangs on invalid bridge configuration
Date: Tue, 1 Sep 2026 08:07:41 +0200	[thread overview]
Message-ID: <3b6b0bbc-b73e-4e6e-89e1-1bc16841b50f@leemhuis.info> (raw)
In-Reply-To: <-KoxZtWNyNmnEu6-RkoMW2kenooTum0AiXwENwNBtoxqyI9wDXo1UJik1Wn9Igj_VRQ9bcYlva6FUZYq17UdPChUz_-mtDyrHSFO7t_broI=@httpd.dev>

On 9/1/26 02:59, Angel J wrote:
> A friendly ping on this regression.

Ideally the problem would be fixed, sure. But by your explanation it was
already in mainline and backporting those changes might be too much
churn. But you could try to submit a backport of ce26f588c831 (if that's
all that's needed) to the stable team (or ask somebody to do that for
you), maybe they will puck it up.

And overall: I not entirely sure if this counts as a regression, as you
(if I understood things properly) enabled something new in your .config
(that caused some other hidden problem to show up). That makes it a
non-regression, as, say, new security restrictions (that block things
that used to work) guarded by a new config option could never be
introduced otherwise in Linux.

Ciao, Thorsten

> It still affects Linux 6.18, and
> the tested invalid-bridge guard allows the machine to boot with
> CONFIG_PCI_DYNAMIC_OF_NODES=y.
> 
> Is any additional information or testing needed from me?
> 
> Thanks,
> Angel
> 
> 
> 
> On Saturday, August 22nd, 2026 at 19:14, Angel J <iamanaws@httpd.dev> wrote:
> 
>> Hello,
>>
> 
>> This regression was introduced in v6.17-rc1 and remains in the dynamic
>> PCI OF node code. Linux 6.18 fails very early during boot on my Dell XPS
>> 8940 when CONFIG_PCI_DYNAMIC_OF_NODES=y. The display goes black before
>> any useful console or pstore output appears, and the machine remains
>> hung.
>>
> 
>> Disabling CONFIG_PCI_DYNAMIC_OF_NODES makes the same kernel boot normally.
>> Linux v6.19-rc5 also boots because the RP1 driver stopped selecting that
>> option, not because the dynamic PCI OF node code changed.
>>
> 
>> Hardware:
>>
> 
>>   System: Dell XPS 8940, board 0K3CM7, BIOS 2.27.1 (2025-04-03)
>>   CPU: Intel Core i7-11700 (Rocket Lake)
>>   Triggering device: 0000:00:00.0, Intel 8086:4c43
>>   Firmware boot: UEFI, ACPI-based x86_64
>>
> 
>> Test results:
>>
> 
>>   Linux 6.12.103: good
>>   Linux v6.17-rc1: bad
>>   Linux 6.18.44, CONFIG_PCI_DYNAMIC_OF_NODES=y: bad
>>   Linux 6.18.44, CONFIG_PCI_DYNAMIC_OF_NODES=n: good
>>   Linux 6.18.44, CONFIG_PCI_DYNAMIC_OF_NODES=y, skip invalid bridge: good
>>   Linux v6.19-rc4: bad
>>   Linux v6.19-rc5: good
>>   Linux 4621c338d33f: bad
>>   Linux e55feea3a03a: good
>>
> 
>> The first-parent boundary between the last two tests is:
>>
> 
>>   e55feea3a03a ("Merge tag 'soc-fixes-6.19' ...")
>>
> 
>> That merge contains ce26f588c831 ("misc: rp1: drop overlay support"), which
>> removes:
>>
> 
>>   select PCI_DYNAMIC_OF_NODES
>>
> 
>> from MISC_RP1. The generated configurations differed only by:
>>
> 
>>   -CONFIG_PCI_DYNAMIC_OF_NODES=y
>>   +# CONFIG_PCI_DYNAMIC_OF_NODES is not set
>>
> 
>> CONFIG_MISC_RP1=m in both. The known-bad 4621c338d33f and Linux 6.18.44
>> both boot after disabling PCI_DYNAMIC_OF_NODES (and MISC_RP1, whose Kconfig
>> select otherwise forces it on).
>>
> 
>> There is no RP1 device in this machine, and its driver does not probe.
>> MISC_RP1 affects this x86 system only because its Kconfig select enables
>> PCI_DYNAMIC_OF_NODES globally.
>>
> 
>> I narrowed the hang to dynamic OF node creation for 0000:00:00.0
>> (8086:4c43), the Intel Rocket Lake-S integrated memory controller. On
>> this machine it reports PCI class 0604 and header type 1, but it is bound
>> to icl_uncore and is not a usable forwarding bridge:
>>
> 
>>   Bus: primary=ff, secondary=ff, subordinate=ff
>>   I/O and memory bridge windows: invalid/all ones
>>   kernel: bridge configuration invalid ([bus ff-ff]), reconfiguring
>>
> 
>> A minimal dynamic node for this device boots. Adding only
>> device_type="pci" makes it hang. Full PCI dynamic OF node generation also
>> boots when only 0000:00:00.0 is skipped.
>>
> 
>> I also tested a generic guard in of_pci_make_dev_node(). It reads
>> PCI_PRIMARY_BUS and skips node creation if the primary bus does not match
>> pdev->bus->number, the secondary bus is not greater than the primary bus,
>> or the secondary bus is greater than the subordinate bus. Linux 6.18.44
>> boots with CONFIG_PCI_DYNAMIC_OF_NODES=y and logs:
>>
> 
>>   pci 0000:00:00.0: skipping dynamic OF node for invalid bridge
>>
> 
>> The regression was introduced by 49d63971f963 in v6.17-rc1. Commit
>> ce26f588c831 made v6.19-rc5 boot by removing MISC_RP1's select of
>> PCI_DYNAMIC_OF_NODES. That avoids the failing path in the tested
>> configuration but does not change of_pci_make_dev_node().
>>
> 
>> I do not have a log from the failed boots. No output appeared with
>> earlyprintk=efi,keep, keep_bootcon, ignore_loglevel, loglevel=8,
>> initcall_debug, and EFI pstore enabled. Blacklisting both GPU drivers and
>> disabling the Intel IOMMU did not make the bad kernel boot.
>>
> 
>> Should of_pci_make_dev_node() reject devices with invalid bridge bus
>> configuration, or should 8086:4c43 use a device-specific quirk? I can
>> prepare and test a patch for either approach. For Linux 6.18 stable,
>> would that fix be preferable to backporting ce26f588c831 and its
>> dependencies?
>>
> 
>> #regzbot introduced: 49d63971f963
>> #regzbot title: PCI_DYNAMIC_OF_NODES early boot hang on ACPI x86
>>
> 
>> Thanks,
>> Angel J
>>
> 
>>
> 
>>
> 
>>
> 
>>
> 
>>


  reply	other threads:[~2026-09-01  6:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23  2:14 Angel J
2026-09-01  0:59 ` Angel J
2026-09-01  6:07   ` Thorsten Leemhuis [this message]
2026-09-03 23:17 ` Bjorn Helgaas
2026-09-04  8:57   ` Herve Codina
2026-09-09 11:27     ` Andrea della Porta
2026-09-11 23:01 ` Angel J
2026-09-11 23:04   ` [PATCH] PCI: of: Skip dynamic nodes for bridges without a subordinate bus Angel J
2026-09-12  4:31     ` [PATCH v2] PCI: of_property: Omit bus properties " Angel J
2026-09-16 14:50       ` Bjorn Helgaas
2026-09-18 19:55         ` [PATCH v3] " Bjorn Helgaas
2026-09-18 20:20           ` Bjorn Helgaas
2026-09-18 20:24             ` Angel J
2026-11-03 11:43             ` Herve Codina
2026-09-14 11:53   ` [REGRESSION] PCI: Dynamic OF node creation hangs on invalid bridge configuration Andrea della Porta
2026-09-14 22:05     ` Angel J
2026-09-14 23:28       ` Angel J
2026-09-15 10:30         ` Andrea della Porta
2026-09-16  1:21         ` Bjorn Helgaas
2026-09-16 11:14           ` Angel J
2026-09-16 14:42             ` Bjorn Helgaas
2026-09-16 19:28             ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b6b0bbc-b73e-4e6e-89e1-1bc16841b50f@leemhuis.info \
    --to=regressions@leemhuis.info \
    --cc=andrea.porta@suse.com \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=helgaas@kernel.org \
    --cc=iamanaws@httpd.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=regressions@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®