From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751324AbdJ2LvP (ORCPT <rfc822;w@1wt.eu>);
        Sun, 29 Oct 2017 07:51:15 -0400
Received: from mout.web.de ([212.227.15.4]:61671 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750848AbdJ2LvL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 29 Oct 2017 07:51:11 -0400
Subject: Re: [PATCH] ravb: Use common error handling code in ravb_probe()
To: Geert Uytterhoeven <geert@linux-m68k.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eugeniu Rosca <erosca@de.adit-jv.com>,
        Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
        Masaru Nagai <masaru.nagai.vx@renesas.com>,
        =?UTF-8?Q?Niklas_S=c3=b6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Yuval Shaia <yuval.shaia@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
References: <2839c3c2-0116-7549-6ff4-a49eb0a52298@users.sourceforge.net>
 <CAMuHMdXEWpryexcrN7OYcsGfyE3Y_-7Ej2CfgvYgUbZFTTHEWg@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <3b700d27-2da5-b7d0-13f0-e55a7df4a24d@users.sourceforge.net>
Date: Sun, 29 Oct 2017 12:50:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdXEWpryexcrN7OYcsGfyE3Y_-7Ej2CfgvYgUbZFTTHEWg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:n589iCMB7sSDk3h6z2wmjHmmwR9vuAbUn+WsVdTWYr7xzKzob4h
 D8U4sI6hnueHfJ8si+3Bvs0Q6ny6+0n/swm+Yettk2ZzYJTkAdoewdJQSd00a5KKJFBqOw/
 XTgNf4lLrs59od3pi0Gh/VVzzABg2Y3gLr9eq6UG9WTIf3WWqcPOoSN7nCoyVsswaZ3NfMk
 wGJJjzi8F8JrWQPJRd21A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:OhR8BPsRgHk=:tD1YBqlTRKLQdTK72Zpn5v
 RZwTwguLEtH0NRfy7rkGmWHK1KG+HpaUzNM2AdePuqqnatmET0VMVpliIZ+7A42Rwtzg65I3Q
 cpSOdkUq1xYCSYIwF0663GbcqY0a4PSP9elANnwk16Bu6Jvmp7Br20PPh412/iICuUVy0EmeC
 5oJYD9nTVQNwfcwjmEML2nUCQC7nY6d2xSg25/kbgi9m/rP0CluOFYtuKlbi3YmAV7OoIWm+s
 o4DeRBqmRzdQapROjwNpukI7E62l/M+ilfwK0Ro/3tsVlHQqSwLCnYv9SSyuOS8TxpIu6zrfo
 yQkSJdgzDHBkF21646bDerObacqQUE9kEysi2IH11L5xGF+XeMeAmVdjNHSB0fTeF7d3LqQlo
 ZOGgc58exNCekew/tp9WZZe6/1RBYMa+5tyGxZ0iw5eRSIV72aG+CUouuM+k6sdDuIDhmXSYB
 cCZoVc6MykBejyJCUE59DEq8OvUVJa0EdQNsILmeUECLO8RbFICVfiI+EFEO8FLBN3Mx4Ud5l
 Jo9Owd74MVKttZK+uC2SgqosIZRr4z6k/z2hoa42g5qjfXP6S5fYMMCfn3BS+uBpEE0W0nbPS
 r0r0/HH1u1Q4uSUR9PXTFtp13QR79l81UibpW7lvyKApP7X8d5HE6C+SmhHmEAj+XfKIlvLdH
 hiTmUeA0mgia6T3iVy819noHbNsLTBbhQOKR+dAhPmEXUW/K4AMmCdLbWKqoEJzO0HFHfhGS1
 sVW5eEj0jbZYArYyOLOGjMF/0NirCZHYl6AbqqqKbZSurOlcpuyC5uWKDv7ZSwmJSykO1opz2
 LF2XRd7aYbOwkjgXH6SATzQt7mRuV5tTkOXv5MkmxLqqGVhsf8=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -2069,10 +2069,9 @@ static int ravb_probe(struct platform_device *pdev)
>>                 irq = platform_get_irq_byname(pdev, "ch22");
>>         else
>>                 irq = platform_get_irq(pdev, 0);
>> -       if (irq < 0) {
>> -               error = irq;
>> -               goto out_release;
>> -       }
>> +       if (irq < 0)
>> +               goto failure_indication;
> 
> IMHO, it's really confusing that "irq" contains the error code, not "error".
> Especially when jumping to a meaningless label named "failure_indication"
> ("irq_failure" would be more intuitive).

Thanks for your constructive feedback.


> So I prefer the original code, regardless of the label name.

Can another attempt make sense to concentrate the setting of a variable
at the end of this function with more pleasing identifiers?

Regards,
Markus