From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH RFC] checkpatch: extend attributes check to handle more patterns
Date: Thu, 22 Oct 2020 09:14:45 -0700 [thread overview]
Message-ID: <3b706950110fe35c566dd00b684dc426867261e5.camel@perches.com> (raw)
In-Reply-To: <CABJPP5AQwRkT_2FozYxgTgUZ2RWS=k1TNN_QOvs6F5se-V-6ow@mail.gmail.com>
On Thu, 2020-10-22 at 20:29 +0530, Dwaipayan Ray wrote:
> On Thu, Oct 22, 2020 at 8:22 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
> > It is generally preferred that the macros from
> > include/linux/compiler_attributes.h are used, unless there
> > is a reason not to.
[]
> I am a bit worried about the code size though. Is it better altogether
> to have a shared function for parameterized/non parameterized
> __attribute__ arguments? Might have to categorize the macros then.
>
> What do you think is better?
I think A single shared mechanism better and more extensible.
Renaming all the code types from PREFER_<FOO> to something else
like PREFER_DEFINED_ATTRIBUTE_MACRO would be OK.
prev parent reply other threads:[~2020-10-22 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 14:52 Dwaipayan Ray
2020-10-22 14:59 ` Dwaipayan Ray
2020-10-22 16:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b706950110fe35c566dd00b684dc426867261e5.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®