From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] extcon: fsa9480: Drop no-op remove function
Date: Fri, 27 May 2022 18:09:56 +0900 [thread overview]
Message-ID: <3b785922-df17-3f5e-c3a2-be95cf3ea9c2@samsung.com> (raw)
In-Reply-To: <20220526130754.1587373-1-u.kleine-koenig@pengutronix.de>
On 5/26/22 10:07 PM, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/extcon/extcon-fsa9480.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/extcon/extcon-fsa9480.c b/drivers/extcon/extcon-fsa9480.c
> index 08bdedbcdb0d..7cff66c29907 100644
> --- a/drivers/extcon/extcon-fsa9480.c
> +++ b/drivers/extcon/extcon-fsa9480.c
> @@ -324,11 +324,6 @@ static int fsa9480_probe(struct i2c_client *client,
> return 0;
> }
>
> -static int fsa9480_remove(struct i2c_client *client)
> -{
> - return 0;
> -}
> -
> #ifdef CONFIG_PM_SLEEP
> static int fsa9480_suspend(struct device *dev)
> {
> @@ -376,7 +371,6 @@ static struct i2c_driver fsa9480_i2c_driver = {
> .of_match_table = fsa9480_of_match,
> },
> .probe = fsa9480_probe,
> - .remove = fsa9480_remove,
> .id_table = fsa9480_id,
> };
>
>
> base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
>
Applied it for v5.20-rc1. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
prev parent reply other threads:[~2022-05-27 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220526130812epcas1p272b572297501a35f98fa1c6656381cfa@epcas1p2.samsung.com>
2022-05-26 13:07 ` Uwe Kleine-König
2022-05-27 9:09 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b785922-df17-3f5e-c3a2-be95cf3ea9c2@samsung.com \
--to=cw00.choi@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®