From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1EA71F7918 for ; Fri, 17 Jan 2025 07:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737099131; cv=none; b=r8n1+qcgQ02SH/TOxkdTn9p5Nng+tz3KKXt7TsE2TsIVqUnfWuolY9X/QjcPJXThirgGfJcNgJGqnopxaQFKKaTP+tcmWyVRFbYWflexRts2F8sVY0m7st5W8GpTDS8oA+BN3XkeG/uxVomEDuRH9GgXvXUbf/vC9AIhqmSg95o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737099131; c=relaxed/simple; bh=qA9QZePOwTUj0bXV8b/Vf/vF2eA3UYivg8jj4vW+BHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K/ljI9nugCcEI1qfVCUwlkUVyA3kMKs/POc25p5+xHXhEvzy3tipzfUKv9zXHFPXR4xMiXPOgop0c0QLfaLQdAM94J0Eg5Btk+CdotRLXBpTrb60eKpe9q0s20EBg9dkwMYo7aVP7mKpAkQ9qZIamJ+hpq1D3tJJ65YV50vM+mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=DWLCjIjh; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="DWLCjIjh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+J2SdwR1RaPqpWX307j+VDchsJi1/A1n7pwagr60+7w=; b=DWLCjIjhCdqMSK50af/EGjHb4Q bbZiLR2lDg4iNYtcqvEO6V0xEs55DqFx5RFgUk6q5RxnjYjWLqB6YpasydmKnwV9h0oMiBrHgT0eC cUHfA4/HL8iXHjkVmzc8isN2Wk05oQK2pjx/Rp4asVj0T7F0KG7ZX6U194z0h9S4+ZclUZgOfAAJA 1CPRLaJA39F9e738BBGwsi52ZRSrV7DB6s3jhixJU2wx9grAa7m+Xjm4KD57fI3GdKxsMq3WW+ImW Mh9j8nsrX9242JrC/VflS4M/E074sYh1nHoxwRmszXQOHp3tVqJhiCbiZm8LUDXrAFwIjB3zkjNe0 I/55H1YQ==; Received: from [58.29.143.236] (helo=[192.168.1.6]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tYgpk-00H75c-Fa; Fri, 17 Jan 2025 08:32:00 +0100 Message-ID: <3b7880c6-2de2-4e68-b247-8c4ace4fc92b@igalia.com> Date: Fri, 17 Jan 2025 16:31:55 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] sched_ext: Add an event, SCX_EVENT_RQ_BYPASSING_OPS To: Tejun Heo Cc: void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org References: <20250116151543.80163-1-changwoo@igalia.com> <20250116151543.80163-6-changwoo@igalia.com> From: Changwoo Min Content-Language: en-US, ko-KR, en-US-large, ko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 25. 1. 17. 10:41, Tejun Heo wrote: >> + >> + /* >> + * When the bypassing mode is set, the number of bypassed operations. >> + */ >> + u64 RQ_BYPASSING_OPS; >> }; > > I'm not sure this is a particularly good way to account for bypass mode. > Maybe account the total duration of bypass modes,the number of times it was > activated and the number of times tasks were dispatched in bypass mode? I think it is a good idea to further specialize RQ_BYPASSING events. For the number of times the bypassing mode activated, what about BYPASS_NR_ACTIVATED? For the number of task dispatched,what about BYPASS_NR_TASK_DISPATCHED? I think BYPASS_NR_ACTIVATED and BYPASS_NR_TASK_DISPATCHED will be a good proxy for the total duration, so we can skip it until we have a clear user case. If we need the total duration now (maybe BYPASS_DURATION?), we can directly measure it in the scx_ops_bypass() directly. What do you think? Regards, Changwoo Min