From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56EDF52FE21 for ; Tue, 13 Oct 2026 18:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791915238; cv=none; b=ghXRuzVgIjUMCOVQL8p3MUa1EhNBgqpiEKez9VYLTxRwrujNUSB+54WGMjl89r7sVDDO2xYFqthWdpouC/7JlDk1B4IKPDnoS1Pv7YvplVRvvJsWd1MMUuEFkOuJC+jL2eGL72aeAxNbgVFGpo7R4usAm2AjcUKpS4Gpe2F4lMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791915238; c=relaxed/simple; bh=h5FQXIg46/WzdMHnSxLJ9ch75vB+gTmHwyBmjMT1fCo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XdYBw2cjMoAh4hvtOPRo7oTKJY10iTbv2Hpc59tXyVVBOSqrAm73z0+XbrPuLxpzewbe78BP83HYwWDMBq7gC4fIqjS4CUFPMLjBcpfLPRhK90eJ2q86GgNUcqVghHi3hxqOOmbdweUwaTi5jTpt2mGMR+q0dVUw1yTnn4KrpEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com; spf=pass smtp.mailfrom=bsbernd.com; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b=ApNfbTbL; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RC2XjDKl; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bsbernd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bsbernd.com header.i=@bsbernd.com header.b="ApNfbTbL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RC2XjDKl" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 7FA10EC0A67 for ; Tue, 13 Oct 2026 14:13:56 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 13 Oct 2026 14:13:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsbernd.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1791915236; x=1792001636; bh=qgi1DuaVKGgxY+t78ffi3qjr9jDrmiNgBIKWwcQNfss=; b= ApNfbTbL0XG0d2wwPl8PCL9oOW2D9YTrp53gxV9uAZx8tya9/sSpoylx3PkXp228 H1WKVrxmRliNU0MSLBaWwIWYiP8iJg9UIONa3eQK/73Hve+GTnBbNn5E2ZNPuQyU 5FXra1MH3PXtVV4YxcK4TopeuIz/fFF1C0kiIxQBlYkl66UVcq1fL3vwRZ9M9aOk eih4rtdLSTkFdZ8BJnUv/3/Ln1V7r0IgxhrLVTONvj+kjtk+ksXm2fi2HMA8kOkI 02LGjkoowoaKC+ctmQ8aTkNqGvkRb0TZCuhOqnKq4ZOLV27w1nClxHYkNr83w6gR K+mr4YX3Q1ZG8AsIIAIKxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1791915236; x= 1792001636; bh=qgi1DuaVKGgxY+t78ffi3qjr9jDrmiNgBIKWwcQNfss=; b=R C2XjDKlE6oQk0ZqZklXqkzi50yEdz38macacEO6EBBk+m1hePckNk4ffSdUz0R3O YiZaz9w0nHa2XJS/bfBwiNIitVuVTweVPnuyBfxK+ZQkNGa6tUUV6vmXsBKuop// 2ZNweP8WUx2fwH1VkD+s5Qy92Ma9fJdmkwr/zpLI2OnSC/MyNy3sBje7MBEBtOTe 7UD+8oxXMmMe+eElXpEGKY+dLEmC6qt6gUpExObPr60C/V7G+1MQ8Y5SdixuECGf P26eoEtUgYEPO5++wHonxZMUJ/kpkPevQMfdcgev7fvjCGqYgHrexLxeerXD12+z xPCh8y5J0wacJcRejR9QQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=sign d=bsbernd.com a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1791915236; d=bsbernd.com; mf=PGJlcm5kQGJzYmVybmQuY29tPg==; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:L2f7YjQlYCp7Oom5iAqKrZmnaZKPTk38Fdsqt9z3NAsF10i mObvRGegt+l7TTXFWdaE/WYxGigWj+IXzk5x3QuIacZes07qfFIrMGaPl0/lOA2/ PwuxqM4ipAsamv47caEAVZz6OMvM2iAgyRVGCBu3x2YZo2PM8B9qAznD9d00MZZu FQ91R8koRv9yRSbWMNsMVlSPmwEJVUvgLptJXloBrZGCnn5SS1nrSXvkcBC0lQti McuEU7u4EycM4HuOK5EDovjXz/8WAalSOPkGqY9jfUOsNE6KQl6y8PuQPL+6ImKP fRtD7xEa73pgcx0wLR8w6KadDveTp3+3v219LfQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-06; repo=github.com/dkim2wg/interop; date=2026-10-04; sw=lmtpprox; action=mi-m=1; hc=14; hn=cc,content-language,content-transfer-encoding,content-type, date,feedback-id,from,in-reply-to,message-id,mime-version, references,subject,to,user-agent; Message-Instance: m=1; h=sha256:AjC2ag7CJdL9JMyd3fYoToIETKjKSpBCBfaFvvOSZWk=:h5FQXIg46/WzdMHnSxLJ9ch75vB+gTmHwyBmjMT1fCo=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTG02tikcgp4UjlgO13AEnt1QpG1KGh71qhDoGqnxkXfDaHXAEIbZ1OYpXjO+ZjK3L wj+GCwoI3DZGWy46me0tschGqmzHLz5vt8r6hOBmtr1wu/Otk5XIOId25yS+6e0OSwX6h8 gRu9k783Cr2ve7EBA9NCgEGBlGF7ty0eigtQicANGXGPdwSZN9qqRKQ0ENhD3tWFSCtzwk PJ3FdD5KMfSUnJppJd1qT/FckUmZBNO+JqTEhKAFWuAcdT03TdKxKPR7FFAt4q0zfqwcIb efHq93owMfQLSpcEDe4rpp/TjWWyFAE2yGx8PeOeKpasuLkvY1TavliPQDSU6F/dW/PQnc LMlFIpt5ncbJdAW5pl08m5BKgt7AEoUGHnedLOyBXFbwDn5YvvNymyKD2PWllbKZRZe5Td DdNm2ujbggD+Hd+pxqlYGVfdPDZOyWDVGa7mtoFyDb68lAsrW0nnYVtPFb7dqrjqWI4w0w jrNl7xc/zJm1hvkc1zbzj+S0fY8hpsMlT9JNnV0S5oz55waQZTvFukXxZkr1iQAI4g4xvw QiKThkg9OYT48M/+hO6E4P/6krqqxe/SbgKWgujzRjX5gg6CcOtaG4aGYOU5IHmJAAT9Lx fg4NEVbh3uoZO4cTufnINOeKNDbUTH/lILxj7hyNrCjjq/5SgecQN0adXstA X-ME-Proxy: Feedback-ID: i5c2e48a5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Oct 2026 14:13:54 -0400 (EDT) Message-ID: <3b7a2fea-3fb9-42b6-aef2-d9770e3562d9@bsbernd.com> Date: Tue, 13 Oct 2026 20:13:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] fuse: convert the readdir cache to use folios To: Tal Zussman , Miklos Szeredi Cc: "Matthew Wilcox (Oracle)" , fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Joanne Koong References: <20260924-fuse-readdir-folio-v1-0-8dd97e71c1cc@columbia.edu> <3dfb90b9-e1d6-4a0d-899f-5db3160cb31b@columbia.edu> <5ff63ccc-3aba-4c4a-a289-48620f1ceffa@columbia.edu> From: Bernd Schubert Content-Language: fr, en-US, de-DE, ru-RU In-Reply-To: <5ff63ccc-3aba-4c4a-a289-48620f1ceffa@columbia.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/26 19:49, Tal Zussman wrote: > On 10/13/26 1:38 PM, Bernd Schubert wrote: >> On 10/13/26 18:48, Tal Zussman wrote: >>> On 9/24/26 7:42 PM, Tal Zussman wrote: >>>> Convert the readdir cache lookups in fs/fuse/readdir.c to folios. This >>>> removes the last caller of find_get_page_flags() and one of the last >>>> callers of find_lock_page(). >>>> >>>> Based on fuse/for-next. >>>> >>> >>> Hi, >>> >>> Following up on this. It'd be great to get this in as it would allow us >>> to remove find_get_page_flags() and find_lock_page() next cycle. >> >> >> fuse has large folios enabled now - the patches need to handle that. >> Even if it would not be enabled yet, Joanne had spend quite some effort >> to enable large folios, any change that tried to rely on behavior would >> have just increased her burden... >> > Hi Bernd, > > As far as I can see, Joanne's patches enable large folios for regular files. > Here we operate on directories, which are initialized through fuse_init_dir() > and so do not use large folios. In any case, these patches switch to using > the relevant folio helpers, which would get us closer to using large folios > in the readdir cache if that's eventually desired. Hi Tal, oops, sorry, I was bailing out when I read it as "this introduces another stop gap for large folios". I quickly scanned over it, but don't have much time right now - will review tomorrow morning. Sorry again, Bernd