From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BC2C6FD19 for ; Fri, 10 Mar 2023 08:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbjCJIcv (ORCPT ); Fri, 10 Mar 2023 03:32:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbjCJIcn (ORCPT ); Fri, 10 Mar 2023 03:32:43 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 622ADFEF06 for ; Fri, 10 Mar 2023 00:32:37 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id x3so17278485edb.10 for ; Fri, 10 Mar 2023 00:32:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678437156; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qHBd3Y0VvrBuq7MZ50gDgjgTfAiwAuooNzx/I7JEUXw=; b=ZlWttD2E/fTc6sozsXYMOODaiBWhScr+YjJItVN2GefRH0xMUdqwOZf8mE7FjehfuQ 9uTTkBaSBSi+znvYbHXEKAOvqQ7huiNNmdgyCuyC2J86I+9grR6wR6V/j+IU2reXffua RbLfMFlxGQNAU2knCQCVMa3Yp2rOhkmFhWdiOZaNg4oYsuQZWhjOzQu4ZBOBOtK4rSV6 Js1mBHru/S7XfykzdxLGLlzwNXq5t5zIGEIlE7fcxAhjKseDLIjR+G9zLIqe4NvQ75Sp DmwySuInWyF9kLDeuhVoPKE+JphSSizzKcaAyNNzzKeiq5QiRRN7TVLz5yxJbdWTyJ8z 8XMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437156; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qHBd3Y0VvrBuq7MZ50gDgjgTfAiwAuooNzx/I7JEUXw=; b=HQUDNYvnw+BAPZyN7YWv/ayupTWmrpIbNsUsJ20W8WrJHezAyyL9s12/KeDNDs8S7U 3N30dTbjhKTLcKpzxMv+8OOBEZZyDCQ66nbzAf7+m5sPn8R/QIgrQjwcHhjUkRTnlBxo OdEovBNpTYxh2F/tb5SALIQA3d9b4PX53QkjbhpaFYlDFTXAq4Sgr/aroddSXhgHPvFK IXO9zqDys7aUKm34CoGvMI88AQslaV3wnV0WtM5UxrsmaAcgo8KvryDVIsckdutVSsVQ QepbrmNGBHAYgGhzF2JCt4wcj5uWRHgt0amUV1cSSuRaKYNsblYwiy/9f3Pb5U6lZbNV Dg9A== X-Gm-Message-State: AO0yUKVHpaxSXUsiwv2Kp845gPwC8w7hfZr1TMAYIK1h1pMKNY/zLtrc MHKaZsLJkOacMSv7DYeg6zMDGA== X-Google-Smtp-Source: AK7set97xnKWsVre6NDR3NC+jr6Wd86sRJG6DewHgTjoe4XcRjSjYtnBHv4PeuEjxhBj7P+etdDudw== X-Received: by 2002:a17:907:608d:b0:88c:a43d:81bc with SMTP id ht13-20020a170907608d00b0088ca43d81bcmr28538165ejc.58.1678437155821; Fri, 10 Mar 2023 00:32:35 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:2a59:841a:ebc:7974? ([2a02:810d:15c0:828:2a59:841a:ebc:7974]) by smtp.gmail.com with ESMTPSA id e11-20020a50a68b000000b004bb810e0b87sm539370edc.39.2023.03.10.00.32.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 00:32:35 -0800 (PST) Message-ID: <3b7c6f28-57bd-33de-5531-8c4eae8cf6eb@linaro.org> Date: Fri, 10 Mar 2023 09:32:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 03/18] dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property Content-Language: en-US To: Alexandre Mergnat , Zhiyong Tao , Guenter Roeck , Linus Walleij , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , AngeloGioacchino Del Regno , Ulf Hansson , Wim Van Sebroeck , Krzysztof Kozlowski , Chaotian Jing , Rob Herring , Wenbin Mei , Matthias Brugger Cc: linux-mmc@vger.kernel.org, Alexandre Bailon , devicetree@vger.kernel.org, Amjad Ouled-Ameur , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-mediatek@lists.infradead.org, Fabien Parent References: <20230203-evk-board-support-v2-0-6ec7cdb10ccf@baylibre.com> <20230203-evk-board-support-v2-3-6ec7cdb10ccf@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20230203-evk-board-support-v2-3-6ec7cdb10ccf@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2023 14:17, Alexandre Mergnat wrote: > This SoC is able to drive the following output current: > - 2 mA > - 4 mA > - 6 mA > - 8 mA > - 10 mA > - 12 mA > - 14 mA > - 16 mA > > Then drive-strength property is set with enum to reflect its HW capability. > > Signed-off-by: Alexandre Mergnat > --- > Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > index 4b96884a1afc..101871ec6693 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > @@ -79,6 +79,9 @@ patternProperties: > > bias-pull-down: true > > + drive-strength: > + enum: [2, 4, 6, 8, 10, 12, 14, 16] Isn't this conflicting with mediatek,drive-strength-adv? Your commit msg suggests you add a missing property, but I would say nothing was missing here. You need review from (pinctrl) Mediatek maintainers how the bindings for all Mediateks are organized. Best regards, Krzysztof