From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2315226056C for ; Fri, 12 Jun 2026 18:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289096; cv=none; b=d57e94bx6//ZgtTSm+7DzbIBM1nvrlvHn9AjCLHC1oCQ5eQdtokiimlS27HxVOUN/3aAsj1yHNMsFIzJ8xcKzt2M5zN7hjY7SesT2VsPTP5C4kiIYIBzHCC1PMCl88CxYT2HDhIqdVT3IVGYGtVV+smmsuiqHWxFF+60xCqLEfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289096; c=relaxed/simple; bh=7yn0/utgYVTOzUs+vb5c05ZV/Jxy6WpLqXn0DYdLdKo=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=XjH8xsyQCM4+4lr0rbMBBkO/tR1o7g6QUS8Ob3LeNAQPdqQi1dAWd9Ycwj+d58ADlBM2SrXeoCuUlxlC4POtU40Pta+OF29zqZJT7bydIn3GTTNZ7iGrmbwKydSInrzj7rWOJU24dfwvv3kJOnMDTRXjj15UOAMTorcbXnuZRi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zk5Fh91g; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zk5Fh91g" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490be03d47bso13711605e9.0 for ; Fri, 12 Jun 2026 11:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781289093; x=1781893893; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=95AvFvq/SHF/XMgHFAPH0gEXz2BnMwa+fdNSG/EQyq4=; b=Zk5Fh91gSl4XTJRJmoM0if8u9PfmlOEE8uKaDGRYI4WTzE6LgYbi8eo+bmf3SCT/Je 8x5IvZVP78knfKgo0hmeKMHQrynb7mdhXddEiz+cJW9PasQlNBrI8hgrxTALX46Zfjkq of/k//95hGUziOspiMxBKvjylZwXflEaka+ddd9JsVsj5O+DX8aAgUg8baFCJTYR60dA J/dUpuVkNBpYtwpliX2xoyDc/8UnQQyshogqRkpxCJ7EbzfowkrZT9lOV0xFC4PFcBIg v8r40Zv3Voa3wbH6Xw7obKOVwSwgHWiY+DKOK1hzzL3mouI/tF2mb0/fRz3tPu0u1ZWG N1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289093; x=1781893893; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=95AvFvq/SHF/XMgHFAPH0gEXz2BnMwa+fdNSG/EQyq4=; b=HIxbQBsV0/6iD6CH0vMTLX1fhXbes/YPKU6kY7tg04VzrMnQFunJ81eJXxVynqtb44 RptqKjw4sZBLY/r1iDZS3PYIrLzYifnOA32hwx3a/x/2y3TaQTF13MtZVFCmSlTOHYhz NMKl4lR2r8Xr4eb3EWWovXUobA2KpojBCB4y26GBsJeUJUdwJlWijiqfNuhRlV+gZ302 kXr9MNIELgqI9GeXkUf8FsSXZ2/VE4of+muZsxC0h5hemcwpJhBeuv0hn9dcQiz4m0BN NWqUOkp6xBL70uClbkyK04L+uko5oBZv/mgI3JCDEjf+y5JKb6qD7f6aD5tdtOEq8yGK GDCg== X-Forwarded-Encrypted: i=1; AFNElJ+UGicxuS/1jeHKhQrH+O6z/e1+eo0hK8ykpFiWdwExgB0qzc8U+eFO7UqVrIgXT8BADShaq1Dwx5Jll0M=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz/mhRkKTg7RC0uC9etTCgmUm5hwGaJbsyVPkciTe6m3OdnUaY UtsiwuiMrDv1b2crg8t9UXAbCnUxFfCg4CqtwwcvI50llylPXDQYgLfV X-Gm-Gg: Acq92OHmxoszVX6VSZMpixX9IYdGvK+E9DWF+kwNXeVTQCEdt4JfIQZ42AGWm1vcllg m7eKtfTYoeqDRGV2+WkV0u43f97bfeC6cLl0j8z8RifD6pvdCxg26QFdFtE4RdaUgTTWC1QPAta csM/UwL9Rl/zVlOF3kP2SPnoEN65n3wa7sxouoTGlgxtLRUbaBjBxjqdGHXUxmA4gFVsaGBc4HJ VkHcrotKN7l993Yh5D8ImCB/rno2WCUYDK1KX3hwKWzKAT0tAnly/4n6adB2oS5nErJPMYug39q iIco9YNEDVq2CscNBa0S3g2nYYH82OA1ud9MPDIvp5mPiiuv5BMlZEk0dzWMY25fXf3h0gTJda7 t5xJHK6b9IAO61/4Qld8oIgTnQBaXMXA83LmJVmm9LU6Tg0LZjOVeV8EQCmq3wpj5ic6d4lw02j 6HG0P56Bf6/kWTcooB87cuN8MAOXruRl1Yt+ohNM5bizhJrDs6FSM3IHzowW8moE1tXo60fosCR uw= X-Received: by 2002:a05:600c:214b:b0:490:bd1d:472a with SMTP id 5b1f17b1804b1-490ec4d7879mr37936905e9.15.1781289093399; Fri, 12 Jun 2026 11:31:33 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:742:25a:e03e:6c9c:49d8:2fee? ([2a00:1fa0:742:25a:e03e:6c9c:49d8:2fee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492203c0801sm6310585e9.10.2026.06.12.11.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 11:31:33 -0700 (PDT) Message-ID: <3b7ce952-d653-4957-ba20-a14f932ad639@gmail.com> Date: Fri, 12 Jun 2026 21:31:30 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next 5/9] net: ethernet: ravb: Replace gPTP flags with callbacks To: =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Geert Uytterhoeven , Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610102432.3538432-1-niklas.soderlund+renesas@ragnatech.se> <20260610102432.3538432-6-niklas.soderlund+renesas@ragnatech.se> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260610102432.3538432-6-niklas.soderlund+renesas@ragnatech.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/10/26 1:24 PM, Niklas Söderlund wrote: > Prepare for adding Gen4 support which will add a third and new way to > interact with the gPTP clock by replacing the flags for Gen2 behavior > (info->gptp) and Gen3 behavior (info->ccc_gac) with callbacks. > > This will make adding Gen4 support cleaner as the code will not have "if > else if else" sprinkled all over to handle each generations special > cases. > > Signed-off-by: Niklas Söderlund Reviewed-by: Sergey Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index 013ced6dcf29..70bef3b31d38 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -1034,6 +1034,27 @@ struct ravb_ptp { > struct ravb_ptp_perout perout[N_PER_OUT]; > }; > > +/** > + * struct ravb_gptp_info - Platform specific gPTP behavior > + * > + * Each generation of RAVB have slightly different behaviors when interacting Well, I haven't seen the word RAVB in any Renesas' manuals, have you? I personally prefer calling it EtherAVB; the manuals had "Ethernet AVB", IIRC... :-) [...] MBR, Sergey