From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46921C43603 for ; Mon, 16 Dec 2019 16:53:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 13761206D7 for ; Mon, 16 Dec 2019 16:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="InUpgdik"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="InUpgdik" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbfLPQxs (ORCPT ); Mon, 16 Dec 2019 11:53:48 -0500 Received: from node.akkea.ca ([192.155.83.177]:42102 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbfLPQxs (ORCPT ); Mon, 16 Dec 2019 11:53:48 -0500 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id DE9014E2006; Mon, 16 Dec 2019 16:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1576515227; bh=PDG4xILM0ggz//+/yPEhO7+YPyNm+jyBiOoMiKrGSH8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=InUpgdik2rw3RH9CAtDXLPzGZbi+Mj1zDS30acc3jowFAyTe3WnxZqWlBIz3jqTKP AQX4vJEMDoswjIXvOI5uwt+LRYip/IvOHB+5wb1gzX2ObciSlG/vu7EdXXQPwmOlv0 A+8EBtIqugoP69y/EA4r5qWpBrUVXMydcOU6Mjuo= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5XS3_Gd8CFnQ; Mon, 16 Dec 2019 16:53:47 +0000 (UTC) Received: from www.akkea.ca (node.akkea.ca [192.155.83.177]) by node.akkea.ca (Postfix) with ESMTPSA id 725604E2003; Mon, 16 Dec 2019 16:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1576515227; bh=PDG4xILM0ggz//+/yPEhO7+YPyNm+jyBiOoMiKrGSH8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=InUpgdik2rw3RH9CAtDXLPzGZbi+Mj1zDS30acc3jowFAyTe3WnxZqWlBIz3jqTKP AQX4vJEMDoswjIXvOI5uwt+LRYip/IvOHB+5wb1gzX2ObciSlG/vu7EdXXQPwmOlv0 A+8EBtIqugoP69y/EA4r5qWpBrUVXMydcOU6Mjuo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 16 Dec 2019 08:53:47 -0800 From: Angus Ainslie To: Mark Brown Cc: kernel@puri.sm, Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH v2 0/2] Add the broadmobi BM818 In-Reply-To: <20191216122258.GC4161@sirena.org.uk> References: <20191214235550.31257-1-angus@akkea.ca> <20191216122258.GC4161@sirena.org.uk> Message-ID: <3b7f47120df1d63747788bf9de16392c@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-16 04:22, Mark Brown wrote: > On Sat, Dec 14, 2019 at 03:55:48PM -0800, Angus Ainslie (Purism) wrote: > >> Angus Ainslie (Purism) (2): >> sound: codecs: gtm601: add Broadmobi bm818 sound profile >> dt-bindings: sound: gtm601: add the broadmobi interface > > As I said in reply to v1: > > | These subject styles don't even agree with each other :( - please > | try to be consistent with the style for the subsystem (the latter > | one matches, the first one doesn't). Sorry I missed fixing that. I will re-submit. Do you have any comments on the code changes I made in v2 ?