mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikita Travkin <nikita@trvn.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	cros-qcom-dts-watchers@chromium.org,
	Stephan Gerhold <stephan@gerhold.net>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
Date: Sat, 17 Jun 2023 23:11:55 +0500	[thread overview]
Message-ID: <3b7f6b2677608fad438e4338779f2c1a@trvn.ru> (raw)
In-Reply-To: <20230617171541.286957-8-krzysztof.kozlowski@linaro.org>

Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> ADC channel node names were changed to require generic 'channel'.  The
> user-visible part is defined via label.
> 
>   sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for fixing this up!

Reviewed-by: Nikita Travkin <nikita@trvn.ru>

> ---
>  arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index b637b4270f88..dbb48934d499 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -314,16 +314,18 @@ &mdss_dsi0_phy {
>  };
>  
>  &pm6150_adc {
> -	thermistor@4e {
> +	channel@4e {
>  		reg = <ADC5_AMUX_THM2_100K_PU>;
>  		qcom,ratiometric;
>  		qcom,hw-settle-time = <200>;
> +		label = "thermistor";
>  	};
>  
> -	charger-thermistor@4f {
> +	channel@4f {
>  		reg = <ADC5_AMUX_THM3_100K_PU>;
>  		qcom,ratiometric;
>  		qcom,hw-settle-time = <200>;
> +		label = "charger_thermistor";
>  	};
>  };

  reply	other threads:[~2023-06-17 18:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply Krzysztof Kozlowski
2023-06-17 18:14   ` Nikita Travkin
2023-06-17 17:15 ` [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI Krzysztof Kozlowski
2023-06-19 13:12   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C Krzysztof Kozlowski
2023-06-19 13:12   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties Krzysztof Kozlowski
2023-06-19 13:12   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C Krzysztof Kozlowski
2023-06-19 13:13   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names Krzysztof Kozlowski
2023-06-19 13:13   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
2023-06-17 18:11   ` Nikita Travkin [this message]
2023-06-19 13:13   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply Krzysztof Kozlowski
2023-06-19 13:14   ` Konrad Dybcio
2023-06-23 18:34     ` Doug Anderson
2023-06-24  7:39       ` Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names Krzysztof Kozlowski
2023-06-19 13:14   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings Krzysztof Kozlowski
2023-06-19 13:14   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports Krzysztof Kozlowski
2023-06-19 13:15   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
2023-06-19 13:15   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings Krzysztof Kozlowski
2023-06-19 13:15   ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup Krzysztof Kozlowski
2023-06-19 13:15   ` Konrad Dybcio
2023-06-17 18:25 ` [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Nikita Travkin
2023-07-10  5:07 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b7f6b2677608fad438e4338779f2c1a@trvn.ru \
    --to=nikita@trvn.ru \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®