From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2641E7C4E2 for ; Wed, 4 Oct 2023 16:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243519AbjJDQrD (ORCPT ); Wed, 4 Oct 2023 12:47:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233112AbjJDQrC (ORCPT ); Wed, 4 Oct 2023 12:47:02 -0400 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82CA69B; Wed, 4 Oct 2023 09:46:57 -0700 (PDT) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id C16B9100005; Wed, 4 Oct 2023 19:46:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru C16B9100005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1696438015; bh=z9bJz6Un0b+xRYiJskf4ArUids1aiUycXAy7dlAeGms=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:From; b=bIBDiAFliX1Kty1JVnA6RmpxObV1AE32UvLZTt8zGD8qUSOntUBK3hiAIMr151ve8 D0m3Ur5tfAcbDEDe5PzA3asK2azmf/Rl8SLT5ekT3JKV5uGC4w0VmA1C/Zx/8GAXYU BRvsWKnv8oVYF0aDGhaiULQrJbsJGGd8pqGqlVnrBQo+TIE56iqs/zJnFULF4+Wa/n vyv9sbA5/QwzGJpRS1T67cBFlpPaaxKoDnkL1MwE9vpfi6RKo+UzsAOH7Ijt3S2Bu9 gPVqzMJYbloAEfY3xU72LEUFELIwlwEZ99vUL/05/m1agnha6gbWGP8SX7TQwxNton MqQFbWfkODmjw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 4 Oct 2023 19:46:55 +0300 (MSK) Received: from [192.168.0.106] (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 4 Oct 2023 19:46:55 +0300 Message-ID: <3b7fa94a-3cee-8bec-ce43-b61d893e05d8@salutedevices.com> Date: Wed, 4 Oct 2023 19:40:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Content-Language: en-US To: Stefano Garzarella CC: Stefan Hajnoczi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Jason Wang , Bobby Eshleman , , , , , , References: <20230930210308.2394919-1-avkrasnov@salutedevices.com> <4nwo6nd2ihjqsoqnjdjhuucqyc4fhfhxk52q6ulrs6sd2fmf7z@24hi65hbpl4i> <5ae3b08d-bcbb-514c-856a-94c538796714@salutedevices.com> From: Arseniy Krasnov In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 180363 [Oct 04 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: avkrasnov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 535 535 da804c0ea8918f802fc60e7a20ba49783d957ba2, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, p-i-exch-sc-m01.sberdevices.ru:7.1.1,5.0.1;salutedevices.com:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;lore.kernel.org:7.1.1;git.kernel.org:7.1.1;100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/10/04 12:21:00 X-KSMG-LinksScanning: Clean, bases: 2023/10/04 14:53:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/10/04 15:39:00 #22058417 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.10.2023 19:42, Stefano Garzarella wrote: > On Wed, Oct 04, 2023 at 07:22:04PM +0300, Arseniy Krasnov wrote: >> >> >> On 04.10.2023 08:25, Arseniy Krasnov wrote: >>> >>> >>> On 03.10.2023 19:26, Stefano Garzarella wrote: >>>> Hi Arseniy, >>>> >>>> On Sun, Oct 01, 2023 at 12:02:56AM +0300, Arseniy Krasnov wrote: >>>>> Hello, >>>>> >>>>> this patchset contains second and third parts of another big patchset >>>>> for MSG_ZEROCOPY flag support: >>>>> https://lore.kernel.org/netdev/20230701063947.3422088-1-AVKrasnov@sberdevices.ru/ >>>>> >>>>> During review of this series, Stefano Garzarella >>>>> suggested to split it for three parts to simplify review and merging: >>>>> >>>>> 1) virtio and vhost updates (for fragged skbs) (merged to net-next, see >>>>>   link below) >>>>> 2) AF_VSOCK updates (allows to enable MSG_ZEROCOPY mode and read >>>>>   tx completions) and update for Documentation/. <-- this patchset >>>>> 3) Updates for tests and utils. <-- this patchset >>>>> >>>>> Part 1) was merged: >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=71b263e79370348349553ecdf46f4a69eb436dc7 >>>>> >>>>> Head for this patchset is: >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=236f3873b517acfaf949c23bb2d5dec13bfd2da2 >>>>> >>>>> Link to v1: >>>>> https://lore.kernel.org/netdev/20230922052428.4005676-1-avkrasnov@salutedevices.com/ >>>>> >>>>> Changelog: >>>>> v1 -> v2: >>>>> * Patchset rebased and tested on new HEAD of net-next (see hash above). >>>>> * See per-patch changelog after ---. >>>> >>>> Thanks for this new version. >>>> I started to include vsock_uring_test in my test suite and tests are >>>> going well. >>>> >>>> I reviewed code patches, I still need to review the tests. >>>> I'll do that by the end of the week, but they looks good! >>> >>> Thanks for review! Ok, I'll wait for tests review, and then send next >>> version. >> >> Got your comments from review. I'll update patches by: >> 1) Trying to avoid touching util.c/util.h > > I mean, we can touch it ;-) but for this case it looks like we don't > need most of that functions to be there. > > At least for now. If we need them to be used in more places, then it > makes sense. Yes, I mean touching without need :) > >> 2) Add new header with functions shared between util vsock_perf and >> tests > > We can do this also later in another PR as cleanup if you prefer. > > Thanks, > Stefano >