From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A88139579 for ; Fri, 27 Dec 2024 23:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735342570; cv=none; b=iM0JgrzL7xzTjzzAXrFQAW1ELTn8GLw2Sk4Ou7/0DA64rrTAv3i+nZV6uKfpUdDS1lZ+bvtxo/87lTBaOmJoK/TOXj6r53k3AY+GtOkcAhtxRJ72WjIN3CahfFgT2GBfFYM2vdRBwQxyEMWGYswtnNnxCqi7CBkEKyabYd7zCqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735342570; c=relaxed/simple; bh=zj9QD3cmZP02xldwZjs7upJ7C/GGh59eo6541tM3L70=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=fJzzgH14NjVj5QQ/1WGp8+E1zoC1Dyq+vOPy6oEkF0dHxSGXRuYaWieJw90tgtI9v1NrkVEBMADnwXFTTzW4fTEeyTICIpOVd2Z0uo4x0TWUCijlBjo6kbQLZ5PeSXb/tpw5WPOjfnE97IP1VhDB5ArD0aY7WMwsvn5kGf7BBg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yepeilin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=B9PPhQkb; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yepeilin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="B9PPhQkb" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2ef9e38b0cfso9739235a91.0 for ; Fri, 27 Dec 2024 15:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735342569; x=1735947369; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=U1cvaO69byw0nGHFeA9yilXkgu6gKVdyllDmswCVIx8=; b=B9PPhQkbz369xUZxOSgkCy2UMIZwlqqRshl+qG+3lwnrcQqXamg8xeUAmsXR+QZ+7Z 2iGNnwNqngBrd9EaOLxF8d3QMj8jsN9iS9bimeYi1Nd5I5p1lM8hK3ca5wVS7RXW0eQR ZF/jWQPLPJri54m2lTO6pEWC7kYmodmb0//zyzP4yscWsaLUWJx+MVj5cBmjSX8EfooZ 2+fcSgZNI7iKm4CS81fMybEKls/dixaWAmPp6AJIZmMjoRN5JmMwl0u2tTTD46ult1Go E12/AYWIlsGfDpPQQuB/r/YU5oOML/J4wOlLHltuvPxejsGBIDu0iByStDhrniitbtce jIZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735342569; x=1735947369; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=U1cvaO69byw0nGHFeA9yilXkgu6gKVdyllDmswCVIx8=; b=UfQSWy9mQ0snMzqpoakbpwUK5BOl4oYb7ceNna2RzKF/Z6EM9Jenvg1JAaKQLOZ3jm SXls4zXphoXiDF67swiTxeghFi7VcVWwnDMCoLaUjhOHj27OWQHGAegdp+YRx0YrArPn A6hjKmINtLLhYty0meQHDlRNgkVEtFXyvoR1IeMsaCWVk4tOeAC0IQcGUz+ZDE2HbSOz KVp20NtkWwLZuOSnb2qotjF8OLy3tN7qgAfX6DHsdjAtLjL2qOS78BKpXUiJQOW/NGd1 t5FXVCeyv6Z/tkrE79qju1qKtWAXGdo8twbRtV+TzPrxs5eAWrw1Dbmf3jIS4gXGhOlu k+Ig== X-Forwarded-Encrypted: i=1; AJvYcCWoWHQplcssJOgEHQBJ+LYxqjSkuB8QP9nbQmyIhwdbc5cW5CyXJPTOoMlxvlWSdqykv0W4b0cIsMf5ePk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8PvYhMJxFZYDosOlLGsv6ZCEsw5Iccfe0GJ9oKnX3ct4yRxR1 Djmwl/4iRhMQgFr+nV3UO4VHqFXmA1m/r9OK+Y/B16Yc3FU5CpZhuemqQ7qg+5M9SyDXOxeaJIQ pIzgNGMQQtw== X-Google-Smtp-Source: AGHT+IFuJUZ9jsTKQSDCXDTwgQyNyL9rJWt4gk6hZ4XtzDy2D3InD9OFNgdY2aj5V6x5Yf9TAhT2yfJZ4RY9nQ== X-Received: from pjbsw12.prod.google.com ([2002:a17:90b:2c8c:b0:2ef:82c0:cb8d]) (user=yepeilin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:270d:b0:2ee:dd9b:e3e8 with SMTP id 98e67ed59e1d1-2f452dfd3b6mr46753319a91.8.1735342568743; Fri, 27 Dec 2024 15:36:08 -0800 (PST) Date: Fri, 27 Dec 2024 23:35:46 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <3b84fa17ab72f3f69e09e0032452d17eb13b80db.1735342016.git.yepeilin@google.com> Subject: [PATCH bpf-next 1/2] bpf, arm64: Simplify if logic in emit_lse_atomic() From: Peilin Ye To: bpf@vger.kernel.org Cc: Peilin Ye , Xu Kuohai , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Puranjay Mohan , Catalin Marinas , Will Deacon , Josh Don , Barret Rhoden , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Delete that unnecessary outer if clause. No functional changes. Signed-off-by: Peilin Ye --- arch/arm64/net/bpf_jit_comp.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index 66708b95493a..9040033eb1ea 100644 --- a/arch/arm64/net/bpf_jit_comp.c +++ b/arch/arm64/net/bpf_jit_comp.c @@ -648,16 +648,14 @@ static int emit_lse_atomic(const struct bpf_insn *insn, struct jit_ctx *ctx) const s16 off = insn->off; u8 reg = dst; - if (off || arena) { - if (off) { - emit_a64_mov_i(1, tmp, off, ctx); - emit(A64_ADD(1, tmp, tmp, dst), ctx); - reg = tmp; - } - if (arena) { - emit(A64_ADD(1, tmp, reg, arena_vm_base), ctx); - reg = tmp; - } + if (off) { + emit_a64_mov_i(1, tmp, off, ctx); + emit(A64_ADD(1, tmp, tmp, dst), ctx); + reg = tmp; + } + if (arena) { + emit(A64_ADD(1, tmp, reg, arena_vm_base), ctx); + reg = tmp; } switch (insn->imm) { -- 2.47.1.613.gc27f4b7a9f-goog