From: "Thayumanavar Sachithanantham" <thayumk@gmail.com>
To: akpm@osdl.org, info-linux@geode.amd.com,
linux-kernel@vger.kernel.org, rdunlap@xenotime.net
Subject: [PATCH]drivers/char/cs5535_gpio.c:call cdev_del during module_exit to unmap kobject references and other cleanups.
Date: Wed, 19 Apr 2006 12:22:03 +0530 [thread overview]
Message-ID: <3b8510d80604182352v11fea186lde1b9987447a3318@mail.gmail.com> (raw)
During module unloading, cdev_del be called to unmap cdev related
kobject references and other cleanups(such as inode->i_cdev being set
to NULL) which prevents the OOPS upon subsequent loading ,usage and
unloading of modules(as
seen in the mail thread
http://marc.theaimsgroup.com/?l=linux-kernel&m=114533640609018&w=2).
Patch against 2.6.17-rc1
Signed-off-by: Thayumanavar Sachithanantham <thayumk@gmail.com>
--- linux-2.6/drivers/char/cs5535_gpio.c.orig 2006-04-17
21:37:25.000000000 -0700
+++ linux-2.6/drivers/char/cs5535_gpio.c 2006-04-17
21:38:24.000000000 -0700
@@ -241,6 +241,7 @@ static int __init cs5535_gpio_init(void)
static void __exit cs5535_gpio_cleanup(void)
{
dev_t dev_id = MKDEV(major, 0);
+ cdev_del(&cs5535_gpio_cdev);
unregister_chrdev_region(dev_id, CS5535_GPIO_COUNT);
if (gpio_base != 0)
release_region(gpio_base, CS5535_GPIO_SIZE);
next reply other threads:[~2006-04-19 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-19 6:52 Thayumanavar Sachithanantham [this message]
2006-04-19 7:15 ` Andrew Morton
2006-04-19 7:51 ` Thayumanavar Sachithanantham
2006-04-19 9:35 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b8510d80604182352v11fea186lde1b9987447a3318@mail.gmail.com \
--to=thayumk@gmail.com \
--cc=akpm@osdl.org \
--cc=info-linux@geode.amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®