From: Ilya Maximets <i.maximets@ovn.org>
To: Yury Norov <yury.norov@gmail.com>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Cc: i.maximets@ovn.org
Subject: Re: [PATCH] net: openvswitch: Use for_each_cpu() where appropriate
Date: Tue, 19 Aug 2025 15:23:11 +0200 [thread overview]
Message-ID: <3b88c0fb-40de-41a4-9831-cb986bb6570e@ovn.org> (raw)
In-Reply-To: <20250818172806.189325-1-yury.norov@gmail.com>
On 8/18/25 7:28 PM, Yury Norov wrote:
> From: "Yury Norov (NVIDIA)" <yury.norov@gmail.com>
>
> Due to legacy reasons, openswitch code opencodes for_each_cpu() to make
> sure that CPU0 is always considered.
>
> Since commit c4b2bf6b4a35 ("openvswitch: Optimize operations for OvS
> flow_stats."), the corresponding flow->cpu_used_mask is initialized
> such that CPU0 is explicitly set.
>
> So, switch the code to using plain for_each_cpu().
>
> Suggested-by: Ilya Maximets <i.maximets@ovn.org>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> ---
> net/openvswitch/flow.c | 12 ++++--------
> net/openvswitch/flow_table.c | 7 +++----
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
> v1: https://lore.kernel.org/all/20250814195838.388693-1-yury.norov@gmail.com/
> v2:
> - always include CPU0 (Ilya);
nit: The subject prefix should've been [PATCH net-next v2].
The change itself looks correct to me. Thanks!
Acked-by: Ilya Maximets <i.maximets@ovn.org>
next prev parent reply other threads:[~2025-08-19 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 17:28 Yury Norov
2025-08-19 13:23 ` Ilya Maximets [this message]
2025-08-21 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b88c0fb-40de-41a4-9831-cb986bb6570e@ovn.org \
--to=i.maximets@ovn.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®