From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751280AbdH0LCD (ORCPT <rfc822;w@1wt.eu>);
        Sun, 27 Aug 2017 07:02:03 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:37634 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751135AbdH0LCA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 27 Aug 2017 07:02:00 -0400
Subject: Re: [PATCH 2/2] leds: gpio: Allow LED to retain state at shutdown
To: Andrew Jeffery <andrew@aj.id.au>
References: <20170825063503.31577-1-andrew@aj.id.au>
 <20170825063503.31577-3-andrew@aj.id.au> <20170825073239.GB15494@amd>
Cc: Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        rpurdie@rpsys.net, robh+dt@kernel.org, mark.rutland@arm.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        joel@jms.id.au, openbmc@lists.ozlabs.org
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <3b89ad70-7024-b4ac-bf4e-49a02d12da51@gmail.com>
Date: Sun, 27 Aug 2017 13:01:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170825073239.GB15494@amd>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On 08/25/2017 09:32 AM, Pavel Machek wrote:
> On Fri 2017-08-25 16:05:03, Andrew Jeffery wrote:
>> In some systems, such as BMCs, we want to retain the state of LEDs
>> across a reboot of the BMC whilst the host remains up.
> 
> I'd spell out what BMC is...

I agree with Pavel. Please give the expansion of the acronym
in both DT patch and the driver commit message.

> 
> Otherwise series looks good.
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
Best regards,
Jacek Anaszewski