From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932842AbdBVRuj (ORCPT ); Wed, 22 Feb 2017 12:50:39 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47035 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754252AbdBVRub (ORCPT ); Wed, 22 Feb 2017 12:50:31 -0500 Subject: Re: [PATCH 2/2] mm/cgroup: delay soft limit data allocation To: Michal Hocko References: <1487779091-31381-1-git-send-email-ldufour@linux.vnet.ibm.com> <1487779091-31381-3-git-send-email-ldufour@linux.vnet.ibm.com> <20170222171132.GB26472@dhcp22.suse.cz> Cc: Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Laurent Dufour Date: Wed, 22 Feb 2017 18:50:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170222171132.GB26472@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022217-0036-0000-0000-000003723429 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022217-0037-0000-0000-000015351EFF Message-Id: <3b8d0a31-d869-4564-0e03-ac621af43ce7@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-22_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702220163 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/2017 18:11, Michal Hocko wrote: > On Wed 22-02-17 16:58:11, Laurent Dufour wrote: > [...] >> static struct mem_cgroup_tree_per_node * >> soft_limit_tree_node(int nid) >> { >> @@ -465,6 +497,8 @@ static void mem_cgroup_update_tree(struct mem_cgroup *memcg, struct page *page) >> struct mem_cgroup_tree_per_node *mctz; >> >> mctz = soft_limit_tree_from_page(page); >> + if (!mctz) >> + return; >> /* >> * Necessary to update all ancestors when hierarchy is used. >> * because their event counter is not touched. >> @@ -502,7 +536,8 @@ static void mem_cgroup_remove_from_trees(struct mem_cgroup *memcg) >> for_each_node(nid) { >> mz = mem_cgroup_nodeinfo(memcg, nid); >> mctz = soft_limit_tree_node(nid); >> - mem_cgroup_remove_exceeded(mz, mctz); >> + if (mctz) >> + mem_cgroup_remove_exceeded(mz, mctz); >> } >> } >> > > this belongs to the previous patch, right? It may. I made the first patch fixing the panic I saw but if you prefer this to be part of the first one, fair enough. Tell me what you like.