From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta-64-227.siemens.flowmailer.net (mta-64-227.siemens.flowmailer.net [185.136.64.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7FD37F7FB for ; Mon, 3 Jun 2024 10:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.136.64.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717408953; cv=none; b=JfbhMt0Q6yBSC57FDf75xu37vaMrNTU7vRT3L83g+m1s5duHOcgDE6MNT1qWttoRM4W+Zg0fHDo17ZMhWHE1T+aAAtA/YFzMeg0lRN7pZqveGPklsom1nUvFy33Wlvk0kwIV+j4MFUoC/ey62Vqkx5IYAbHVMc0CHfNyhUW6w7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717408953; c=relaxed/simple; bh=6F+xgND2wYgrZVy5rOZdN1AVq49OQhyqsp74cZfsGNk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=enZ9D/ZAna6yCV6vSvkGPkB2YS4vq8JjqmcKluZH995GCayZ0Y179Yn+2TBIJthaw+UyRI0GGX06+SNHj47XOr0KhIlvJ0ttJ7hSEDSqG1BdMWEC48fOJnJLdUq5p3YcaIj62BNd6VpGm+ROqz/cY6hgkKiaE3iBiNPnM1Q3sCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com; dkim=pass (1024-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b=soRzjQM2; arc=none smtp.client-ip=185.136.64.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rts-flowmailer.siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=siemens.com header.i=diogo.ivo@siemens.com header.b="soRzjQM2" Received: by mta-64-227.siemens.flowmailer.net with ESMTPSA id 20240603100222fc1adba41f4a501b55 for ; Mon, 03 Jun 2024 12:02:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm2; d=siemens.com; i=diogo.ivo@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=Y4VG6T7y3DVLYv9REYgdn0MCsEnDoxm4kG3aaig4WS0=; b=soRzjQM2CxQYYzgwtxuKadFJBzAJjanFvejtSIQqpyo6355G0LB/n4KyNnMoDrB493BKKM 9SmB9SJ59sPEK/9z+XxtQlEmNxSslRKmCVvsSR+wUUc+inR/JQhgkzkWWz2mOvEDKntYbbfX DdhaFYOs4E91XOcdn74XTDwW/TK5I=; Message-ID: <3b8ef6f2-4a06-4028-8a6f-f63b30ff8930@siemens.com> Date: Mon, 3 Jun 2024 11:02:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events To: Sunil Kovvuri Goutham , MD Danish Anwar , Roger Quadros , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jan Kiszka Cc: "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , diogo.ivo@siemens.com References: <20240529-iep-v1-0-7273c07592d3@siemens.com> <20240529-iep-v1-2-7273c07592d3@siemens.com> Content-Language: en-US From: Diogo Ivo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-1320519:519-21489:flowmailer Hi Sunil, On 5/31/24 6:12 AM, Sunil Kovvuri Goutham wrote: >> From: Diogo Ivo >> Sent: Wednesday, May 29, 2024 9:35 PM >> >> + iep->cap_cmp_irq = platform_get_irq_byname_optional(pdev, >> "iep_cap_cmp"); >> + if (iep->cap_cmp_irq < 0) { >> + if (iep->cap_cmp_irq == -EPROBE_DEFER) >> + return iep->cap_cmp_irq; > > This info is coming from DT, is PROBE_DIFFER error return value possible ? From my understanding -EPROBE_DEFER is a possible error code. platform_get_irq_byname_optional() will eventually call of_irq_get() where we get -EPROBE_DEFER if the IRQ domain still hasn't been initialized. >> + iep->cap_cmp_irq = 0; >> + } else { >> + ret = devm_request_irq(dev, iep->cap_cmp_irq, >> + icss_iep_cap_cmp_irq, >> IRQF_TRIGGER_HIGH, >> + "iep_cap_cmp", iep); >> + if (ret) >> + return dev_err_probe(iep->dev, ret, >> + "Request irq failed for cap_cmp\n"); > > Can't this driver live without this feature ? Yes it can! I'll rework this logic so that we do not fail to probe here and simply continue without PPS event support. Thank you for the review! Best regards, Diogo