From: Abhinav Singh <singhabhinav9051571833@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
linux-kernel-mentees@lists.linuxfoundation.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL
Date: Tue, 7 Nov 2023 02:49:56 +0530 [thread overview]
Message-ID: <3b92b89b-ca72-4012-b4f2-0b19e4ba9153@gmail.com> (raw)
In-Reply-To: <CADnq5_OkWD3YmCKgXbtk=Gnba3AgAiAWp2z_nzHQvRfEOsdXVg@mail.gmail.com>
On 11/7/23 00:25, Alex Deucher wrote:
> Applied. This matches what we already do in the other clear state headers.
>
> Alex
>
> On Fri, Nov 3, 2023 at 12:00 PM Abhinav Singh
> <singhabhinav9051571833@gmail.com> wrote:
>>
>> sparse static analysis tools generate a warning with this message
>> "Using plain integer as NULL pointer". In this case this warning is
>> being shown because we are trying to intialize a pointer to NULL using
>> integer value 0.
>>
>> Signed-off-by: Abhinav Singh <singhabhinav9051571833@gmail.com>
>> ---
>> drivers/gpu/drm/radeon/clearstate_evergreen.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/clearstate_evergreen.h b/drivers/gpu/drm/radeon/clearstate_evergreen.h
>> index 63a1ffbb3ced..3b645558f133 100644
>> --- a/drivers/gpu/drm/radeon/clearstate_evergreen.h
>> +++ b/drivers/gpu/drm/radeon/clearstate_evergreen.h
>> @@ -1049,7 +1049,7 @@ static const struct cs_extent_def SECT_CONTEXT_defs[] =
>> {SECT_CONTEXT_def_5, 0x0000a29e, 5 },
>> {SECT_CONTEXT_def_6, 0x0000a2a5, 56 },
>> {SECT_CONTEXT_def_7, 0x0000a2de, 290 },
>> - { 0, 0, 0 }
>> + { NULL, 0, 0 }
>> };
>> static const u32 SECT_CLEAR_def_1[] =
>> {
>> @@ -1060,7 +1060,7 @@ static const u32 SECT_CLEAR_def_1[] =
>> static const struct cs_extent_def SECT_CLEAR_defs[] =
>> {
>> {SECT_CLEAR_def_1, 0x0000ffc0, 3 },
>> - { 0, 0, 0 }
>> + { NULL, 0, 0 }
>> };
>> static const u32 SECT_CTRLCONST_def_1[] =
>> {
>> @@ -1070,11 +1070,11 @@ static const u32 SECT_CTRLCONST_def_1[] =
>> static const struct cs_extent_def SECT_CTRLCONST_defs[] =
>> {
>> {SECT_CTRLCONST_def_1, 0x0000f3fc, 2 },
>> - { 0, 0, 0 }
>> + { NULL, 0, 0 }
>> };
>> static const struct cs_section_def evergreen_cs_data[] = {
>> { SECT_CONTEXT_defs, SECT_CONTEXT },
>> { SECT_CLEAR_defs, SECT_CLEAR },
>> { SECT_CTRLCONST_defs, SECT_CTRLCONST },
>> - { 0, SECT_NONE }
>> + { NULL, SECT_NONE }
>> };
>> --
>> 2.39.2
>>
Hi Alex, thanks for looking into this. By applied you mean this patch is
accepted and it has been merged?
next prev parent reply other threads:[~2023-11-06 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:50 Abhinav Singh
2023-11-06 11:23 ` Jani Nikula
2023-11-06 15:21 ` Abhinav Singh
2023-11-06 16:40 ` Jani Nikula
2023-11-06 18:19 ` Abhinav Singh
2023-11-06 18:55 ` Alex Deucher
2023-11-06 21:19 ` Abhinav Singh [this message]
2023-11-06 21:37 ` Alex Deucher
2023-11-07 6:03 ` Abhinav Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b92b89b-ca72-4012-b4f2-0b19e4ba9153@gmail.com \
--to=singhabhinav9051571833@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®