From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821F22F39B9 for ; Tue, 17 Feb 2026 11:46:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771328777; cv=none; b=uA/O4sjnUiAVHl6EZdMvC6ne/UrID+vx3wdCTxKbI1GTnoSBpKSwiulSC97UjHJgy3eTvidH7moUH+vWduzgQM1Y89rmo5rfc9uKYiWYgvL6Sv2XXktTdaUWpunV/4NBIjuTjp0teW61HknXHdnpT+jZe+YAWYiWzOjw+VjDrG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771328777; c=relaxed/simple; bh=sGTzj61xYJ1EFVupvf0NZw/NajElGdUjp1JLXk9f4yw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PO6UlunRWWd52aVo5Yp0Ixpjg6hUyPoAbOZkZ2BPakeZeQ+pALdahmHMzTbSQtD4+kbAsoGwFhyN8ISPvAxe7TtH8kTdX3H4UfaPovH1++/iRcRawKoLpFNecxaFYZ/jlvY0kC0HsPg6AMApo5EdaVXFDj/hQcFpgms1TFdCYm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pb/s5frp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V6+bJaU5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pb/s5frp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V6+bJaU5" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H9TJ7q985361 for ; Tue, 17 Feb 2026 11:46:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sCk9OpWnJfO2diGe6paKGh1+BeBt+jweQ3ZEQMMxtpg=; b=Pb/s5frp4NM4keU9 ilYpufn0l4Bz1pYY6VYR/LurTD0FIHXtS+ZpKXuCWs8ze0v/b0NDj9eOUzwmZ0Bg 8w9vdufyguK9g0HIW4dCv9WDHB4Wl3vlV7Rpmi1Z8/VONBIxrEk3Yzn/1yD+VoNy Dh2EXyYSGzsJJsUOVWSzv6/FNiO6GIzHqlktB2XxiENJ48fq8vrTqPxoDWpr9odb nV037rxU/V5Rc0QXwO7OqjKM3fXcsROF3PvoYSpH2MJibP4ar5yehblogfvxzgaA iFnwI3mhe1o7rAxVF1eFPu+Judte59GOvz2jAo4fiN6eUijJKtMZ2zpViVNvLfq7 RvQP2g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc7ap22fw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 11:46:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cb4025302aso330002285a.3 for ; Tue, 17 Feb 2026 03:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771328775; x=1771933575; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sCk9OpWnJfO2diGe6paKGh1+BeBt+jweQ3ZEQMMxtpg=; b=V6+bJaU5Map+jgYKfBhf8b352YER/QYTUyyWD2aHhwiBKpaucDZqWkjVxfF6l6qDSz dkSOly9zmiD+rPCnf7NOUkEBStWosWw3bZk1BNw5j3pXyDbj3dX1GUwlghCRfMy7b5sN 2FK7WsjNTGaMQUvYmGo8xkCOTiQlXXsRA2uuXSk1Q9DjYngeSXz1+pYV3cIlGa5m2KP3 Ak1Jt21Uh9O6YGpptewlZ37E86/5iMHArBGS3KFXWquNM+rzt4lkc1Vzml1LQb5I3pve MafNq2NFks/xb/M5cVtXmgU77EWuhiA4JU903nuddtGlGW5ixuUE5vjZQSnSrQ1NbZkP Q9/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771328775; x=1771933575; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sCk9OpWnJfO2diGe6paKGh1+BeBt+jweQ3ZEQMMxtpg=; b=bx5Pwoh5/TMdiQis1KTJWURjZ704Z2o7288rAetqXT4IjP1nbumN6vG6ibP3S5+zi8 p5ZObiEVJIuc9a5T2cH3TQCYRZP7nXxAYaVIHUowZRx8zio0D+3F71EAkodBZfN3f6kp N3/rJdbV7JQplLPTYWriyCbXV2rXGvGDkgy7gxG+/OqvRmr4rtGvqn+kbXmG+n6S0QOt Nq2rlt3egPej/3bifyDnHO5rGXEM3xPSdnJQnbg4kcyFowN8LtYqtisaxaGiFfaC98fT VR/FF2qbMdLo6hd66tprKMi1/VqXi3/08YotL8NFTXN1pYaL6N8x5/saW4hMV5JQbtl7 qVGw== X-Forwarded-Encrypted: i=1; AJvYcCU5qb0WcerHPJIe2zrLBvCNcPenkbEtJyjpf7pt/PX8beKVveRIj4g+IL6XrzGoZF/780uBJejllOjav10=@vger.kernel.org X-Gm-Message-State: AOJu0YwWAsXtHDcm8j+jIxDR7/K829PHn3vgom7KY+adB/2w3rYrX1Wy 4SgINSK7ikbXcNbarLRMcPewAnMWQXqEUbl5v8w6pEfp9i0t8PaEwXAFHecTjd+55LtHB1sb0B3 0iw/+nB61jmhR02cycE0XxaXtR5/jHR8KjwNAKWCRnTkZwxfn6vCrS6k+6m9tln/Xb5A= X-Gm-Gg: AZuq6aJ1bQepL5xb/+2bXhHST0yB9owpywXRPu/f/s3rw0WoCzUuH7K76lbTCAcjiBe 7b33ZxCGHCNEXMDKPTRY6Las2qGtOsZdnDpJhPYePzxQ3WFlRMNtFQRU9jHrNtcPHtbqjw+euQv +hC/+vgOJuI42RbkLqLzWzB+pMYvfE3MJEiUSIXvlpJgJcFHvqZD6HSAOoDYMRBEr2/5xD/p5ID j0vcXvKnbuIkf0frtbzOL15qj6CDf2glqGvsoHUYnbpsCw2dq9Q+ecPttpx6dp1JYQZjIl6f/hU eWw1LQWhos7oVTDeBFpFPCpitUDGjBcdJwss4T5Kas8merPGiWEm8Wd3JyF96WIYHPqG1qbm4RC EBc851jVYISZw727e1pmxRl5zxVP6a8YNI/Jkszdpr33JD9u2FpAmEfte6ckAFHFuexgITr4pAH n7viA= X-Received: by 2002:a05:620a:454f:b0:8ca:2e7:56c5 with SMTP id af79cd13be357-8cb40916695mr1244231385a.11.1771328774817; Tue, 17 Feb 2026 03:46:14 -0800 (PST) X-Received: by 2002:a05:620a:454f:b0:8ca:2e7:56c5 with SMTP id af79cd13be357-8cb40916695mr1244228885a.11.1771328774294; Tue, 17 Feb 2026 03:46:14 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7385f7asm351610766b.21.2026.02.17.03.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 03:46:13 -0800 (PST) Message-ID: <3b9821b4-68df-4f2b-a384-912a2dc98bf7@oss.qualcomm.com> Date: Tue, 17 Feb 2026 12:46:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 12/13] i2c: qcom-geni: Store of_device_id data in driver private struct To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-13-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260206174112.4149893-13-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA5OCBTYWx0ZWRfX99SlrEp19/OR 3dzfvvHw6E/xNeCy4244cV5hsCheuPlc+reERd1dC3c2nes+h4mqUaqzuC0wVxlAn8fGKz8F384 UWUdovEbGTgXznCkzCcQ7NgR+R1NY56bsqLbPg7zpbPxGZAl7lU0RZ1ydmsIJcSDemwMlCY2P+L s+eaCTzKlxVKA6kzRqKmBvUunfI/OTfyWE1UK8QFjIZJwzoCA003rkNYec3xnl3j6tzoOZBb/7N vBB6wMf4AlQ7NBTv/YIUWEfu1KoozlzEPVI7Jg00VcFrQEswM7zH4ZvOTjymf8tfQkJyyUzEUV3 1HU0CHnyUuYbwA4xZl+ZkSRM+WC3HcZuN1xNQuVezdasQPvPGSGqn/KK+AmaHa3gCJLk052QHCP N/l5nb6IZh57w8aGdfRtLpt2M1cFCedUysL3fb9bt7qomS3EsWABonj76F74kS8/WHH1NyoW7hb j/PYvFCnJ4otX+OPm6Q== X-Proofpoint-ORIG-GUID: MkVloBukDK4ne3OkhD4u7Jw1WZ5zFptO X-Proofpoint-GUID: MkVloBukDK4ne3OkhD4u7Jw1WZ5zFptO X-Authority-Analysis: v=2.4 cv=Rfydyltv c=1 sm=1 tr=0 ts=69945507 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=pV_FUetQsCUf9QfKx1wA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170098 On 2/6/26 6:41 PM, Praveen Talari wrote: > To avoid repeatedly fetching and checking platform data across various > functions, store the struct of_device_id data directly in the i2c > private structure. This change enhances code maintainability and reduces > redundancy. > > Acked-by: Viken Dadhaniya > Signed-off-by: Praveen Talari > --- [...] > - desc = device_get_match_data(&pdev->dev); > + gi2c->dev_data = device_get_match_data(&pdev->dev); > + if (!gi2c->dev_data) > + return -EINVAL; This is an improvement, but you still need this: diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index ae609bdd2ec4..08e5a1917933 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -933,8 +933,8 @@ static const struct i2c_algorithm geni_i2c_algo = { #ifdef CONFIG_ACPI static const struct acpi_device_id geni_i2c_acpi_match[] = { - { "QCOM0220"}, - { "QCOM0411" }, + { "QCOM0220", (kernel_ulong_t)&geni_i2c}, + { "QCOM0411", (kernel_ulong_t)&geni_i2c }, { } }; MODULE_DEVICE_TABLE(acpi, geni_i2c_acpi_match); for this check to not fail Konrad